Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 00:54:58 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     ChiaEn Wu <chiaen_wu@richtek.com>
Cc:     dan.carpenter@linaro.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, peterwu.pub@gmail.com,
        cy_huang@richtek.com
Subject: Re: [PATCH] power: supply: rt9467: Fix passing zero to
 'dev_err_probe'
Message-ID: <20230514225458.nngl45joh4crunal@mercury.elektranox.org>
References: <33c598f3655db56eed13a5b46a1468379f69349c.1683863629.git.chiaen_wu@richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="thiqvn36r3wkqzzv"
Content-Disposition: inline
In-Reply-To: <33c598f3655db56eed13a5b46a1468379f69349c.1683863629.git.chiaen_wu@richtek.com>
Precedence: bulk


--thiqvn36r3wkqzzv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, May 12, 2023 at 01:44:23PM +0800, ChiaEn Wu wrote:
> Fix passing zero to 'dev_err_probe()' in 'rt9467_request_interrupt()'
>=20
> Fixes: 6f7f70e3a8dd ("power: supply: rt9467: Add Richtek RT9467 charger d=
river")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202305111228.bHLWU6bq-lkp@intel.com/
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---

Thanks, queued to my fixes branch.

-- Sebastian

>  drivers/power/supply/rt9467-charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply=
/rt9467-charger.c
> index 73f744a..ea33693 100644
> --- a/drivers/power/supply/rt9467-charger.c
> +++ b/drivers/power/supply/rt9467-charger.c
> @@ -1023,7 +1023,7 @@ static int rt9467_request_interrupt(struct rt9467_c=
hg_data *data)
>  	for (i =3D 0; i < num_chg_irqs; i++) {
>  		virq =3D regmap_irq_get_virq(data->irq_chip_data, chg_irqs[i].hwirq);
>  		if (virq <=3D 0)
> -			return dev_err_probe(dev, virq, "Failed to get (%s) irq\n",
> +			return dev_err_probe(dev, -EINVAL, "Failed to get (%s) irq\n",
>  					     chg_irqs[i].name);
> =20
>  		ret =3D devm_request_threaded_irq(dev, virq, NULL, chg_irqs[i].handler,
> --=20
> 2.7.4
>=20

--thiqvn36r3wkqzzv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmRhZsIACgkQ2O7X88g7
+poYAQ/+MFGVHXC+3x6i2hhmnmJI7GuTUczxKXd2FeERNJ2Key71XmCOFt9UgxD0
sq+BhfHzV29tnF/NDVBPdmM8pBfmdphtx7UxTu11aqsc1KaiYP6A1wP0hLHeB++V
4GP0gyipzK89IqYo06qpTpMaKzf1uM1t6wSIqVy7V+Ojx9EIQjN7bVGgMGaZW0w0
2ZnI7LG38mSbujxurQWj4aYMyOoibgfCoTNu4+rVbH+y/9aR0PT2Q/iMuYSN9Dnr
XgfSUzo72KYIEEwTSjThI+dLQ/4Azlec6XXtZSnjF6T+bLQN4yx52nbsS7+z6rlK
ul+4Vu7/OpbMvyCYeLKERbUV3NCKOaURi29kLE5xQpo/Tbi71PXS1A12SQtMFu31
/3rF+v4DbJRZZhf7pz1sGeE8mzqD0Pc1ORlNOf/K8ybruWKaPfJnCpFV3jhv6t6a
bPq/cX+dQ5K0iI7RG5pS2C+SV0pBUUX6NQIN0rqqShmbcp+1KAfd1mhtO0S3mpnT
zvctcuZASIr6rApckX2U9d9f5eMRXOesq7+7/j2nV/9F3w55iRMK7sX/67t5Qg1u
w9t4GGUg3dq4kmwjQeN+RUeL+0Ku3xjLN+27tVpJOnSPy70ph3zdrOm/9Ycq8swa
VgHT7sRNzd7McsJLyeTx5mUm4X5e36ydjEIXEcLPT8DxdKwUCwk=
=2Hby
-----END PGP SIGNATURE-----

--thiqvn36r3wkqzzv--