Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1461550rwd; Sun, 14 May 2023 20:44:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7JigxO0odJKzJctt7UkRpJ3mHKxdF1L8buseFrW5sSitvl3PGu/EqXqFjqt/fSBHpWv5kh X-Received: by 2002:a05:6a20:440c:b0:ff:7ebe:279a with SMTP id ce12-20020a056a20440c00b000ff7ebe279amr39462138pzb.41.1684122275953; Sun, 14 May 2023 20:44:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684122275; cv=none; d=google.com; s=arc-20160816; b=rRwYOxClsaWc5BgETHOkEPFqE9vRVQuaW7iucXmzCloFoLo0RTSHsF1PjbSf9Paez2 7NGOkTCT/cAxBYBvUvD7Bcov1V5MC/4BcOVoIO1ZBJ8LrnygQSGzQ58Ql02T3X2B5DNw HJyAmH+hvXbjvRHzJCZ3zwg3k05vRZoGrO6BdKSoGyUnl7woicGO9UokCO4hUbTQONs0 i/Q5xkTBCvvr49deoShwTBPsrxqllwF25K14oTarquC0GUi47PxB5dgU6hfIukiIgOM7 7Hr9GsRZFSJDlTdPhadmncTLX9PqxfbTJLyGCw35tJLaDrkBoHgsswOiCQyz9oUI1/4a EUiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PBOPWKpKM2zUvJLIgGhVlTwl+DgcyN4v0T5IUNVZWM0=; b=n5C7wtR3U68Hl+AmrZz7h12bEJr6u2rtXJhTzXcrXW7SLilPBkpOiwqY4dmmtiT0gu /dgyP/52MgZRdcSVofwXJ4D078oZpSBgF3JzUNv6wX3NkqQZ9flYPpa09EieFc3mL7XM qGqTmdAZBBb5nnBvBEir01/t69E9iKNS8cfNbe/EXArX/1kmhHiUOD3DwNFRmX7b/4lg vFUABVvFF+g4wYuo9prdla8M/Ct/NQMlXss2o9DbujLRTAihhSN2aweR3gFhhfOVUYMQ xg7g8w43DHlv4Ie5hnZ1gJ17UN93RDduc5Pdi5P/X9G+Io8Jcoa7m3tO4uX5uSLoe6Ux v32A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aCoe9rO1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk10-20020a17090b33ca00b0024753cf81fasi31677133pjb.177.2023.05.14.20.44.20; Sun, 14 May 2023 20:44:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aCoe9rO1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239367AbjEODcS (ORCPT + 99 others); Sun, 14 May 2023 23:32:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239215AbjEODbO (ORCPT ); Sun, 14 May 2023 23:31:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD5721BF3; Sun, 14 May 2023 20:29:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 73CC161E42; Mon, 15 May 2023 03:29:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F339C433D2; Mon, 15 May 2023 03:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684121366; bh=TG5ju3S+RNtGFqAhtk0STPkps5Zp0Kz8CKHNO8GPt2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aCoe9rO1Z//mdd6cjobpHtOJ3Lu1csvpo8MQkTHlVgb/nQXVnkJEF0LEdNp00JBJm mKmotyktKmblyGdZ+oYCNLxeJcguVIoB24/I949z9Jd10iWGwK6iUoTM+wHA6QWgD1 z/z/FYz4CovtRFi8+lBUBgBt+DhCHMIAdqzU3qiKPbmznnKvjd+JQbTqw0dANU7N7E nlXbu55I88cd/KcfHzC+MNEcFp5QyDso91PskTAybA36b3Yz7ayQvPp2UyDU06P+gB x5kzb1QdmvSlGI/t6FTiZtIh1DOllRvFaoY5wJ1DreL34XmnxSKAZmD6SOiJmt4bSE fcNRtKpQNyhLw== From: Bjorn Andersson To: Krzysztof Kozlowski , Thara Gopinath , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Konrad Dybcio Cc: kernel test robot , stable@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH] soc: qcom: icc-bwmon: fix incorrect error code passed to dev_err_probe() Date: Sun, 14 May 2023 20:33:05 -0700 Message-Id: <168412158454.1260758.1921647245584791908.b4-ty@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230513111747.132532-1-krzysztof.kozlowski@linaro.org> References: <20230513111747.132532-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 May 2023 13:17:47 +0200, Krzysztof Kozlowski wrote: > Pass to dev_err_probe() PTR_ERR from actual dev_pm_opp_find_bw_floor() > call which failed, instead of previous ret which at this point is 0. > Failure of dev_pm_opp_find_bw_floor() would result in prematurely ending > the probe with success. > > Fixes smatch warnings: > > [...] Applied, thanks! [1/1] soc: qcom: icc-bwmon: fix incorrect error code passed to dev_err_probe() commit: 3530167c6fe8001de6c026a3058eaca4c8a5329f Best regards, -- Bjorn Andersson