Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230507144753.192959-1-krzysztof.kozlowski@linaro.org> <CAAQKjZNx2xp-tzfpEhA4ET94bTtaV_P6P+P6bQiDTnR_4zG3Ew@mail.gmail.com>
In-Reply-To: <CAAQKjZNx2xp-tzfpEhA4ET94bTtaV_P6P+P6bQiDTnR_4zG3Ew@mail.gmail.com>
From:   Inki Dae <daeinki@gmail.com>
Date:   Mon, 15 May 2023 13:16:30 +0900
Message-ID: <CAAQKjZP7T6864R4V9GAGbL60-e-VFohPqONB7V=fTXVSX+=jWw@mail.gmail.com>
Subject: Re: [PATCH] drm/exynos: g2d: staticize stubs in header
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Seung-Woo Kim <sw0312.kim@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2023=EB=85=84 5=EC=9B=94 15=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 1:13, I=
nki Dae <daeinki@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Hi Krzysztof,
>
> 2023=EB=85=84 5=EC=9B=94 7=EC=9D=BC (=EC=9D=BC) =EC=98=A4=ED=9B=84 11:48,=
 Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
> >
> > Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
> > inline:
>
> Same patch[1] was posted before so I picked up the previous one.
>
> [1] [PATCH] drm/exynos: fix g2d_open/close helper function definitions
> (kernel.org)

[1] https://lore.kernel.org/lkml/20230425165618.2ztg4mecuvpkdg3a@intel.inte=
l/T/

Just corrected the link.

>
> Thanks,
> Inki Dae
>
> >
> >   drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous pr=
ototype for =E2=80=98g2d_open=E2=80=99 [-Wmissing-prototypes]
> >   drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous pr=
ototype for =E2=80=98g2d_close=E2=80=99 [-Wmissing-prototypes]
> >
> > Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API"=
)
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/=
exynos/exynos_drm_g2d.h
> > index 74ea3c26dead..1a5ae781b56c 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> > @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_=
device *dev, void *data,
> >         return -ENODEV;
> >  }
> >
> > -int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> > +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file=
 *file)
> >  {
> >         return 0;
> >  }
> >
> > -void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> > +static inline void g2d_close(struct drm_device *drm_dev, struct drm_fi=
le *file)
> >  { }
> >  #endif
> > --
> > 2.34.1
> >