Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1557578rwd; Sun, 14 May 2023 22:50:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4lakLF1Rms9qlMt1duZkd9JuWs/GQyLWQEcG9NsDev4aJpkcBORerjHqXpNexI5oL6VmML X-Received: by 2002:a05:6a20:4658:b0:ef:95de:b877 with SMTP id eb24-20020a056a20465800b000ef95deb877mr33315423pzb.10.1684129812128; Sun, 14 May 2023 22:50:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684129812; cv=none; d=google.com; s=arc-20160816; b=GbM2uCm0diy1JYJJlnWdSvnGxfshnZ5DHdxtYXU9uQ67FDZQ5HEbmydE1KDCYqLFvZ woaCCP9RKbSgQ4dkL8dPA+Y3G/9uoE7lK7AbUMwwyxDmTuQYS8pLHZfcdPgfiRpLXGBy x0vwyenuH/aLtqpFWU4TNk6RN/zYcnKufkuIHX+4k4sY9J1WJvhhEUwBRD6RECj0Dhh2 0CINfsZKwERMkeenXKwYks4QG2d6BMOCE3AYzg4xL1pb4eNYXFWWQIR6nc1wJuElzXPr 5rRyn58mkHEETbNaTEntfNqfopGBW4c2mMLIrd3KBW++GOtWBebncLAAgdtFx2D7bB1P a/KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=Xn/4iPFMpZTXnGK9F6ij7mF1jUcw22FAkTYXBxY2gU8=; b=z0a7QpvDs0J2/0exTRva2O85WcCE70nfiiPAkEybE8/JTt6NzpOebe13813MEvPr5J dDdyuFsOy7IL2V7xviaAd0VWLhLKvxSp1YMwACGzXR457s2TcQ5Mglf05ridLehkiIPq +eXKm7VEXEtHkUUGO4eglM4GZ9Ba1MnUaF6t6TmDPw2l51pqDOvCUfUr8xjCMdW2Awe/ O5LrA121VBF1rkLzFA8CcxQB9R3c5kUAvTlmwFvaixjOJ47sUk0ubyLeF5B2mdQLrtRx LuVtotEVu6Bbv62ZllteVsg00XzXtyn/tAKY15EpXQpEp/e9he3b2+oftOR9LmACMdHu r+7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y12-20020aa78f2c000000b0064367018c21si16656497pfr.12.2023.05.14.22.49.58; Sun, 14 May 2023 22:50:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235634AbjEOFdr (ORCPT + 99 others); Mon, 15 May 2023 01:33:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjEOFdp (ORCPT ); Mon, 15 May 2023 01:33:45 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25AA3E4F; Sun, 14 May 2023 22:33:41 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id BD73F80CF; Mon, 15 May 2023 13:33:39 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 15 May 2023 13:33:39 +0800 Received: from [192.168.60.149] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 15 May 2023 13:33:39 +0800 Message-ID: Date: Mon, 15 May 2023 13:33:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 1/6] media: dt-bindings: Add JH7110 Camera Subsystem Content-Language: en-US To: Conor Dooley CC: Mauro Carvalho Chehab , Robert Foss , Todor Tomov , , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Philipp Zabel , "Laurent Pinchart" , Hans Verkuil , Eugen Hristev , Ezequiel Garcia , , , , References: <20230512102844.51084-1-jack.zhu@starfivetech.com> <20230512102844.51084-2-jack.zhu@starfivetech.com> <20230512-sasquatch-untracked-1587b55c2008@spud> From: Jack Zhu In-Reply-To: <20230512-sasquatch-untracked-1587b55c2008@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/13 4:13, Conor Dooley wrote: > On Fri, May 12, 2023 at 06:28:39PM +0800, Jack Zhu wrote: > >> +description: >> + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It >> + consists of a VIN controller (Video In Controller, a top-level control until) >> + and an ISP. > > Just a minor comment here, "until" is a typo, right? > I guess it should be "unit". Yes, will modify it in next version. Thank you for your review.