Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 13:20:52 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     liming.wu@jaguarmicro.com, will@kernel.org
Cc:     mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, robin.murphy@arm.com
Subject: Re: [PATCH] perf/arm-cmn: fix compilation issue
Message-ID: <ZGHPRHj1gb3tPR9C@debian.me>
References: <20230515012930.946-1-liming.wu@jaguarmicro.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="H2fnbjCMW2orwer3"
Content-Disposition: inline
In-Reply-To: <20230515012930.946-1-liming.wu@jaguarmicro.com>
Precedence: bulk


--H2fnbjCMW2orwer3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 15, 2023 at 09:29:30AM +0800, liming.wu@jaguarmicro.com wrote:
> From: Liming Wu <liming.wu@jaguarmicro.com>
>=20
> This patch is used to fix following compilation issue with legacy gcc
> and define variables at the beginning of the function

What GCC version?

>=20
> error: =E2=80=98for=E2=80=99 loop initial declarations are only allowed i=
n C99 or C11 mode
> 2098 |                 for (int p =3D 0; p < CMN_MAX_PORTS; p++)
>=20
> Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
> ---
>  drivers/perf/arm-cmn.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 47d359f72957..2299fcde5b4a 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -2009,8 +2009,11 @@ static int arm_cmn_discover(struct arm_cmn *cmn, u=
nsigned int rgn_offset)
>  	u16 child_count, child_poff;
>  	u32 xp_offset[CMN_MAX_XPS];
>  	u64 reg;
> -	int i, j;
> +	int i, j, p;
>  	size_t sz;
> +	void __iomem *xp_region;
> +	struct arm_cmn_node *xp;
> +	unsigned int xp_ports;
> =20
>  	arm_cmn_init_node_info(cmn, rgn_offset, &cfg);
>  	if (cfg.type !=3D CMN_TYPE_CFG)
> @@ -2067,9 +2070,9 @@ static int arm_cmn_discover(struct arm_cmn *cmn, un=
signed int rgn_offset)
>  	cmn->dns =3D dn;
>  	cmn->dtms =3D dtm;
>  	for (i =3D 0; i < cmn->num_xps; i++) {
> -		void __iomem *xp_region =3D cmn->base + xp_offset[i];
> -		struct arm_cmn_node *xp =3D dn++;
> -		unsigned int xp_ports =3D 0;
> +		xp_region =3D cmn->base + xp_offset[i];
> +		xp =3D dn++;
> +		xp_ports =3D 0;
> =20
>  		arm_cmn_init_node_info(cmn, xp_offset[i], xp);
>  		/*
> @@ -2095,7 +2098,7 @@ static int arm_cmn_discover(struct arm_cmn *cmn, un=
signed int rgn_offset)
>  		 * from this, since in that case we will see at least one XP
>  		 * with port 2 connected, for the HN-D.
>  		 */
> -		for (int p =3D 0; p < CMN_MAX_PORTS; p++)
> +		for (p =3D 0; p < CMN_MAX_PORTS; p++)
>  			if (arm_cmn_device_connect_info(cmn, xp, p))
>  				xp_ports |=3D BIT(p);
> =20

Is above manually tracking xp* variables?

I'm confused...

--=20
An old man doll... just what I always wanted! - Clara

--H2fnbjCMW2orwer3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZGHPRAAKCRD2uYlJVVFO
o4sjAQCp49jf7V3MjKpce1LZwM/YKQbpqc5FWg36EPVfX+fFiwEAuXOHihstoHRW
Vm+NdnITZUtgCY/YQE5pw7JGFQVk1wA=
=TmGt
-----END PGP SIGNATURE-----

--H2fnbjCMW2orwer3--