Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230506085903.96133-1-wuyun.abel@bytedance.com>
 <588689343dcd6c904e7fc142a001043015e5b14e.camel@redhat.com>
 <d2abfe0c-0152-860c-60f7-2787973c95d0@bytedance.com> <6b355d57-30b4-748d-87f4-d79a50fe5487@bytedance.com>
In-Reply-To: <6b355d57-30b4-748d-87f4-d79a50fe5487@bytedance.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Mon, 15 May 2023 09:21:05 +0200
Message-ID: <CANn89iJqzE6r9dm2hoHxgYeLQvStZYvRhCxFVmpV_LczaO-4xw@mail.gmail.com>
Subject: Re: [PATCH] sock: Fix misuse of sk_under_memory_pressure()
To:     Abel Wu <wuyun.abel@bytedance.com>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 15, 2023 at 9:04=E2=80=AFAM Abel Wu <wuyun.abel@bytedance.com> =
wrote:
>
> Gentle ping :)
>

I still do not understand the patch.

If I do not understand the patch and its changelog now in May 2023,
how will anyone understand it later
when/if a regression is investigated ?

I repeat :

Changelog is evasive, I do not see what practical problem you want to solve=
.


sk_has_memory_pressure() is not about memcg, simply the fact that a
proto has a non NULL memory_pressure pointer.

I suggest that you answer these questions, and send a V2 with an
updated changelog.

Again, what is the practical problem you want to solve ?
What is the behavior of the current stack that you think is a problem ?

Thanks.