Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v9 2/2] spi: loongson: add bus driver for the loongson spi
 controller
To:     andy.shevchenko@gmail.com
Cc:     Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
        wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn
References: <20230426071045.20753-1-zhuyinbo@loongson.cn>
 <20230426071045.20753-3-zhuyinbo@loongson.cn> <ZFkPZhF8QqScXAmH@surfacebook>
 <049c871d-c658-24c1-91e6-701098f5fc28@loongson.cn>
From:   zhuyinbo <zhuyinbo@loongson.cn>
Message-ID: <16913b76-0256-492a-ec90-d367f2b52cc3@loongson.cn>
Date:   Mon, 15 May 2023 16:14:00 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <049c871d-c658-24c1-91e6-701098f5fc28@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/5/11 下午3:18, zhuyinbo 写道:
> 
> 
> 在 2023/5/8 下午11:04, andy.shevchenko@gmail.com 写道:

>>
>>> +config SPI_LOONGSON_CORE
>>> +    tristate "Loongson SPI Controller Core Driver Support"
>>
>> Does it need to be visible to the user?
> 


I try to set it invisible that by removing the SPI_LOONGSON_CORE Kconfig
or removing "tristate "Loongson SPI Controller Core Driver Support" that
will cause spi-core driver doesn't be compiled or compiled fail issue,
so I will still set it visible to the user.

>>
>>> +    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> +    if (res == NULL) {
>>
>> Why not using devm_platform_ioremap_resource()?
> okay, I will use it.
>>
>>> +        dev_err(dev, "cannot get io resource memory\n");
>>> +        return -ENOENT;
>>
>>     return dev_err_probe();


It seems that there is no need to print memory log when use
devm_platform_ioremap_resource because this function had contained
the this memory log print thus I will return PTR_ERR(reg_base).

         reg_base = devm_platform_ioremap_resource(pdev, 0);
         if (IS_ERR(reg_base))
                 return PTR_ERR(reg_base);

Thanks.

>>
>>