Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1720452rwd; Mon, 15 May 2023 01:58:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5lL3lRIjwBOhMLjj36erBHAMzoKceJWXIPbBlSdDfI1bRUl4u452cQFmE1ZJWLpdo4+epp X-Received: by 2002:a05:6a20:a123:b0:105:12ab:878f with SMTP id q35-20020a056a20a12300b0010512ab878fmr8574592pzk.56.1684141101455; Mon, 15 May 2023 01:58:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684141101; cv=none; d=google.com; s=arc-20160816; b=YHAZ6BdRFVcItPTb+zeVmmahNS0RZJfzFEtqShGwy9RDY25fYp6/ckddQzzi4UFzCK pRCzTl4bk8zO+f8sZHtCNqeJelIOvB4jYFLiDd1jjAMjfuEtjKb0SXftmbu3CLbxKbrz q8NKXb1apGeEawvxrHz1ren2FUub8qme6tuHMOLMYc3q37+V/NEdI8kYBCQUaf8Zx5zQ rgyPTJHrLNt5xdscJpA9OUMNLZqjA233khZPvRdcqlRY4thOMgn3cn7eYVSPfdZteS5N F01CcZqTj3eKrCWjVolyRj3v/oOTYSXFfTQbnTJZHCmYj/ZguEXQWaRGahXszKOrijUt /aSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=M0Zz1BQ+Xq0x7wYppN4YVzJqO7n3zaVNgoDk85EsaRk=; b=hd0I8aRH5DbKA++E21y+eR3jnQpyaCbb6a8wAtqg/fRdCb1dY+o2Y0JxjTL0cgdF6+ jeYWEs8xdkmx8qzzrjC64/vzXuJ4FlTYRzxTSVXpE9JgrjEgqm5Rl7YZ3S2YA9fNw+qJ MI/Wb+EVRxMw34QiffQI08TU5ff4XJ7t5OkcOPymyh7LePiL7NU9fRb95tM1frBb6iSG TetU8HHLDkADM1nEwQEaw9JzEGcNMRKUikT6khlwtSeUyOJbVLrChk/i6btHgbfPkQgP ByincUXc0kIpnSvamueXPxOTPg6dh1914QBKeicV10s0KcNl4c4bmn6zyZK2Do7hx84D PO9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b5-20020a639305000000b0052ca3209fc9si16028712pge.654.2023.05.15.01.58.09; Mon, 15 May 2023 01:58:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237303AbjEOIpB (ORCPT + 99 others); Mon, 15 May 2023 04:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233993AbjEOIo7 (ORCPT ); Mon, 15 May 2023 04:44:59 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A28B0B0; Mon, 15 May 2023 01:44:57 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id AAA9724E1CF; Mon, 15 May 2023 16:44:55 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 15 May 2023 16:44:55 +0800 Received: from [192.168.125.124] (113.72.146.187) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 15 May 2023 16:44:54 +0800 Message-ID: Date: Mon, 15 May 2023 16:44:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 3/3] riscv: dts: starfive: add the node and pins configuration for tdm Content-Language: en-US To: Mark Brown , Liam Girdwood , Claudiu Beznea , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing CC: , , , References: <20230511091549.28003-1-walker.chen@starfivetech.com> <20230511091549.28003-4-walker.chen@starfivetech.com> From: Walker Chen In-Reply-To: <20230511091549.28003-4-walker.chen@starfivetech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.187] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/11 17:15, Walker Chen wrote: > Add the tdm controller node and pins configuration of tdm for the > StarFive JH7110 SoC. > > Signed-off-by: Walker Chen > --- > .../jh7110-starfive-visionfive-2.dtsi | 40 +++++++++++++++++++ > arch/riscv/boot/dts/starfive/jh7110.dtsi | 21 ++++++++++ > 2 files changed, 61 insertions(+) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > index 1155b97b593d..19b5954ee72d 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > @@ -214,6 +214,40 @@ > slew-rate = <0>; > }; > }; > + > + tdm0_pins: tdm0-pins { > + tdm0-pins-tx { > + pinmux = + GPOEN_ENABLE, > + GPI_NONE)>; > + bias-pull-up; > + drive-strength = <2>; > + input-disable; > + input-schmitt-disable; > + slew-rate = <0>; > + }; > + > + tdm0-pins-rx { > + pinmux = + GPOEN_DISABLE, > + GPI_SYS_TDM_RXD)>; > + input-enable; > + }; > + > + tdm0-pins-sync { > + pinmux = + GPOEN_DISABLE, > + GPI_SYS_TDM_SYNC)>; > + input-enable; > + }; > + > + tdm0-pins-pcmclk { > + pinmux = + GPOEN_DISABLE, > + GPI_SYS_TDM_CLK)>; > + input-enable; > + }; > + }; > }; > > &uart0 { > @@ -221,3 +255,9 @@ > pinctrl-0 = <&uart0_pins>; > status = "okay"; > }; > + > +&tdm { > + pinctrl-names = "default"; > + pinctrl-0 = <&tdm0_pins>; > + status = "okay"; > +}; > diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi > index 866313570a7e..cfda6fb0d91b 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi > @@ -366,6 +366,27 @@ > status = "disabled"; > }; > > + tdm: tdm@10090000 { > + compatible = "starfive,jh7110-tdm"; > + reg = <0x0 0x10090000 0x0 0x1000>; > + clocks = <&syscrg JH7110_SYSCLK_TDM_AHB>, > + <&syscrg JH7110_SYSCLK_TDM_APB>, > + <&syscrg JH7110_SYSCLK_TDM_INTERNAL>, > + <&syscrg JH7110_SYSCLK_TDM_TDM>, > + <&syscrg JH7110_SYSCLK_MCLK_INNER>, > + <&tdm_ext>; > + clock-names = "tdm_ahb", "tdm_apb", > + "tdm_internal", "tdm", > + "mclk_inner", "tdm_ext"; > + resets = <&syscrg JH7110_SYSRST_TDM_AHB>, > + <&syscrg JH7110_SYSRST_TDM_APB>, > + <&syscrg JH7110_SYSRST_TDM_CORE>; > + dmas = <&dma 20>, <&dma 21>; > + dma-names = "rx","tx"; > + #sound-dai-cells = <0>; > + status = "disabled"; > + }; > + > stgcrg: clock-controller@10230000 { > compatible = "starfive,jh7110-stgcrg"; > reg = <0x0 0x10230000 0x0 0x10000>; Hi Conor / Emil, Based on our discussion a few days ago, the new version of patch for dts looks like this, Please help to review and provide your comments if you feel free. Thank you very much! Best regards, Walker