Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 16:45:34 +0800
From:   Ming Lei <ming.lei@redhat.com>
To:     Wenchao Hao <haowenchao2@huawei.com>
Cc:     "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linfeilong@huawei.com, louhongxiang@huawei.com
Subject: Re: [PATCH 1/2] Revert "scsi: core: Do not increase scsi_device's
 iorequest_cnt if dispatch failed"
Message-ID: <ZGHxLixW2rR34S+e@ovpn-8-26.pek2.redhat.com>
References: <20230515070156.1790181-1-haowenchao2@huawei.com>
 <20230515070156.1790181-2-haowenchao2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230515070156.1790181-2-haowenchao2@huawei.com>
Precedence: bulk

On Mon, May 15, 2023 at 03:01:55PM +0800, Wenchao Hao wrote:
> the "atomic_inc(&cmd->device->iorequest_cnt)" in scsi_queue_rq() would
> causes kernel panic, because cmd->device may be freed after returning
> from scsi_dispatch_cmd().
> 
> This reverts commit cfee29ffb45b1c9798011b19d454637d1b0fe87d.
> 
> Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
> Reported-by: Ming Lei <ming.lei@redhat.com>
> Closes:https://lore.kernel.org/linux-scsi/8e0f2d31-e6ff-ec4a-3974-450560ad49c5@huawei.com/T/#t

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming