Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 15 May 2023 11:37:55 +0200
Message-Id: <CSMR1BXJMLYU.1YUU6374U6T7H@otso>
Cc:     <amahesh@qti.qualcomm.com>, <arnd@arndb.de>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Abaci Robot" <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] fastrpc: Use memdup_user instead of
 kmalloc/copy_from_user
From:   "Luca Weiss" <luca.weiss@fairphone.com>
To:     "Yang Li" <yang.lee@linux.alibaba.com>,
        <srinivas.kandagatla@linaro.org>
References: <20230515092604.79990-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20230515092604.79990-1-yang.lee@linux.alibaba.com>
Precedence: bulk

Hi Yang Li,

On Mon May 15, 2023 at 11:26 AM CEST, Yang Li wrote:
> Use memdup_user rather than duplicating its implementation, which
> makes code simple and easy to understand, and silence the following
> warning:
>
> ./drivers/misc/fastrpc.c:1259:8-15: WARNING opportunity for memdup_user
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D4949
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/misc/fastrpc.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index f60bbf99485c..a897dab13c61 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -1256,16 +1256,9 @@ static int fastrpc_init_create_static_process(stru=
ct fastrpc_user *fl,
>  		goto err;
>  	}
> =20
> -	name =3D kzalloc(init.namelen, GFP_KERNEL);
> -	if (!name) {
> -		err =3D -ENOMEM;
> -		goto err;
> -	}
> -
> -	if (copy_from_user(name, (void __user *)(uintptr_t)init.name, init.name=
len)) {
> -		err =3D -EFAULT;
> -		goto err_name;
> -	}
> +	name =3D memdup_user((void __user *)(uintptr_t)init.name, init.namelen)=
;
> +	if (IS_ERR(name))
> +		return PTR_ERR(name);

Don't we still need a "goto err;" here to free args?

Something like this:

  if (IS_ERR(name)) {
      err =3D PTR_ERR(name);
      goto err;
  }

Regards
Luca


> =20
>  	if (!fl->cctx->remote_heap) {
>  		err =3D fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen,