Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <Horatiu.Vultur@microchip.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 0/7] net: lan966x: Add support for PCP, DEI, DSCP
Thread-Topic: [PATCH net-next 0/7] net: lan966x: Add support for PCP, DEI,
 DSCP
Thread-Index: AQHZhqBNX84lQm0AXUiEdanfIVPlcK9bGYuA
Date:   Mon, 15 May 2023 09:55:38 +0000
Message-ID: <ZGIBmSLEokFGvgkM@DEN-LT-70577>
References: <20230514201029.1867738-1-horatiu.vultur@microchip.com>
In-Reply-To: <20230514201029.1867738-1-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ujUzuTlfzFXM8VdFFqUENMZki0P94xusiR3YOtAXCsySeTBDFqV/K1yDYY0X?=
 =?us-ascii?Q?8XBijQUQJnyNWvAWry62e6+wu+VC176aJESG9QQ5nlLVxPs62Lb2k+pGH8OU?=
 =?us-ascii?Q?txNPwMRPxxx8/9V8v7Ltll78PETtH9V0Z4LaWJq6DPUxNN4ECFaO8u5jogGr?=
 =?us-ascii?Q?a6qb8RvYlT1VY64gAMquptdL++j5jvCZzVOyD4qz3B2vegGIuAYU5/B65fsY?=
 =?us-ascii?Q?Nv+QZ4Wx2AuqRkRe107Noec7q1NfeH/IEf4eoT2e+XTXjHFtKR8Aw5RjVDLG?=
 =?us-ascii?Q?LV+CIZeveBhLNf94JVcRKFK6BGwyyzJt814rSuL0g1wB23f+N2nTMoFAPxEJ?=
 =?us-ascii?Q?jcvoRjZFSC/IVmFTCmCOEML9kcwTJvIFKIvKdbvkFkIYEifIgjo7/PwgeP9/?=
 =?us-ascii?Q?7gYeGywOj6XQPyJEj4ScrkturApx3og/7Eo84aQFM02TE0NdZm56/Tt6FgMb?=
 =?us-ascii?Q?BssCFctxhhesutqxKlIQr+FA0VneR68UB4Mgr2AJAIxL45KXQWQyB7MQvxrw?=
 =?us-ascii?Q?7MlBs+P9d2N3pYLy4JJezuDAB0KzyGNLEpsjB71CIJbPfqD0VQb/GSUJtQxN?=
 =?us-ascii?Q?+Qs0o39SSSHyMwkCh9V6BQoeHiZjNNHFQvbcQwsTr40h0RNVgwaP8R5f4VpO?=
 =?us-ascii?Q?e/u6mHKLWh3foXSZvVAzTmINJlcK8+V9J+Xj8OoST965EWAUxC7WvWBm79Td?=
 =?us-ascii?Q?mZh4Gytt00UZDVtIHGQzQDTPdIu0KXqUqicTgROXPc7ECRT5wjoYzTbymAyd?=
 =?us-ascii?Q?nxmmwxg1SsjRv/3eO04MN9ZEY8htU9OGvIXHW/cEu23wtOD03LfctRG5Y5OW?=
 =?us-ascii?Q?GKYuZyEqS/i7nNBUsOHvQDHhufPe406J4xCuaMV0D/ZNlOBgajwkjKs92SEj?=
 =?us-ascii?Q?Zdbf6BNsRZrCbS6qnhNNo89FeKvQwreCkNGHKfDsBDY1r7WyIC4G7mhBOMYz?=
 =?us-ascii?Q?MrBXXXTE8V8haq//0hWf4FFt17a3xsyGqcadOy0YSajfEK1wtec3Lf+aCkSt?=
 =?us-ascii?Q?GQc159R+FyKmBuaujhfKdiF6OcibG5fpvj6K46T9Kr5PHodzxRtT2j+JoqHG?=
 =?us-ascii?Q?PtzzA+TOGLefhyUNEJ8cQjCJnrEtLzw14sw4Ah1xEfUtqefmLhgD5mW8r2u+?=
 =?us-ascii?Q?CUiVyGPesz7/h8NFILTIZN9Ef524vCED8fISyALxE8VpHzyTVTK9U2A9M0RE?=
 =?us-ascii?Q?Ene77887ku1DgsveMDZGNdNodwlOxfr+3HVSDsgZqAJ8TN5GwdpBVbcp06/R?=
 =?us-ascii?Q?I09v0Fzav5KlNY0+JSC3eHz2qFsa+Ay8GUgtVJzdHswcyk9/yo4LuHwwZ3Hv?=
 =?us-ascii?Q?nhcuvDxhheCeYlV+yndK0rBRjvcgohymLCClWouy+525KD1ktzxSwn46CXxY?=
 =?us-ascii?Q?gXQFGNBSmbDXzozJM4o8eOPx0gQbR0Bh5IhaVv04YCxciXy31is9ahVpk1tL?=
 =?us-ascii?Q?cjvSqJP0N0JtoaQIuL/X4sNXf55WMZZRYNsOGVw8JIz2kKEMs703QmmRe0pa?=
 =?us-ascii?Q?+jFHATtfDJgz1eHlZpJ76lnbjwAARl6HfhtCeajp3ZX9FE2opsrCRmCOfkTb?=
 =?us-ascii?Q?Nep9UN2cPguRt2Tn8HGgssiG4xCRQ6QODgS48Gh6m7FsXGggzbAgoJyR4u+o?=
 =?us-ascii?Q?VA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F444415A4A82824EA9A89EB3D11B5199@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8f47638-3864-4880-065e-08db552a8973
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2023 09:55:38.5541
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uT8l+VPffit/yf9979omwyVSqBes2Wg/Fn0UL+mTbvghlQKP317JI2/LsLtVY7g8tzXVBm5Aujt8W70khgYCX0XNwC0G7s1V9MZ6hYGOsps=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6397
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This patch series extends lan966x to offload to the hardware the
> following features:
> - PCP: this configuration is per port both at ingress and egress.
> - App trust: which allows to specify a trust order of app selectors.
>   This can be PCP or DSCP or DSCP/PCP.
> - default priority
> - DSCP: this configuration is shared between the ports both at ingress
>   and egress.
>=20
> Horatiu Vultur (7):
>   net: lan966x: Add registers to configure PCP, DEI, DSCP
>   net: lan966x: Add support for offloading pcp table
>   net: lan966x: Add support for apptrust
>   net: lan966x: Add support for offloading dscp table
>   net: lan966x: Add support for offloading default prio
>   net: lan966x: Add support for PCP rewrite
>   net: lan966x: Add support for DSCP rewrite
>=20
>  .../net/ethernet/microchip/lan966x/Kconfig    |  11 +
>  .../net/ethernet/microchip/lan966x/Makefile   |   1 +
>  .../ethernet/microchip/lan966x/lan966x_dcb.c  | 366 ++++++++++++++++++
>  .../ethernet/microchip/lan966x/lan966x_main.c |   2 +
>  .../ethernet/microchip/lan966x/lan966x_main.h |  57 +++
>  .../ethernet/microchip/lan966x/lan966x_port.c | 149 +++++++
>  .../ethernet/microchip/lan966x/lan966x_regs.h | 132 +++++++
>  7 files changed, 718 insertions(+)
>  create mode 100644 drivers/net/ethernet/microchip/lan966x/lan966x_dcb.c
>=20
> --=20
> 2.38.0
>

Hi Horatiu,

LGTM. For the entire series:

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>=