Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74531faa-a583-03ad-b8e2-83799ecbfa6c@amlogic.com>
Date:   Mon, 15 May 2023 18:12:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH V8 1/4] dt-bindings: clock: document Amlogic S4 SoC PLL
 clock controller
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     kelvin.zhang@amlogic.com, qi.duan@amlogic.com
References: <20230515031557.31143-1-yu.tu@amlogic.com>
 <20230515031557.31143-2-yu.tu@amlogic.com>
 <590560c9-4da6-bbd4-6aac-de57ab5403ba@linaro.org>
 <8c6ad0a9-7820-c7a2-bd3b-1eee87d96728@amlogic.com>
 <33f5ff59-db7b-7576-64cb-972c0dfb0f7b@amlogic.com>
 <4a04ef11-d87d-4464-a907-badc920d595d@linaro.org>
From:   Yu Tu <yu.tu@amlogic.com>
In-Reply-To: <4a04ef11-d87d-4464-a907-badc920d595d@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXNTa0dEemVpeUtDeWhyMFpsai80bjlQdkxFOCszZmxUaXZEVHVReVMxR21j?=
 =?utf-8?B?L1NxVVd3dzBoNWZuQkUyOTRWd3RKbXE2d2RzSW9zMTZOZE5seWpTVldxQjdh?=
 =?utf-8?B?dm9vNWV6Z25PWEtob2QvbWt6WEtSb21TQkt1c2h1YjBRWHJkYnU1Q3ZaSDJU?=
 =?utf-8?B?NjJyV3pHWWcwNXNnQWYzNmJlN2VxVDNHaWFab08rS3dNeWo0RlJFWnJJdW9I?=
 =?utf-8?B?bDNrNjlzaTB6UDdZakxNdWE3MkZnc2F5dW5XV3NLT2pNbjFWYm1CYkcvV2dh?=
 =?utf-8?B?L3l4dm1wd2JqdnYyNi9iSVFZRjdaczhvRzh4Zm4vU1QzTVFtVC94YllrQzhD?=
 =?utf-8?B?aWRZcHRiUmltSDFvMDQwRDZCNDB6bUFsKy9abUc0SXNEd0gwZkRYL1Mzbkxx?=
 =?utf-8?B?eTl3THdMTmtvVkdyMDVFODJzbWFmRnFQdzhHU2pHbUcyUjE3M0JOdHVKTHZS?=
 =?utf-8?B?cEIySVNmWDF4YXhVdHlaTXBWUlRLZEg3ZWQ1Z0d6TTQrUmtTa2dOM2J2Qkxv?=
 =?utf-8?B?YmgrMm5YU1pNRHNiOHltR3hSU1BTdUE5RWNndEduY1dYdXNUcGFJTmVyanNV?=
 =?utf-8?B?c1NWcERtU2R3YSt4YXllWFYxbEo3Nk1idFovQ0cvSjFYaDlhWmNiVmFFUzh5?=
 =?utf-8?B?QXpTUFQ5b1ZZa2czeWJ6Y2pNcCtHaFdCR2Nyc0tlNlE2bVJmUG9ReVh0WlR6?=
 =?utf-8?B?ZTRaTENVd2xjRlhtWCtGYmJXSG44Z1c5TS8vNTA0RnpNWW5hOHI3a3dOeXkw?=
 =?utf-8?B?YThpUFErK0gzT0JFbXRNaWlqSkx3K0VWaEh0OWFsd01GeDl1MVVoWmQ2dzJM?=
 =?utf-8?B?WWVudWVNVnoyNERjM1FSZzNUVnZSSXUxdTd5MGVKbmx0RkZqTy9aMHlIRlhj?=
 =?utf-8?B?czFic3ZpcWx2K1dpWjVLT2JSMHRVNFVQakMwNitxYld2ajlWOGhkZCt6bzJI?=
 =?utf-8?B?cmEvZ01QZ2JWZkFjTHp2ZWZxUU1vZzEyanpSY1A0Uy8rZ0d2QjRadlc3a3dS?=
 =?utf-8?B?YldKakJkZWJHTHZWMzRVQytISU9rNDdUYlhBZnVieWVTK3EyeTA5TDNEdXJK?=
 =?utf-8?B?TERkR3gyNjM5U1dONTJFSnJVdndvRmFpVXprdUJHVkplNGJ2aDRwaXRJemFu?=
 =?utf-8?B?cHFYT2tTaVM1Y2RRWldmMTNJT2ZCS3BTM2ZiTDJISXNCSXpkTWpBaEg3NXEz?=
 =?utf-8?B?N2QwbVJVQ2tiR0tNZkZRdXd1RVNESkllVGNKUDVrTmgxRmh6Z1dYZmRpWUVH?=
 =?utf-8?B?cHYxbVhWOFFDRHRIRnZoci9IdTNkRnNyWGVCbmJPd0JmM0xkR3p5NGF6ak5L?=
 =?utf-8?B?RHI0aWxkYUdyYllrcThBTFZOeHpDelpkRlRvT3hSdHJPOExGc0E0RGxGbzdS?=
 =?utf-8?B?TEdCM1RGbk9lbTJvQ0szWWVMVkFsenJnWnB5WCtUZjRtMDNpV1hOVm9nTHdw?=
 =?utf-8?B?YStLKy9oeE5UeTZITjhudDNESU1HR25MZnVFT3BRSzlBU1dNNEVuYkZvYmlX?=
 =?utf-8?B?bFdwZ3IwSVN3eEh2S21BeVlsTHZvb0YvQjI3ZHBpRkl5TlNocExMc1hMRTFR?=
 =?utf-8?B?NTJBeVcyd0pNWlJXQlduMmJWcnBPRjZEMld6OEZablhpQWxraElJK1M1Um1J?=
 =?utf-8?B?dUtwZG96WnB5TjV4bzVtTVhsU3RzMmNBSjBkaVdZdUtwVjY1YU02SWRXQjlz?=
 =?utf-8?B?cmV0RHdjdG5xNnVFZUs3dGFya2VzdktXVUs0UjFKMEJaYjRQcjlDL0JXWkRG?=
 =?utf-8?B?clRkNGF1NzFudWd2cHE0YlBHTEtsVXA1RFViNWFkbDl1UHZaVFNaU09TbzRU?=
 =?utf-8?B?QmNqbGc5bnBGb1U1OFNBbVpDR3VFbkMzOFZoWlhZc0tFNjRkenJOYjlSQlJU?=
 =?utf-8?B?MXdCMEYvZ3cwaVVsSko4QVNvTi9NV1ZSbkVJWTNSQkxBVkdYUU9jKy9OZWhP?=
 =?utf-8?B?OFZUSC96RlhwajBueCtuVUN1RURDeEZYeEN3MU91M2hzUzRVdE8vMGlkbWFX?=
 =?utf-8?B?dzU1QUFqTXZnR3lJOGVoYnhpRHJrQkdHRzZCbDdpVnBQc2l4U1J2a1A5K0Ra?=
 =?utf-8?B?d0lyRFhXbVNjc0JpbnUzbldaeUc1MkM4dXFPV05rRmhra096OTRWMWtLNWo2?=
 =?utf-8?Q?jP2gaGGocaK5uzWQV/3qN/rVI?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4e5ef8-812c-4b8b-d2a0-08db552d06ec
X-MS-Exchange-CrossTenant-AuthSource: SG2PR03MB6730.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 10:13:28.5522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xbm/e0INf4NEAXJCH/1vNZLiKO/Kvj2My2dRw78iliP2A5MFDNWHTJCy8S0WnupJB+nD88FWOw5dD/EJZc97BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR03MB5574
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/5/15 18:06, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 15/05/2023 09:57, Yu Tu wrote:
>>
>>
>> On 2023/5/15 15:35, Yu Tu wrote:
>>> Hi Krzysztof,
>>>       Thank you for your prompt reply.
>>>
>>> On 2023/5/15 14:32, Krzysztof Kozlowski wrote:
>>>> On 15/05/2023 05:15, Yu Tu wrote:
>>>>> Add the S4 PLL clock controller dt-bindings in the s4 SoC family.
>>>>>
>>>>> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
>>>>
>>>> This is a friendly reminder during the review process.
>>>>
>>>> It looks like you received a tag and forgot to add it.
>>>>
>>>> If you do not know the process, here is a short explanation:
>>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>>>> versions. However, there's no need to repost patches *only* to add the
>>>> tags. The upstream maintainer will do that for acks received on the
>>>> version they apply.
>>>>
>>>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>>>>
>>>> If a tag was not added on purpose, please state why and what changed.
>>>
>>> Yes. I don't know the process. So I need to add Reviewed-by: Rob Herring
>>> <robh@kernel.org>. And resend V8?
>>>
>>
>> I would like to ask you again by the way. I'm not sure if I can just add
>> the TAG. Because I actually changed the V8.
> 
> Your changelog in cover letter does not describe it. It only mentions
> vaguely "change patch series". Describe exactly what changed.

Okay. I will correct and resend this patch.

> 
> Best regards,
> Krzysztof
>