Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1296c4d691bba057291246f067c191ef8a88531c.1680667933.git.fthain@linux-m68k.org>
 <CAMuHMdXLsnfQ4XhJiuE54BjGaCMAxvzOR+GGB9iFD8pYXprfxQ@mail.gmail.com>
In-Reply-To: <CAMuHMdXLsnfQ4XhJiuE54BjGaCMAxvzOR+GGB9iFD8pYXprfxQ@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 15 May 2023 12:11:36 +0200
Message-ID: <CAMuHMdWSYDUOy0CSrRcv5-R8rg6EdXMaG5SHiTcYuaNa7K5e1Q@mail.gmail.com>
Subject: Re: [PATCH v4] nubus: Don't list slot resources by default
To:     Finn Thain <fthain@linux-m68k.org>
Cc:     Brad Boyer <flar@allandria.com>, linux-m68k@lists.linux-m68k.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Finn,

On Mon, May 15, 2023 at 11:44 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Wed, Apr 5, 2023 at 6:19 AM Finn Thain <fthain@linux-m68k.org> wrote:
> > Some Nubus card ROMs contain many slot resources. A single Radius video
> > card produced well over a thousand entries under /proc/bus/nubus/.
> > Populating /proc/bus/nubus/ on a slow machine with several such cards
> > installed takes long enough that the user may think that the system is
> > wedged. All those procfs entries also consume significant RAM though
> > they are not normally needed (except by developers).
> > Omit these resources from /proc/bus/nubus/ by default and add a kernel
> > parameter to enable them when needed.
> > On the test machine, this saved 300 kB and 10 seconds.
> >
> > Cc: Brad Boyer <flar@allandria.com>
> > Tested-by: Stan Johnson <userm57@yahoo.com>
> > Signed-off-by: Finn Thain <fthain@linux-m68k.org>
> > ---
> > Changed since v3:
> >  - Better commentary.
> > Changed since v2:
> >  - Added commentary.
> >  - Moved declaration to nubus.h.
> > Changed since v1:
> >  - Expanded to cover all slot resources in procfs.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> i.e. will queue in the m68k for-v6.5 branch.

Upon second look, "populate_procfs" is too generic for a global
variable.  Please add a "nubus_"-prefix, and use module_param_named()
instead.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds