Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1925180rwd; Mon, 15 May 2023 05:10:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ywkOCzxmIKlfp6BpmRbNEnboMs0r551HiggM6Zt/WhdN0aEy5kvUDGcCaMKSRt1wg0A6e X-Received: by 2002:a05:6870:36c2:b0:192:d055:c3d with SMTP id u2-20020a05687036c200b00192d0550c3dmr14640863oak.11.1684152611551; Mon, 15 May 2023 05:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684152611; cv=none; d=google.com; s=arc-20160816; b=fniwqWBMETrhD/7G4k9ZwWvi/DV9lK9Do5PWxkUlePzFSEDpPPzd8DhRweSLBx9xm9 oVkn2XSCBpUiNP/pqWQ0qvoy8mY1V0UtEZQj5TgYLzP6OXenGKjFEIk7jdfRjs7uBQCJ bnyC9k50ZM8G0fgdj65cDXR5Q1ViYo0HC6iA9yxMyITAzzFFBUiWLz1L+NQhJgZF1WxO 9s40bTXEnuLo++UQtwlXHhJIb32YPn0I5iTNxi1xd2tJv6VYAa4slheLO5KyvQb9KmYu YK8SHtsM+2evhZY2380ToS/u/2oz/m3HgHv+BDHEoPdQNekCbA+RiOLgJTDE41wHQMSd nDWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PuPfI1ULNn6nKdgBOgNMBtEbGf2urZOQinv9le4S0tg=; b=hSf0OOeM8SpxSt/HodbYqpmIlxB23l1nmarITj+9u9mH+qDo+ZVpGbvHL56lU3sd2q LMzQ5Q5giKZ+bbPmOG7YKEy22EJCVvbBoWF0/OlYlHOz+JXhMaPgeIfUBbD3E2rwHHU+ SF31OxqVYpjp5Jlc0mX4xB28zhnzIDm+5yNE3dgmnCr4sSKtSeOTnelFwHAQmpeOIBFj ggMwwtone6eFmi1T5+7Qqp/rfmotqVWoMlG2utenjvu+suNGKMhe9T2BPQj6mNxFk1hK y/IL0LNzsae0IkGUxWQiRiNps+ZYF0B2N2UbWWR0E1eQRaCGDFkZnO8oVoqnBFji+5tB ioGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=IkBBAEfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u26-20020a056871009a00b00199c258d416si1966796oaa.309.2023.05.15.05.09.56; Mon, 15 May 2023 05:10:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=IkBBAEfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240173AbjEOL41 (ORCPT + 99 others); Mon, 15 May 2023 07:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239894AbjEOLzb (ORCPT ); Mon, 15 May 2023 07:55:31 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C123C30E0; Mon, 15 May 2023 04:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PuPfI1ULNn6nKdgBOgNMBtEbGf2urZOQinv9le4S0tg=; b=IkBBAEfMBi3BnwkUH9a+d6WFrp IAP6BVB6s9Sl8NqTDNcoPch40oFg+Og/x7m6XkOUE72+xSzl5ZlI98459I4E/du347IDxCTnReoyr 2oONv2hE1I3etOOnCSY2vH9ouRwvUXHVKKVE+lKyCxDJ7gkQCHtKzqlDKNWUmE1Pr4uvdovJE5O8U aFKw5WRtbNE+EPp9q4TeTUEoP0voDGcBEZNG9WfWZqArILRyyFm3+03au5ftDUPZXH3r+YWAxP/6I F2qrkp8eHjEgXrfMbulzU3v+q/5Tn/XUKFTFaEw9mWhCAMnwjbBu1x/P/5q4Wok0/BQJDjF1eLR8M Iv7zwhgA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pyWis-0022I3-1r; Mon, 15 May 2023 11:50:38 +0000 Date: Mon, 15 May 2023 04:50:38 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , David Hildenbrand , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Mauro Carvalho Chehab , "Michael S . Tsirkin" , Jason Wang , Jens Axboe , Pavel Begunkov , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, io-uring@vger.kernel.org, bpf@vger.kernel.org, John Hubbard Subject: Re: [PATCH v5 5/6] mm/gup: remove vmas parameter from pin_user_pages() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2023 at 10:26:58PM +0100, Lorenzo Stoakes wrote: > We are now in a position where no caller of pin_user_pages() requires the > vmas parameter at all, so eliminate this parameter from the function and > all callers. > > This clears the way to removing the vmas parameter from GUP altogether. > > Acked-by: David Hildenbrand > Acked-by: Dennis Dalessandro (for qib) > Signed-off-by: Lorenzo Stoakes Looks good: Reviewed-by: Christoph Hellwig