Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-415-gf2b17fe6c3-fm-20230503.001-gf2b17fe6
Mime-Version: 1.0
Message-Id: <3696666f-9b48-405c-a715-8adf927fd86e@app.fastmail.com>
In-Reply-To: <a9e9a1a7-346a-475e-961c-ec8568613b45@kili.mountain>
References: <CA+G9fYuoB8Ug8PcTU-YGmemL7_eeEksXFihvxWF6OikD7sK7pA@mail.gmail.com>
 <a9e9a1a7-346a-475e-961c-ec8568613b45@kili.mountain>
Date:   Mon, 15 May 2023 14:13:28 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Dan Carpenter" <dan.carpenter@linaro.org>,
        "Naresh Kamboju" <naresh.kamboju@linaro.org>,
        =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= <ricardo.canuelo@collabora.com>
Cc:     "open list" <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, lkft-triage@lists.linaro.org,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Linus Torvalds" <torvalds@linux-foundation.org>,
        "Ard Biesheuvel" <ardb@kernel.org>, shuah <shuah@kernel.org>,
        "Anders Roxell" <anders.roxell@linaro.org>
Subject: Re: selftests: mincore: mincore_selftest fails only on qemu-armv7
Content-Type: text/plain
Precedence: bulk

On Mon, May 15, 2023, at 13:51, Dan Carpenter wrote:
> On Mon, May 15, 2023 at 03:29:02PM +0530, Naresh Kamboju wrote:
>> The selftests: mincore: mincore_selftest fails only on qemu-armv7 running
>
> tools/testing/selftests/mincore/mincore_selftest.c
>    139  TEST(check_huge_pages)
>    140  {
>    141          unsigned char vec[1];
>    142          char *addr;
>    143          int retval;
>    144          int page_size;
>    145  
>    146          page_size = sysconf(_SC_PAGESIZE);
>    147  
>    148          errno = 0;
>    149          addr = mmap(NULL, page_size, PROT_READ | PROT_WRITE,
>    150                  MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB,
>    151                  -1, 0);
>    152          if (addr == MAP_FAILED) {
>    153                  if (errno == ENOMEM)
>
> On Armv7 is a 32bit machine so HUGETLB isn't enabled and the errno can
> be -EINVAL.  It's has returned this for 10 years.

I expected it to be enabled on 32-bit as well, but I see that
on normal ARMv7 without CONFIG_ARM_LPAE, it is indeed
always turned off, and the asm/pgtable-2level.h does not
define a way to use sections or supersections in user space:

arch/arm/Kconfig:       select ARCH_SUPPORTS_HUGETLBFS if ARM_LPAE

      Arnd