Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 09:12:49 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     "Kirill A . Shutemov" <kirill@shutemov.name>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Matthew Wilcox <willy@infradead.org>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Leon Romanovsky <leon@kernel.org>,
        Christian Benvenuti <benve@cisco.com>,
        Nelson Escobar <neescoba@cisco.com>,
        Bernard Metzler <bmt@zurich.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bjorn Topel <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Christian Brauner <brauner@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        Oleg Nesterov <oleg@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>, Jan Kara <jack@suse.cz>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Mika Penttila <mpenttil@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        Dave Chinner <david@fromorbit.com>,
        Theodore Ts'o <tytso@mit.edu>, Peter Xu <peterx@redhat.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v9 0/3] mm/gup: disallow GUP writing to file-backed
 mappings by default
Message-ID: <ZGIhwZl2FbLodLrc@nvidia.com>
References: <cover.1683235180.git.lstoakes@gmail.com>
 <20230515110315.uqifqgqkzcrrrubv@box.shutemov.name>
 <7f6dbe36-88f2-468e-83c1-c97e666d8317@lucifer.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7f6dbe36-88f2-468e-83c1-c97e666d8317@lucifer.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G+qL5vFMYT6D+nnSgzfuolJgmHEgH4dPR3MTkIhI0WJ3eg35wslLv8EcGLb0?=
 =?us-ascii?Q?XPMpDTl5n+gVUkSBlCATUXkeEkD2tulwBCzDgo/c9CbIq9c/GuEnx7IB4Jgy?=
 =?us-ascii?Q?6yCBn3kJ/QuTVHb/+v23Ikknuh2l+Tjyj2T5HwufyqWM9R9VrgyeSOU9ncne?=
 =?us-ascii?Q?W53kCiR1qM+6BI7ehhrly4/cHMzfiasKYkkb1SJrOxNdNpAkuzSS/j/aa8VX?=
 =?us-ascii?Q?qsnZ3ZEktt6StW1OnQVKxB2U0MO0u/x7LoqQ0Q+0+ztFjHIMqqp/2kQqk078?=
 =?us-ascii?Q?4c5t7Xs8O1jcckkUhxt7fDrD4QHbXzz8k+HCnwnCe8LmObVDQAGrxJgShfQx?=
 =?us-ascii?Q?rhcQxMgObqXWgdt70OWPfj6MfpJUcqNYHR/FctMkNaIiPQ+0iVRsFMLBS3JZ?=
 =?us-ascii?Q?kGKQMAORHxn2i7qkk07xzDGmyhPKfaDGQAAfBbQSUV47IWBS3xbY6Jq0LsMb?=
 =?us-ascii?Q?wKAIKW7KBF8+n0qy+pXsGzl6Q6CrDmbzUS6ujjazVLnnp+puzGqCNvJKi5rW?=
 =?us-ascii?Q?6vij8M6UnhFHgtnIdwTysz+TsrQ8i4Ab9jsbbn1NSBSxR8uO3YWwENeYmZ+3?=
 =?us-ascii?Q?Sj2AheSUFe1hxa6L8uKBluXxwDDFs+CyywNnqwh/wqmgaTdf1DMtO3BBSe32?=
 =?us-ascii?Q?PP/uR2EbfMNIUSre12EwGxlBhYO6zdXIew5kRBKNZBH+hroIIrP93opOLQxs?=
 =?us-ascii?Q?Q6c2cT6mh+W0W+Nad6geqFCejguKSAwh17upFnh7KZj3+J3bHSvihjx6c2jh?=
 =?us-ascii?Q?Iu6VaCPqRGUsQzPII1QEuTNBF79CqgyAdhOGiYP6PZpGWoWYPBHwEufU9gsP?=
 =?us-ascii?Q?c9jSoFiIT85yWl4dHFzwBTDiVQn+YFsXHubFn5aLiUsHq6Tzh+0S/awPF+2E?=
 =?us-ascii?Q?sZv9nGYdPhx68TvqjSlBo3T0ayGbeLVO7IcY8/T6ACoFlvHFp3XzTgwRMTEO?=
 =?us-ascii?Q?36oCA/Ur9l8Mvc52suSFnspxgjtC/wdRwkaqyQYSiJjiQV0pfOAK6A2wRfHP?=
 =?us-ascii?Q?QWu16Ck3nylaL7g/A9tmXyu49JLuiw0nRfzlSVbeM0r/FcfG4/HDvXepeCs4?=
 =?us-ascii?Q?EuQ6xFH+hdrReNqigeBnZJTOvDNs/DEqkCIYnfWDanuae3G787aFrkTTcato?=
 =?us-ascii?Q?jATfBK96zi52PnqHPUT0GVuB1l9y7X5fjH4VoSHljLCe0GO4dxKRtyM/sctv?=
 =?us-ascii?Q?2Sim4aV4DwoX+hMoQroedjQtzpvAoYyPuYwBimAFo8YGgoxq1Bfor2qpYeGm?=
 =?us-ascii?Q?k2L3SrkulKiFqSRPuUeqfbc3YELxnKRCcc29Mo6ilocjjEsiAZX0F9rCqGkZ?=
 =?us-ascii?Q?bKJaY33kmJQCcQ5zsY8bQAgbfGBF61NlDpaGUjQhV53tYJpN0axpZhlDnkTK?=
 =?us-ascii?Q?hLfJgkPqzyzZ2kh5bMRpRHv1lJM88A8CrVjld9HYuq/xCZ//OcWQeAnGiNdL?=
 =?us-ascii?Q?g9AqsFxbEkFIoECXTR3j8GsWlWbT4V6EsS1B5nj3uqJvdvzHi09DV4PTbfIU?=
 =?us-ascii?Q?fdwpnItvvGh+ETUOJk9ljuhbyxc4ELMLBBnqvZVStZ0iEpTDmZ1WeiJe6Vz2?=
 =?us-ascii?Q?HkXq9o4Id3e9FyX79yFP2boAC4P5tgeLP9a4BWz8?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e517f40b-794c-47a4-952e-08db553db3b3
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 12:12:50.0813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8quOnnNBOxdw4tqchzoE4R9DYph0firWZ099EtdbNRWYDxYS5r2wSK5qv1YCcYK0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4321
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 15, 2023 at 12:16:21PM +0100, Lorenzo Stoakes wrote:
> > One thing that came to mind is KVM with "qemu -object memory-backend-file,share=on..."
> > It is mostly used for pmem emulation.
> >
> > Do we have plan B?
> 
> Yes, we can make it opt-in or opt-out via a FOLL_FLAG. This would be easy
> to implement in the event of any issues arising.

I'm becoming less keen on the idea of a per-subsystem opt out. I think
we should make a kernel wide opt out. I like the idea of using lower
lockdown levels. Lots of things become unavaiable in the uAPI when the
lockdown level increases already.

> Jason will have some thoughts on this I'm sure. I guess the key question
> here is - is it actually feasible for this to work at all? Once we
> establish that, the rest are details :)

Surely it is, but like Ted said, the FS folks are not interested and
they are at least half the solution..

The FS also has to actively not write out the page while it cannot be
write protected unless it copies the data to a stable page. The block
stack needs the source data to be stable to do checksum/parity/etc
stuff. It is a complicated subject.

Jason