Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 15:23:56 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: omap: Move uart_write() inside PM section
Message-ID: <20230515122356.GI14287@atomide.com>
References: <20230515065706.1723477-1-geert@linux-m68k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230515065706.1723477-1-geert@linux-m68k.org>
Precedence: bulk

* Geert Uytterhoeven <geert@linux-m68k.org> [230515 06:57]:
> If CONFIG_PM is not set (e.g. m68k/allmodconfig):
> 
>     drivers/tty/serial/8250/8250_omap.c:169:13: error: ‘uart_write’ defined but not used [-Werror=unused-function]
>       169 | static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val)
> 	  |             ^~~~~~~~~~
> 
> Fix tis by moving uart_write() inside the existing section protected
> by #ifdef CONFIG_PM.

OK thanks for fixing it:

Reviewed-by: Tony Lindgren <tony@atomide.com>