Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aab36e10-ce86-9374-ea67-be6d1a0f4adf@collabora.com>
Date:   Mon, 15 May 2023 14:32:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: selftests: mincore: mincore_selftest fails only on qemu-armv7
To:     Dan Carpenter <dan.carpenter@linaro.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>
Cc:     open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, lkft-triage@lists.linaro.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Ard Biesheuvel <ardb@kernel.org>,
        Shuah Khan <shuah@kernel.org>,
        Anders Roxell <anders.roxell@linaro.org>
References: <CA+G9fYuoB8Ug8PcTU-YGmemL7_eeEksXFihvxWF6OikD7sK7pA@mail.gmail.com>
 <a9e9a1a7-346a-475e-961c-ec8568613b45@kili.mountain>
Content-Language: en-US
From:   =?UTF-8?Q?Ricardo_Ca=c3=b1uelo?= <ricardo.canuelo@collabora.com>
In-Reply-To: <a9e9a1a7-346a-475e-961c-ec8568613b45@kili.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi all,

On 15/5/23 13:51, Dan Carpenter wrote:
> The test is wrong.  It doesn't accept -EINVAL as a valid failure.
> 
> tools/testing/selftests/mincore/mincore_selftest.c
>     139  TEST(check_huge_pages)
>     140  {
>     141          unsigned char vec[1];
>     142          char *addr;
>     143          int retval;
>     144          int page_size;
>     145
>     146          page_size = sysconf(_SC_PAGESIZE);
>     147
>     148          errno = 0;
>     149          addr = mmap(NULL, page_size, PROT_READ | PROT_WRITE,
>     150                  MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB,
>     151                  -1, 0);
>     152          if (addr == MAP_FAILED) {
>     153                  if (errno == ENOMEM)
> 
> On Armv7 is a 32bit machine so HUGETLB isn't enabled and the errno can
> be -EINVAL.  It's has returned this for 10 years.
> 
>     154                          SKIP(return, "No huge pages available.");
>     155                  else
>     156                          TH_LOG("mmap error: %s", strerror(errno));
>     157          }
>     158          retval = mincore(addr, page_size, vec);
>     159          ASSERT_EQ(0, retval);
> 
> mm/mmap.c
>    1405                  }
>    1406          } else if (flags & MAP_HUGETLB) {
>    1407                  struct hstate *hs;
>    1408
>    1409                  hs = hstate_sizelog((flags >> MAP_HUGE_SHIFT) & MAP_HUGE_MASK);
>    1410                  if (!hs)
>    1411                          return -EINVAL;
>                                  ^^^^^^^^^^^^^^^
> hstate_sizelog() return NULL when CONFIG_HUGETLB_PAGE is disabled.
> 
>    1412
>    1413                  len = ALIGN(len, huge_page_size(hs));
> 
> regards,
> dan carpenter
> 

Thanks for the tip, Dan. I'll send a patch for it asap.

Cheers,
Ricardo