Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 16:35:53 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Cc:     broonie@kernel.org, blarson@amd.com, git@amd.com,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        amitrkcian2002@gmail.com
Subject: Re: [PATCH] spi: dw: Replace spi->chip_select references with
 function calls
Message-ID: <20230515133553.46mownenmclcauec@mobilestation>
References: <20230515130343.63770-1-amit.kumar-mahapatra@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230515130343.63770-1-amit.kumar-mahapatra@amd.com>
Precedence: bulk

On Mon, May 15, 2023 at 06:33:43PM +0530, Amit Kumar Mahapatra wrote:
> New set/get APIs for accessing spi->chip_select were introduced by
> 'commit 9e264f3f85a5 ("spi: Replace all spi->chip_select and spi->cs_gpiod
> references with function call")', but the 'commit 2c8606040a80 ("spi: dw:
> Add support for AMD Pensando Elba SoC")' uses the old interface by directly
> accessing spi->chip_select. So, replace all spi->chip_select references
> in the driver with new get/set APIs.

Indeed. I've absolutely missed that part. Thanks for the patch.

Acked-by: Serge Semin <fancer.lancer@gmail.com>

-Serge(y)

> 
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
> ---
> BRANCH: for-next
> ---
>  drivers/spi/spi-dw-mmio.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
> index 5e6faa98aa85..5f2aee69c1c1 100644
> --- a/drivers/spi/spi-dw-mmio.c
> +++ b/drivers/spi/spi-dw-mmio.c
> @@ -264,17 +264,17 @@ static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable)
>  	struct regmap *syscon = dwsmmio->priv;
>  	u8 cs;
>  
> -	cs = spi->chip_select;
> +	cs = spi_get_chipselect(spi, 0);
>  	if (cs < 2)
> -		dw_spi_elba_override_cs(syscon, spi->chip_select, enable);
> +		dw_spi_elba_override_cs(syscon, spi_get_chipselect(spi, 0), enable);
>  
>  	/*
>  	 * The DW SPI controller needs a native CS bit selected to start
>  	 * the serial engine.
>  	 */
> -	spi->chip_select = 0;
> +	spi_set_chipselect(spi, 0, 0);
>  	dw_spi_set_cs(spi, enable);
> -	spi->chip_select = cs;
> +	spi_get_chipselect(spi, cs);
>  }
>  
>  static int dw_spi_elba_init(struct platform_device *pdev,
> -- 
> 2.17.1
>