Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230515013428.38798-1-suhui@nfschina.com> <ebe9d98c-148d-4694-8f97-96bacd0b9f7d@kili.mountain>
In-Reply-To: <ebe9d98c-148d-4694-8f97-96bacd0b9f7d@kili.mountain>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 15 May 2023 10:11:39 -0400
Message-ID: <CADnq5_Nei-XHsD8DQkpUGZwZAik5X-S1R3znOJGD1X2jAxD6_g@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: remove unnecessary (void*) conversions
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     Su Hui <suhui@nfschina.com>, Xinhui.Pan@amd.com,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        Alex Deucher <alexander.deucher@amd.com>,
        christian.koenig@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 15, 2023 at 3:17=E2=80=AFAM Dan Carpenter <dan.carpenter@linaro=
.org> wrote:
>
> On Mon, May 15, 2023 at 09:34:28AM +0800, Su Hui wrote:
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/=
drm/amd/amdgpu/amdgpu_debugfs.c
> > index f60753f97ac5..c837e0bf2cfc 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > @@ -1470,7 +1470,7 @@ int amdgpu_debugfs_regs_init(struct amdgpu_device=
 *adev)
> >
> >  static int amdgpu_debugfs_test_ib_show(struct seq_file *m, void *unuse=
d)
> >  {
> > -     struct amdgpu_device *adev =3D (struct amdgpu_device *)m->private=
;
> > +     struct amdgpu_device *adev =3D m->private;
> >       struct drm_device *dev =3D adev_to_drm(adev);
> >       int r =3D 0, i;
> >
>
> This declaration block was originally written in reverse Christmas tree
> order:
>
>         long long long variable name;
>         medium length name;
>         short name;
>
> So you probably want to change the order now that the lengths have
> changed.  Same in the other places as well.

I don't think it's possible due to the variable dependencies unless
you separate the declarations and assignments which doesn't seem like
a net win to me.

Alex

>
> regards,
> dan carpenter
>