Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 09:32:50 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Nitin Yadav <n-yadav@ti.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in
 cbass_main
Message-ID: <20230515143250.jxwwgse24lrcqouc@grunge>
References: <20230510123216.3440019-1-n-yadav@ti.com>
 <20230510123216.3440019-3-n-yadav@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230510123216.3440019-3-n-yadav@ti.com>
Precedence: bulk

On 18:02-20230510, Nitin Yadav wrote:
> Add sa3_secproxy node in k3-am62-main.dtsi to keep device tree
> nodes in sync with u-boot nodes.
> 
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..7c2af5b0e022 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -42,6 +42,15 @@ gic_its: msi-controller@1820000 {
>  		};
>  	};
>  
> +	sa3_secproxy: secproxy@44880000 {
> +		compatible = "ti,am654-secure-proxy";
> +		#mbox-cells = <1>;
> +		reg-names = "rt", "scfg", "target_data";
> +		reg = <0x00 0x44880000 0x00 0x20000>,
> +		      <0x0 0x44860000 0x0 0x20000>,
> +		      <0x0 0x43600000 0x0 0x10000>;
be consistent with 0x00 instead of 0x0

You want this marked reserved and documented since it is to be used only by HSM
processors and NOT general processors.

> +	};
> +
>  	main_conf: syscon@100000 {
>  		compatible = "syscon", "simple-mfd";
>  		reg = <0x00 0x00100000 0x00 0x20000>;
> -- 
> 2.25.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D