Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 16:32:22 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Arnd Bergmann <arnd@kernel.org>, Linus Walleij <linusw@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 36/43] pwm: ep93xx: drop legacy pinctrl
Message-ID: <20230515143222.dlhxcze5254773r4@pengutronix.de>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
 <20230424123522.18302-37-nikita.shubin@maquefel.me>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uehgxcqdeovzrqox"
Content-Disposition: inline
In-Reply-To: <20230424123522.18302-37-nikita.shubin@maquefel.me>
Precedence: bulk


--uehgxcqdeovzrqox
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 24, 2023 at 03:34:52PM +0300, Nikita Shubin wrote:
> Drop legacy gpio request/free since we are using
> pinctrl for this now.
>=20
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
>  drivers/pwm/pwm-ep93xx.c | 16 ----------------
>  1 file changed, 16 deletions(-)
>=20
> diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
> index 8bfe6cfbb3db..657adb011aeb 100644
> --- a/drivers/pwm/pwm-ep93xx.c
> +++ b/drivers/pwm/pwm-ep93xx.c
> @@ -45,20 +45,6 @@ static inline struct ep93xx_pwm *to_ep93xx_pwm(struct =
pwm_chip *chip)
>  	return container_of(chip, struct ep93xx_pwm, chip);
>  }
> =20
> -static int ep93xx_pwm_request(struct pwm_chip *chip, struct pwm_device *=
pwm)
> -{
> -	struct platform_device *pdev =3D to_platform_device(chip->dev);
> -
> -	return ep93xx_pwm_acquire_gpio(pdev);

I didn't get the whole series and didn't spot a relevant followup change
on lore.k.o, so: I assume ep93xx_pwm_acquire_gpio() and
ep93xx_pwm_release_gpio() will be unused in the end? Do you drop them?

I assume this series target to be taken via arm-soc (once the review
feedback is positive)?

I wonder if this change breaks non-dt machine support?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--uehgxcqdeovzrqox
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmRiQnYACgkQj4D7WH0S
/k6W6QgAuF9cx7Bag66ydz8UBm679CwAYAJNaGeY1zDYaBem2ijQT1uFfdS+cCaG
uuyO0fBB+ZYAUY5ffcsAvCPs0wKLuLMD25isTpo5CCP+r4RDn5RwIMfsecEjH32X
mjReNtGgvNc8P2P5xD4h9MwwZ5JvnLxCGWCEJuql+PcBelSQfbZ9akYexZymU7PF
DmipR0eaiS3qA+7PdFzpryfR5Gmm0VKRelb3FQmPTKOs5ZTW+9nppMgWyf5PghRV
wwkyYSx/9xJbKzzfQHpJWZGYnVNKpqjX4k9uAT/YXMG6tjLIyqJsYO1qhSmIxkiK
bE0VN2Vds9v/Els4kreXxN1swq+D3g==
=7bKc
-----END PGP SIGNATURE-----

--uehgxcqdeovzrqox--