Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 17:56:21 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     wuych <yunchuan@nfschina.com>
Cc:     dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: liquidio: lio_core: Remove unnecessary
 (void*) conversions
Message-ID: <2c8a5e3f-965e-422a-b347-741bcc7d33ce@kili.mountain>
References: <20230515084906.61491-1-yunchuan@nfschina.com>
 <61522ef5-7c7a-4bee-bcf6-6905a3290e76@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <61522ef5-7c7a-4bee-bcf6-6905a3290e76@kili.mountain>
Precedence: bulk

On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote:
> On Mon, May 15, 2023 at 04:49:06PM +0800, wuych wrote:
> > Pointer variables of void * type do not require type cast.
> > 
> > Signed-off-by: wuych <yunchuan@nfschina.com>
> > ---
> >  drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > index 882b2be06ea0..10d9dab26c92 100644
> > --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > @@ -904,8 +904,7 @@ static
> >  int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret)
> >  {
> >  	struct octeon_device *oct = droq->oct_dev;
> > -	struct octeon_device_priv *oct_priv =
> > -	    (struct octeon_device_priv *)oct->priv;
> > +	struct octeon_device_priv *oct_priv = oct->priv;
> >  
> 
> Networking code needs to be in Reverse Christmas Tree order.  Longest
> lines first.  This code wasn't really in Reverse Christmas Tree order
> to begine with but now it's more obvious.

Oh, duh.  This obviously can't be reversed because it depends on the
first declaration.  Sorry for the noise.

regards,
dan carpenter