Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Li <Frank.Li@nxp.com>
To:     manivannan.sadhasivam@linaro.org,
        Minghuan Lian <minghuan.Lian@nxp.com>,
        Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linuxppc-dev@lists.ozlabs.org (open list:PCI DRIVER FOR FREESCALE
        LAYERSCAPE),
        linux-pci@vger.kernel.org (open list:PCI DRIVER FOR FREESCALE
        LAYERSCAPE),
        linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR
        FREESCALE LAYERSCAPE), linux-kernel@vger.kernel.org (open list)
Cc:     imx@lists.linux.dev
Subject: [PATCH v4 1/1] PCI: layerscape: Add the endpoint linkup notifier support
Date:   Mon, 15 May 2023 11:10:49 -0400
Message-Id: <20230515151049.2797105-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EYmgEHoriVAsjNeQPrm8f3F1Y8WyDHnOBXb8Bc4s8VFRggiYIKZmPVm2QjLw?=
 =?us-ascii?Q?Kv1U61HiW7n4+Q1wNox58SB4nYYd2aInDbJA9pbaPir9UAUtEEdazJ1foA6y?=
 =?us-ascii?Q?wbmMaWEXzTuv2ogzjIUEQbF+hZ4u1L/elPB6zX2E2yG5ljN5iG0QuTq1XamL?=
 =?us-ascii?Q?mpo+Fob1of4l2V0vW5qPHwkWX4MMCKSa4HVthrJ0JoP7xkC0v4m4wgzSsmWn?=
 =?us-ascii?Q?Fvz45imQPZh6T9Ba6+Q0uG+J2J8h0GTvp3r9k0gTnnDGGB4v2ReVC7deilYt?=
 =?us-ascii?Q?e1VeZqqRik3ElqCKGy4Srzf4X1Y3axdeZmg+N8DygewoJF+u9h8EPoHnKXQz?=
 =?us-ascii?Q?QKmB8L/OCRkT0PCJLbr7I44RYeW3xej9L35xTQXW1PLz8+TkNuhgT8RKQJRw?=
 =?us-ascii?Q?XEP9t6hUsgeFMwH+1eXVlFwyTGXI/5ntDHgPu5k3RIsGfyi9LOVxMgRLa9KI?=
 =?us-ascii?Q?auHSFuQCQOvzzBABq7SD4OVwQQD+z/bp09BZEBZgtYCC9MvVLWlHbbQxrDAV?=
 =?us-ascii?Q?sRQM3MLLuFgJrkVFs2FkuDdySwSDycDixKK8gXz+Rpvj/2FaWby5gUfdCb3d?=
 =?us-ascii?Q?vtWjiqYMK/70xXH86o1fwJmILKBYl/X5JPbSL3AYHecTjMXaTZu4lXnQdfOd?=
 =?us-ascii?Q?YBeIzW+iptPAzlm61/fkbCVhjC6eP+HaoToRtQX4OWKUAwXKebRAyJECe71J?=
 =?us-ascii?Q?CPgCDdEwiTj2YFfuFU/glGHBl2ikXjCHwG7qCBL11KMTXeAArzukrJQy6K4u?=
 =?us-ascii?Q?uVq9qlBTY9WStI264tjTAs3rvfOhJmQ8ySknWU2JRcO02RREUbbu+lMZIVFl?=
 =?us-ascii?Q?xYu7EoHf7CvzWxGIMrVNS3x91XOx+6CaPB4qdCVlgY9aMAYS4qf6Ak4erRVR?=
 =?us-ascii?Q?oXolWsc3OUv0g7leKd/JWBXsCutzc1sdGP8MR9gMxodwrS43edDXOzlN/pcZ?=
 =?us-ascii?Q?oHalw2tYUNhiQBnaxO/Kc8W4V1G0rZ8I0Yjfmr/+8A9fr+aUoB2hPKBlEij6?=
 =?us-ascii?Q?hO24ggPTW7/rqemdV9GoZWtAgq1MpTlTy53Z5+cp2TTeOS8/+THsEoVaxOsz?=
 =?us-ascii?Q?4pnbSVqGSjHvGHhRKnu/D4867d1lRFfONcHGOPbCD1j4h2yuK34AOduqVutC?=
 =?us-ascii?Q?3KfdOHEa3xW0Gq6rp0PbuOEquTIUT/gXyJgUgp6urm4C662T19QC7lKeClca?=
 =?us-ascii?Q?j8LErbZBPmGt0R1Cyc1AGW+EspmpWysUKLBMAkwrI13zdhb7I4E2+eHMr162?=
 =?us-ascii?Q?FOQCD9nOoFbrEo1C7sguUGLz5oWNRK8CLc4sFNtzZD2tB7cKjwXHQAkEo8lg?=
 =?us-ascii?Q?pwltBtwBGo0DpnL/DFdyofWBMcseHmVbMRS+TYAJm7k9Jv+FwVRtHFfDhl3l?=
 =?us-ascii?Q?qsDbXS9bqpqZ1keEqUfqRvmIZ/J8Hk2tTBApZoKhh71lhyatmhhcywFm3m7n?=
 =?us-ascii?Q?/rKF4wlH8bUWDkrOl0pXuse22mmIe6Te9ZEv0Dp+qtO77vpbn8DMXB9+znLF?=
 =?us-ascii?Q?4mp1egMmC/ny/iwtPO5XeST1HuiD1H5imXXWtgNxBB34wY2g7dxtAAhLIRTx?=
 =?us-ascii?Q?r5qSMbZPe8xjEiUuxGrHURZaBP18P0n92Sbk//qi?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99648f0f-8352-4188-c507-08db55569c02
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 15:11:07.7625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4pxIkmf/qD4x73w/eKg76gso1pJfcndod/59WoP2k3IAl4cXRv5EcemA1/JeJ2geCjosskn7ZN5iP751/qIA4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8872
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Layerscape has PME interrupt, which can be used as linkup notifier.
Set CFG_READY bit of PEX_PF0_CONFIG to enable accesses from root complex
when linkup detected.

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v3 to v4
 - swap irq and big_endian
Change from v2 to v3
 - align 80 column
 - clear irq firstly
 - dev_info to dev_dbg
 - remove double space
 - update commit message

Change from v1 to v2
- pme -> PME
- irq -> IRQ
- update dev_info message according to Bjorn's suggestion

 .../pci/controller/dwc/pci-layerscape-ep.c    | 102 +++++++++++++++++-
 1 file changed, 101 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index c640db60edc6..5398641b6b7e 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -18,6 +18,20 @@
 
 #include "pcie-designware.h"
 
+#define PEX_PF0_CONFIG			0xC0014
+#define PEX_PF0_CFG_READY		BIT(0)
+
+/* PEX PFa PCIE PME and message interrupt registers*/
+#define PEX_PF0_PME_MES_DR		0xC0020
+#define PEX_PF0_PME_MES_DR_LUD		BIT(7)
+#define PEX_PF0_PME_MES_DR_LDD		BIT(9)
+#define PEX_PF0_PME_MES_DR_HRD		BIT(10)
+
+#define PEX_PF0_PME_MES_IER		0xC0028
+#define PEX_PF0_PME_MES_IER_LUDIE	BIT(7)
+#define PEX_PF0_PME_MES_IER_LDDIE	BIT(9)
+#define PEX_PF0_PME_MES_IER_HRDIE	BIT(10)
+
 #define to_ls_pcie_ep(x)	dev_get_drvdata((x)->dev)
 
 struct ls_pcie_ep_drvdata {
@@ -30,8 +44,86 @@ struct ls_pcie_ep {
 	struct dw_pcie			*pci;
 	struct pci_epc_features		*ls_epc;
 	const struct ls_pcie_ep_drvdata *drvdata;
+	int				irq;
+	bool				big_endian;
 };
 
+static u32 ls_lut_readl(struct ls_pcie_ep *pcie, u32 offset)
+{
+	struct dw_pcie *pci = pcie->pci;
+
+	if (pcie->big_endian)
+		return ioread32be(pci->dbi_base + offset);
+	else
+		return ioread32(pci->dbi_base + offset);
+}
+
+static void ls_lut_writel(struct ls_pcie_ep *pcie, u32 offset, u32 value)
+{
+	struct dw_pcie *pci = pcie->pci;
+
+	if (pcie->big_endian)
+		iowrite32be(value, pci->dbi_base + offset);
+	else
+		iowrite32(value, pci->dbi_base + offset);
+}
+
+static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)
+{
+	struct ls_pcie_ep *pcie = dev_id;
+	struct dw_pcie *pci = pcie->pci;
+	u32 val, cfg;
+
+	val = ls_lut_readl(pcie, PEX_PF0_PME_MES_DR);
+	ls_lut_writel(pcie, PEX_PF0_PME_MES_DR, val);
+
+	if (!val)
+		return IRQ_NONE;
+
+	if (val & PEX_PF0_PME_MES_DR_LUD) {
+		cfg = ls_lut_readl(pcie, PEX_PF0_CONFIG);
+		cfg |= PEX_PF0_CFG_READY;
+		ls_lut_writel(pcie, PEX_PF0_CONFIG, cfg);
+		dw_pcie_ep_linkup(&pci->ep);
+
+		dev_dbg(pci->dev, "Link up\n");
+	} else if (val & PEX_PF0_PME_MES_DR_LDD) {
+		dev_dbg(pci->dev, "Link down\n");
+	} else if (val & PEX_PF0_PME_MES_DR_HRD) {
+		dev_dbg(pci->dev, "Hot reset\n");
+	}
+
+	return IRQ_HANDLED;
+}
+
+static int ls_pcie_ep_interrupt_init(struct ls_pcie_ep *pcie,
+				     struct platform_device *pdev)
+{
+	u32 val;
+	int ret;
+
+	pcie->irq = platform_get_irq_byname(pdev, "pme");
+	if (pcie->irq < 0) {
+		dev_err(&pdev->dev, "Can't get 'pme' IRQ\n");
+		return pcie->irq;
+	}
+
+	ret = devm_request_irq(&pdev->dev, pcie->irq, ls_pcie_ep_event_handler,
+			       IRQF_SHARED, pdev->name, pcie);
+	if (ret) {
+		dev_err(&pdev->dev, "Can't register PCIe IRQ\n");
+		return ret;
+	}
+
+	/* Enable interrupts */
+	val = ls_lut_readl(pcie, PEX_PF0_PME_MES_IER);
+	val |=  PEX_PF0_PME_MES_IER_LDDIE | PEX_PF0_PME_MES_IER_HRDIE |
+		PEX_PF0_PME_MES_IER_LUDIE;
+	ls_lut_writel(pcie, PEX_PF0_PME_MES_IER, val);
+
+	return 0;
+}
+
 static const struct pci_epc_features*
 ls_pcie_ep_get_features(struct dw_pcie_ep *ep)
 {
@@ -125,6 +217,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
 	struct ls_pcie_ep *pcie;
 	struct pci_epc_features *ls_epc;
 	struct resource *dbi_base;
+	int ret;
 
 	pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
 	if (!pcie)
@@ -144,6 +237,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
 	pci->ops = pcie->drvdata->dw_pcie_ops;
 
 	ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4);
+	ls_epc->linkup_notifier = true;
 
 	pcie->pci = pci;
 	pcie->ls_epc = ls_epc;
@@ -155,9 +249,15 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
 
 	pci->ep.ops = &ls_pcie_ep_ops;
 
+	pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
+
 	platform_set_drvdata(pdev, pcie);
 
-	return dw_pcie_ep_init(&pci->ep);
+	ret = dw_pcie_ep_init(&pci->ep);
+	if (ret)
+		return ret;
+
+	return ls_pcie_ep_interrupt_init(pcie, pdev);
 }
 
 static struct platform_driver ls_pcie_ep_driver = {
-- 
2.34.1