Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 17:30:27 +0200
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 5/7] net: lan966x: Add support for offloading
 default prio
Message-ID: <ZGJQEy+zFFfCdDRm@nimitz>
References: <20230514201029.1867738-1-horatiu.vultur@microchip.com>
 <20230514201029.1867738-6-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230514201029.1867738-6-horatiu.vultur@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Cu69hKfq/uFgAccCdXHIlB+ujk9k/ILFTqCuJP04j2EHERGpOb46PIBzLMWl?=
 =?us-ascii?Q?82xI20ay3Iqi56rOOqlQP/Co7AsXiq+lE0x8Co24+Hay/z11hfPY4oYq6nXM?=
 =?us-ascii?Q?oq5NXgZ46TAzuD3YJ54cdtGok/hhEYhq4c4A3sNgV3JNOtfTh0O5ONLogqIo?=
 =?us-ascii?Q?iT9/A5ku5iH8rMygAusc4LH7et0qVy+qCXnFBUxKuicFxc5zxIBOs2658yB6?=
 =?us-ascii?Q?FcLNfT32qYIQg7xov8fu6HoG+ol8qzrVHge5hXnaAv6Oz0u78P/U5FzRwT1A?=
 =?us-ascii?Q?B6aN5z3TxnS9HZNz5t64Z+23O4/vH4loZs56X8lUNJQSNwtN+/3p4s3aGh8L?=
 =?us-ascii?Q?roSFbFW8CdqDrnt8mZlMMK8jt7gpDdgXc/eJ7O0WOOXwoqUZMJ9b50Y2Nziy?=
 =?us-ascii?Q?FPpVbNM2Y3/dO3L06+fpzJh3NoQ0AFMweBKykeYHlo7whQ7snBwpetJfgwaL?=
 =?us-ascii?Q?QT+9KYOha/uw2ZFo3jGb53Gtfhzhe1MndUpAJgQlb+z2gp7CXi1EFoDAGoG+?=
 =?us-ascii?Q?c+X5GEZmVWT6M4id56xfJ6t0L2wyqteyX/bs8OB3O72p8zGK0tAv71c3ez0l?=
 =?us-ascii?Q?n/73jLkzEgBFpSjmWs4UTLyI0Ua0NZ2BUOGjWdJfxBkTQenDYe7YqUzhytD0?=
 =?us-ascii?Q?2FsZPIqE2qxVL+Sjy+TGCKYiLURcX5O+ooOf8JSUM+1VyjHJ9+fJawdRva4n?=
 =?us-ascii?Q?HbyEfuJcdscBNYOd55fjMDyiWHv0O1vlbAd8gz87J2QdeSSTaWnwDo/3kJQX?=
 =?us-ascii?Q?Mf577oDcjhfP8bsXLGeIZdmLE9eRJbaSDzU2M/ibOgo3ueHA3kKwSNHj9Cr9?=
 =?us-ascii?Q?iwfTBrLDdc3Spe89hyOzMIQmbaIcOys/7Oj0GWEcFZaAjCma87VipO2C+L/H?=
 =?us-ascii?Q?HaVwjOGEvbw+nqN0kjNiKyWCWZatvghKQQt92kDQcCQBsN+yFv9rHbhPJkKE?=
 =?us-ascii?Q?GDz3+YCKAjHQ15XFamAkjCk6UMjmo5je5giMst0U5bGKvn1KTWqGypB+xLEM?=
 =?us-ascii?Q?+xUNF05JHd2T7J4GpJDU4nPfre0imr42geKTNXBdyGwvFMOBnCGlSDqZXPlQ?=
 =?us-ascii?Q?YhmC94ktO7imHmVyJE9s4kZVuDEKN/FqcG7W0xACLlSmRL5ZP/9KoJIs1ZzP?=
 =?us-ascii?Q?zmyr7iqMk6B1ozuhJ7inKUlhoY/xrkABxWsZXmFdDH+COW5HaE0bg99EUO70?=
 =?us-ascii?Q?jvAtwDHHqGLR1gCFnz/lhouz6N4V9juzvyu7B95vK0bYqw3pYPt2XhfxeBPx?=
 =?us-ascii?Q?drSXtrQNx5Dga+g6tszGXYfyk8i8hniEXBOcDRnxOfcDeCL5SQbeTXbtvd1O?=
 =?us-ascii?Q?XLg3yI9xb/G9k6oPFq5O9XDGx8GA4NTKq549J3b3IUAQi/0fkghBe0aYKCa5?=
 =?us-ascii?Q?yd3m53NthVb+SHFMkCo9wNuPLW/K6y9AGgTNlGSzl2PQWpgzWQQDqIEpaN1S?=
 =?us-ascii?Q?7ymIgD/um4cPxqO+RbR3Xv2Ei4Tx2YIPTsk7QsUc8w7VK6ymc/Vx13tiO539?=
 =?us-ascii?Q?7ocOQmRDGvpv2dHAbUeA23yAGHTnAFFzUJ8VNLg0yAV3skHF+BFGMvTTUmnb?=
 =?us-ascii?Q?r0bE5ObGG4YFLtiJkiTEOVImXhur8AURBc63WmkJfaURpj187e0krI9hbqEN?=
 =?us-ascii?Q?nA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e5f071e2-023c-4d84-a8ba-08db55595284
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 15:30:32.9531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ixGUhlf8SX/V49ooQl0SUfvDQdssPDGWxasXY0+Ms+Fu5R7UBE+br6VwoAat5zIlVK8ku2q3zAOkY9Pc2z0ubmPc2kpFIbhUpH79iKeNww=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7252
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 14, 2023 at 10:10:27PM +0200, Horatiu Vultur wrote:
> Add support for offloading default prio.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>

...

> @@ -106,6 +111,13 @@ static int lan966x_dcb_app_validate(struct net_device *dev,
>  	int err = 0;
>  
>  	switch (app->selector) {
> +	/* Default priority checks */
> +	case IEEE_8021QAZ_APP_SEL_ETHERTYPE:
> +		if (app->protocol != 0)
nit, you can just do: if (app->protocol)

> +			err = -EINVAL;
> +		else if (app->priority >= NUM_PRIO_QUEUES)
> +			err = -ERANGE;
> +		break;

...