Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f6a4ae36-9976-6727-f462-259517c8d0cb@antgroup.com>
Date:   Tue, 16 May 2023 00:00:34 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH] sched/headers: remove duplicate included header
To:     linux-kernel@vger.kernel.org, mingo@redhat.com
Cc:     "=?UTF-8?B?6LCI6Ym06ZSL?=" <henry.tjf@antgroup.com>,
        "Peter Zijlstra" <peterz@infradead.org>,
        "Juri Lelli" <juri.lelli@redhat.com>,
        "Vincent Guittot" <vincent.guittot@linaro.org>,
        "Dietmar Eggemann" <dietmar.eggemann@arm.com>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        "Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
        "Daniel Bristot de Oliveira" <bristot@redhat.com>,
        "Valentin Schneider" <vschneid@redhat.com>
References: <20230506153924.7641-1-yanyan.yan@antgroup.com>
From:   "=?UTF-8?B?WWFuIFlhbihjYWlsaW5nKQ==?=" <yanyan.yan@antgroup.com>
In-Reply-To: <20230506153924.7641-1-yanyan.yan@antgroup.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Ping.

It seems that removing the two same included lines is ok. Because the 
following "sched.h" also includes psi.h.

Any comments?

Thanks,

-Yan Yan

在 2023/5/6 23:39, 晏艳(采苓) 写道:
> linux/psi.h is included more than once.
>
> Signed-off-by: Yan Yan <yanyan.yan@antgroup.com>
> ---
>   kernel/sched/build_utility.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
> index 99bdd96f454f..80a3df49ab47 100644
> --- a/kernel/sched/build_utility.c
> +++ b/kernel/sched/build_utility.c
> @@ -34,7 +34,6 @@
>   #include <linux/nospec.h>
>   #include <linux/proc_fs.h>
>   #include <linux/psi.h>
> -#include <linux/psi.h>
>   #include <linux/ptrace_api.h>
>   #include <linux/sched_clock.h>
>   #include <linux/security.h>