Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 12:06:44 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH 04/10] maple_tree: Simplify mas_is_span_wr()
Message-ID: <20230515160644.lqhrclw3kcutsafc@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230515131757.60035-1-zhangpeng.00@bytedance.com>
 <20230515131757.60035-5-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230515131757.60035-5-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gZom5m0xaOXoTEyfL9P3fmSfIXYCT8aFR6chxoxdwV5g/XS9gCyhZIoUgWlB?=
 =?us-ascii?Q?yTvEoy9at1/bCMXD0UPyOjbUN28B9fcLRHEfx+qEHKEZ5Q/pMzb5NHm7JUSh?=
 =?us-ascii?Q?f3lBGIahykae+LXIQcEIZnu5rtYnMWyrwqLBIir71yDfCypdTdiDU5SbOtEd?=
 =?us-ascii?Q?y8RQk8s3yB6lzyb5SuPw4SvxAFClimeH0TiBmpfQqYkOvbl4eMRCkmKjmia9?=
 =?us-ascii?Q?+sgVH7zpCZ8lt/s6ok6SFCbZlh+sjyn9kodtCTJ0meiNPz0/5P0PbEf14JYd?=
 =?us-ascii?Q?zWbsDlLLbDnbLabG8zJJ0sY8+aX1Tn8pP82GwUlU8QiFx3/dr+EZ/r0GBzTk?=
 =?us-ascii?Q?FPL0T8vfUB3izwH3wNM63reFI3Fra0C96ZEdQYttl6ztOUQ3KpKLQlupMBt4?=
 =?us-ascii?Q?PEtriu6aYyO7i49/DDHVeNCDMIf8vcWCwuOwscW+AD5bIxCErBqWO0Ae5Mm6?=
 =?us-ascii?Q?9nnBMZIUk0SRjgiU4NT4xkzu34lkg25XO+VTbsxzxmLdnLj1M+dOowGUaVwC?=
 =?us-ascii?Q?bgrLSwSw/WeA3ovzYT812gPU0weBBJA27FLF3F6ozRVo1H1IMIUlU3gSFuxY?=
 =?us-ascii?Q?2YMLkZoBK7CFs1K0kjCUIwaO9gWKaIJtqoj5l++HK2mHAVmtXPSdsj5Z9KMB?=
 =?us-ascii?Q?7EHc7hQYcXD9n7k6jNW7265uIAe0qdrbhW9fufk377sArue78/3WQL5cj43Y?=
 =?us-ascii?Q?qmlNkOGQzD6VuaXfJRyowvi7PTGSFavtClc4vP0MEIlWHlNz4T4BUlJoXFvc?=
 =?us-ascii?Q?kIA3DZ1qdoGPIX8Czt4+Bd83ej0f1QGXfJVCh8mwSfIQyxdU8/pOIbUVD+qy?=
 =?us-ascii?Q?Te9u6BOMWlCpknExK58C15QJ+LZwyeuO3792VBj4aWjwnIV31ovN1hfP/kMQ?=
 =?us-ascii?Q?uexanrzVnigBtXZw1pzxtlJ9qhgkz4/zyrVqud29qoYVwTbnwHEfUfr6gfHj?=
 =?us-ascii?Q?jfeKUjBQZXLZgHQOhxtuNM0ZDymIF2Sl9Sbg3FUY1kUThvKN1cnMab418kiW?=
 =?us-ascii?Q?bMen07mI/LD/YxTny9cD0jWwo1mYi4yq/IKrb4B7cs4D57B8F/Eh/88mgLlY?=
 =?us-ascii?Q?IgsgASgqtAMv0dwZJPCYDdGzs/KDr/lDbAXrgAAoLaGXVrw1D3D9pMXMxcvI?=
 =?us-ascii?Q?XvBJhTfQ+Q89s46Yh829TB45lkh57cKKfhBp8FuoMNRG367B7Nm34XdvK9rV?=
 =?us-ascii?Q?YRyGGZihSvV3hdBkNE7dvTEQMd+lVozN0QTsiKxwow1wbj+PzuINLMYh68gg?=
 =?us-ascii?Q?V+6itGcktpfRlxSc/BSr7eCSRAdlhdSBBvks/GpJxkSTgdu1i8u1FBEv3vqB?=
 =?us-ascii?Q?9UEfisjTda7Oxmj0UxO1TthZHo9SiiFZFAZHX5s/GuFCwAbNxTnn/Rtmg9FR?=
 =?us-ascii?Q?Rk680pmEY72vFzZ2CPYtinvjWu6kECmYO1VWKXwe3kgeQC7hunPwTUWrVJ5s?=
 =?us-ascii?Q?v22u1ttqY8PHK5XvGdJSKf+UDud7KPKU4Rh52T1BupXMG7DRuU58GvTd7a3m?=
 =?us-ascii?Q?8kqrf1AQUDVDtqzHZK/vAI7noDNuUn4qm8Py2ctRSi3d8Vk5SZRk5r9eqc3z?=
 =?us-ascii?Q?CYS2ZjdV0ANMKXNHSKr4HGt8E0AMNvEkSDzZxesU2OcfQK1qv9a6vbmh9N4y?=
 =?us-ascii?Q?eQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Ey4vtaRuUIW3awQEnBV2ynvNcEqDdxbG+7tAD24623uDXexl8v3AYuY5j+Jw?=
 =?us-ascii?Q?1t5ACwX1Vk8Ieyq86WgL9N+vHzcu0Su4J8iW1CDoR7YFaHgXBKSXe+gB3Vfw?=
 =?us-ascii?Q?bjtrECCmAs6CCfiyjFy73dgG08iS2Mv7QBOvB0QWZpWwovIfROyQtKM8m7ps?=
 =?us-ascii?Q?pOhbzdu3WG+xIfGoB/AfSUdhWWVcIV/3hsK1v+6ds8pZGTIfLoxYT6Jd3qZD?=
 =?us-ascii?Q?Ie38lojSuEWZt1Z5c6slo0Vjg548yPnwBNKU0/YHRIw3XbltdPe1v1htKehb?=
 =?us-ascii?Q?KnVWPXYrFX07pTB2G+Fcow6B8f2VI8mafZkmWgd5w+ng8eU40ditq78XhVxB?=
 =?us-ascii?Q?2u00muWw+8IKERfDUZIUGmr06wG3bfi9QKFrYEqltM73hNKqwkYYO1M3Z5OF?=
 =?us-ascii?Q?51vV5VVfXDPcQ3ONvlyQ6CSabEsYIfb1F83aMY1oUhBMqGjsdj/RkJmTfMDx?=
 =?us-ascii?Q?iwF+CJ/1a7tvZte5owq9EgV8r9TP5mywB5lacbMHwHeGADl2jkpPNjWPwPDn?=
 =?us-ascii?Q?r7GDh6p0PG3w1VLc0Qhgc86NgIWwugqjTnmZrxd04fL82uluAxPayKlvIqAB?=
 =?us-ascii?Q?N1qjuoGwkT6bb5Zmmqzx7BU6rfI++BOAStqSoVV92D5ZCdux9FVV1oLQy9lv?=
 =?us-ascii?Q?9JYXLDkFrMbnPDhTjrZyrj3dTHLzM0kE1FpQHwQpzsQQFFwU/qu2qlQPBncz?=
 =?us-ascii?Q?5eUvAwc3FruJYsHWl/MME6DTvLPXRwKzV3D8wlZ0gUeCguP5gP6tQd4yz1nU?=
 =?us-ascii?Q?C8kcYRO3/L5DuZN+20TQsMzz6pu2qtk71BK1gRaiYM3KSKngpF8FXX6OSDgS?=
 =?us-ascii?Q?OOCd8we8SyT/7pW0QfnMNgjpIStujQgjBCPTd1UiTSnlQLxGzJ9hy15JvEjL?=
 =?us-ascii?Q?vOmB50SF+NRUF8Yw2Vr0C+bHEN4Z6m7Trf20qIhHEesvQw4Eenof/Yh/+F0U?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0642db2d-a06a-4db9-5879-08db555e6255
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 16:06:46.9702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2VdHjg0O2s9jSy4U73i7mVdjUn0yQQs1xkYmvoDWvPxVP+egrADcuiFLQPbr1065bQ7pzq5bR8UwPKMs6F3u7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5769
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-15_13,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0
 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=515
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305150134
X-Proofpoint-ORIG-GUID: lFhB06pVtjE2MS5nD7xdbuz8o-ZTklpj
X-Proofpoint-GUID: lFhB06pVtjE2MS5nD7xdbuz8o-ZTklpj
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230515 09:18]:
> Make the code for detecting spanning writes more concise.
> 
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  lib/maple_tree.c | 36 +++++++++---------------------------
>  1 file changed, 9 insertions(+), 27 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 43a25d3042c1b..fbb6efc40e576 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -3728,41 +3728,23 @@ static bool mas_is_span_wr(struct ma_wr_state *wr_mas)
>  {
>  	unsigned long max;
>  	unsigned long last = wr_mas->mas->last;
> -	unsigned long piv = wr_mas->r_max;
>  	enum maple_type type = wr_mas->type;
>  	void *entry = wr_mas->entry;
>  
> -	/* Contained in this pivot */
> -	if (piv > last)

I test this first since it is far more likely than the rest of the cases
in this function.  Most writes will land in a leaf node eventually, so
this will be true most of the time.  I'd like to keep it as a fast path.

> +	max = unlikely(ma_is_leaf(type)) ? wr_mas->mas->max : wr_mas->r_max;

Please expand this to multiple lines.  It is better to be more clear
than compact lines of code.

> +	if (last < max) {
> +		/* Contained in this pivot or this leaf node */
>  		return false;
> -
> -	max = wr_mas->mas->max;
> -	if (unlikely(ma_is_leaf(type))) {
> -		/* Fits in the node, but may span slots. */
> -		if (last < max)
> -			return false;
> -
> -		/* Writes to the end of the node but not null. */
> -		if ((last == max) && entry)
> -			return false;
> -
> +	} else if (last == max) {
>  		/*
> -		 * Writing ULONG_MAX is not a spanning write regardless of the
> -		 * value being written as long as the range fits in the node.
> +		 * The last entry of leaf node cannot be NULL unless it is the
> +		 * rightmost node (writing ULONG_MAX), otherwise it spans slots.
> +		 * If this is not leaf node, detect spanning store wr walk.
>  		 */
> -		if ((last == ULONG_MAX) && (last == max))
> -			return false;
> -	} else if (piv == last) {
> -		if (entry)
> -			return false;
> -
> -		/* Detect spanning store wr walk */
> -		if (last == ULONG_MAX)
> +		if (entry || last == ULONG_MAX)
>  			return false;
>  	}
> -
> -	trace_ma_write(__func__, wr_mas->mas, piv, entry);
> -
> +	trace_ma_write(__func__, wr_mas->mas, wr_mas->r_max, entry);
>  	return true;
>  }
>  
> -- 
> 2.20.1
>