Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230511062725.514752-1-namhyung@kernel.org>
In-Reply-To: <20230511062725.514752-1-namhyung@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Mon, 15 May 2023 10:08:31 -0700
Message-ID: <CAP-5=fVkLpcyuEjay_VUq9+K7nFRKPTCYr6SH-VBcrSfkKUoYQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] perf annotate: Handle more instructions on x86
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 10, 2023 at 11:27=E2=80=AFPM Namhyung Kim <namhyung@kernel.org>=
 wrote:
>
> I found some instructions didn't parse the operands properly.
> Add them to the table to fix the issue.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/arch/x86/annotate/instructions.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/arch/x86/annotate/instructions.c b/tools/perf/arc=
h/x86/annotate/instructions.c
> index 305872692bfd..5c7bec25fee4 100644
> --- a/tools/perf/arch/x86/annotate/instructions.c
> +++ b/tools/perf/arch/x86/annotate/instructions.c
> @@ -35,12 +35,14 @@ static struct ins x86__instructions[] =3D {
>         { .name =3D "cs",         .ops =3D &mov_ops,  },
>         { .name =3D "dec",        .ops =3D &dec_ops,  },
>         { .name =3D "decl",       .ops =3D &dec_ops,  },
> +       { .name =3D "decq",       .ops =3D &dec_ops,  },
>         { .name =3D "divsd",      .ops =3D &mov_ops,  },
>         { .name =3D "divss",      .ops =3D &mov_ops,  },
>         { .name =3D "gs",         .ops =3D &mov_ops,  },
>         { .name =3D "imul",       .ops =3D &mov_ops,  },
>         { .name =3D "inc",        .ops =3D &dec_ops,  },
>         { .name =3D "incl",       .ops =3D &dec_ops,  },
> +       { .name =3D "incq",       .ops =3D &dec_ops,  },
>         { .name =3D "ja",         .ops =3D &jump_ops, },
>         { .name =3D "jae",        .ops =3D &jump_ops, },
>         { .name =3D "jb",         .ops =3D &jump_ops, },
> @@ -123,6 +125,8 @@ static struct ins x86__instructions[] =3D {
>         { .name =3D "test",       .ops =3D &mov_ops,  },
>         { .name =3D "testb",      .ops =3D &mov_ops,  },
>         { .name =3D "testl",      .ops =3D &mov_ops,  },
> +       { .name =3D "testq",      .ops =3D &mov_ops,  },
> +       { .name =3D "tzcnt",      .ops =3D &mov_ops,  },
>         { .name =3D "ucomisd",    .ops =3D &mov_ops,  },
>         { .name =3D "ucomiss",    .ops =3D &mov_ops,  },
>         { .name =3D "vaddsd",     .ops =3D &mov_ops,  },
> --
> 2.40.1.521.gf1e218fcd8-goog
>