Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762450AbXJENNU (ORCPT ); Fri, 5 Oct 2007 09:13:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755705AbXJENNM (ORCPT ); Fri, 5 Oct 2007 09:13:12 -0400 Received: from rv-out-0910.google.com ([209.85.198.187]:17648 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755781AbXJENNK (ORCPT ); Fri, 5 Oct 2007 09:13:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lR9myqEMB9ZzKeGYtbIJ/1Q6bJsAQZem5UHQORr3mRF2I/eskf/7GWfx1PzkWHZ1yDDJfZVbh1lABK1j10ILjWv7YfPyYIPZu/OHaJKM170fr27yOKqgO/hHGRDdv8Mh2eruYpTSKSabVYzQnEvd49KCJOUYHQBOpziBFw4KXmk= Message-ID: <19f34abd0710050613y62fe6417lb47dc2bc7ad69b28@mail.gmail.com> Date: Fri, 5 Oct 2007 15:13:09 +0200 From: "Vegard Nossum" To: "Rob Landley" Subject: Re: [RFC][PATCH] New message-logging API (kprint) Cc: "Randy Dunlap" , LKML , "Kyle Moffett" , "Michael Holzheu" , "Joe Perches" , "Dick Streefland" , "Geert Uytterhoeven" , "Jesse Barnes" , "Arnd Bergmann" , "Jan Engelhardt" , "Emil Medve" , "Stephen Hemminger" , "linux@horizon.com" , "Miguel Ojeda" In-Reply-To: <200710042059.25721.rob@landley.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1191528247.13580.11.camel@grianne> <20071004131703.25046db9.randy.dunlap@oracle.com> <200710042059.25721.rob@landley.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2083 Lines: 47 On 10/5/07, Rob Landley wrote: > On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: > > On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: > > > Description: This patch largely implements the kprint API as previously > > > posted to the LKML and described in Documentation/kprint.txt (see patch). > > > > > > The main purpose of this change is provide a unified logging API to the > > > kernel and at the same time make it easy to add extensions, now and > > > later. > > > > > > My changes and additions are as follows: > > > > $ diffstat -p1 -w70 kprint.patch > ... > > 40 files changed, 1660 insertions(+), 72 deletions(-) > > I started this thread by posting an idea I had for shrinking the kernel by > allowing more code to be configured out. The API change was exactly one new > parameter, with a direct 1->1 mapping from the old API to the new one, which > was trivial to convert and which the compiler would catch if you missed one. > > The result of the discussion is a patch adding 1600 lines to the kernel, > without removing anything. Of course. If you look at the diffstat, as kindly posted by Randy, you'll notice that about 500-600 of those lines are documentation, configuration files, and headers. What's really a concern (and a valid argument) is the overhead introduced for each call to printk(); the defconfig kernel on x86 increases with about 210K. I will try to improve this. > Last I checked, the current prink() worked just fine. Why is this _not_ the > dreaded "infrastructure in search of a use"? What exactly can we _not_ do > with the current code? What does this allow us to remove and simplify? With the current code, localisation is not possible to do in a sane way. My change is a "catch all" in desired features -- not just removing some unwanted printks. Vegard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/