Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   andy.shevchenko@gmail.com
Date:   Mon, 15 May 2023 21:34:36 +0300
To:     Andrew Davis <afd@ti.com>
Cc:     Peter Tyser <ptyser@xes-inc.com>,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] gpio: pisosr: Use devm_gpiochip_add_data() to
 simplify remove path
Message-ID: <ZGJ7POc8Qm9pE_WZ@surfacebook>
References: <20230515174321.494714-1-afd@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230515174321.494714-1-afd@ti.com>
Precedence: bulk

Mon, May 15, 2023 at 12:43:21PM -0500, Andrew Davis kirjoitti:
> Use devm version of gpiochip add function to handle removal for us.
> 
> While here update copyright and module author.

...

> +static void pisosr_mutex_destroy(void *data)
> +{
> +	struct mutex *lock = data;
> +
> +	mutex_destroy(lock);
> +}

No need to cast void * explicitly.

static void pisosr_mutex_destroy(void *lock)
{
	mutex_destroy(lock);
}

-- 
With Best Regards,
Andy Shevchenko