Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 16:26:50 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 28/35] maple_tree: Add mas_next_range() and
 mas_find_range() interfaces
Message-ID: <20230515202650.3psyybdg64ptmx6i@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230512182036.359030-1-Liam.Howlett@oracle.com>
 <20230512182036.359030-29-Liam.Howlett@oracle.com>
 <20230512160857.820fc7a14256c1031c586113@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230512160857.820fc7a14256c1031c586113@linux-foundation.org>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qA71a63fmVu49qARW8dN/skKVL1LTCPR+1EyEWVILCxYgq6lILdtFfBfP1uA?=
 =?us-ascii?Q?0TRQRmCXApTJTerWu+WlroUUoiijzukN0fMPjLUYjoQFt3VUxmSxnopFMLmC?=
 =?us-ascii?Q?OxNJmze65YNkS7qvcSGt0Ei0RAh3uhT2adEUBfLFybNpb9DOLC6Lm0M0km0m?=
 =?us-ascii?Q?EM8kEJ/2k3PzLCEotOHxcjj1lpncceL8hLnMjUgSKpoKeh01MfnbM78D4hMk?=
 =?us-ascii?Q?RNWWETtFaU/KSj7BN/oD2nv0EjIGFFV88crCqJfpIqpf9m9rO5RQj4fCrdeA?=
 =?us-ascii?Q?PmruerWfYZDGMNLyIZUvo4zGQRR/2cOixYfXGGKRrkc/OgOG07vPtiw0JvUB?=
 =?us-ascii?Q?lNsqynsP5LV5zXdc6oo130oZTXW/Fh+Hfc4r3CJBoJEJeY+OUrhPv7XFthQv?=
 =?us-ascii?Q?VNxJplF7TaLvCac9LImUj6VrnwrQh1pI4GC6EnU5yZWzIaIIDFa9tfSoGo+g?=
 =?us-ascii?Q?auc+5Do7EhxM4MKUk22gL4v4vxgj7UexJ1dXz8hHkJElh6DSm0iXnRoqjdAi?=
 =?us-ascii?Q?lBsMHy4BpW627e6AbKf0BKb7sVIL5a3RUjq6lqCSWagHeY4xl4MYSthV4gN6?=
 =?us-ascii?Q?HMLEKTM+9yckT6iE3EcFCCpY+PvB9kB74ILfdA1/Oayaeo/zO9wLm1l+ekI+?=
 =?us-ascii?Q?udbYDR3BlIEa50J+ANDuhOo75Ad9r/bFAlgZLDzIzLfARyLj4SfUMiW9XxFy?=
 =?us-ascii?Q?KUjFxf2G/G5jUYhdT05sEHoeAVFmlLeDrYBZZs/C8qAOXi0UmtFO0vfa0Lzn?=
 =?us-ascii?Q?UzwtDkBhU6A/NF/XS015mslQERmZDYxHV1iD/nMHJ9ACxZQvtN0/jpLZL0fW?=
 =?us-ascii?Q?A6YNTcNPo3ReMA0MY47V5DWFyos/1mQuBVvFteOzGmnzovy6sczqOus+eeA1?=
 =?us-ascii?Q?DlvCQUeUJXaioS3SdRkEkDDyYjULIqbU6PJgRrEKEHlDBlraJB4G7VYlfQXn?=
 =?us-ascii?Q?X+/Lfnos4IxPzDzh4kUvQXD0TMl7wRJKktWsrG9B++VaoisiNSwO1HqwvxfY?=
 =?us-ascii?Q?VsxW2N2PSQ+q/4rKPYkWkN0eC4SfzG8zt6XD+DfM54f66iGfKH4eXUWaFY7B?=
 =?us-ascii?Q?3usL2FCvEbbdr9VxV0RR9kxlf+5BE4OJC+j0BUed8DkInoIP8utOIXfo+Ssj?=
 =?us-ascii?Q?t+fRo8UG69oF+Sxb5+NflqPJ4bcpa0deuoAIdbPUY4/yCBeaEzeccr5Zr4kj?=
 =?us-ascii?Q?uwudG/pkyYtjPTbGdjvCwqgJVgDXSXcPFviF9QGOPytgIIOvz4HUaYRsJ3Zv?=
 =?us-ascii?Q?MNlRMRpFEq/pGNK3eMGDrFqQCICfFysucS+9+HnG74CIjQnl15rLsARndc3P?=
 =?us-ascii?Q?3ybmem0kfjyA0JwooQjzBR5SOZQXQd+iyYhMpOMC7lgXbdFb2F/hTto4FdA3?=
 =?us-ascii?Q?TH1WuxIRHyp7/UT3pSB3D3RckT+dIzaJtM0jhPlF3wRZDmmKTxxPyRmz3LBL?=
 =?us-ascii?Q?iD+Xz1AGeXiKSvkQqwDVV+ht1IckmqU1Q3DlkL2YW1J+j9OxnTf6JTX0bIJD?=
 =?us-ascii?Q?aCKkbxorj4MEQ67qvCHZlfTtL+DLfgS0T3pjSPstLKCeIYRv87ZwHDeUL/6P?=
 =?us-ascii?Q?IbEls3xkSpvDWRqRnx9ILQ9kn6e+v3YpRtdSkh6bJnSR8jGiuqf3QIh9StY5?=
 =?us-ascii?Q?Tw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vo8SSJ1zAA9fZYEZL15ly4Tsr/Eh85EY9wpNLUdMY69sOBRpP5Jd0YJ+pTJVAvuxifghHOqAPwUkhFM0dWwmiy2dyvhjCOdEvpPbaJ0tig4+JnmMQqWVVxdVJL6YWHlo1geqCL+uKH3000EQy37MZymEGDgqg3Flsu67MIJXbE7fVmCPBExlc0evqlPoAFyhLvqF/0uPOPEe9DWuLTD2Lw0ormnK2y6wN0JAASRK9MrfBs0F8viywexjwTzZGpyG/xxgCUIa/GrbYPcaGtmkxsoGM7CeSk1gALhvyW0n7nEgmUN4jeXgO7rvzyj36MvxmHiO4I/vdg5p/qrxE6yOvpJHNIUPPD9+hcD1kWmmqT1rpwt+dI+AwkwYeuMPrSlmW8VrQ8pppqFCc+k3lQL4L+SeOiOYG6y2i6ku3CWotG4+tiofKGhW6Wi+NvAt1NM9pxO/prKsvEasCVFfUMT/K4bh82/WdKeA8Snje8/g2mmDvxBuhigQ2VCvxGtJWfTs4Kj785cHDsCO3pOSHcleebPJS7vP2+aPDuUT4ZBwQWjHHiF26d3XWGYOaUqkcFUJKj9yefhGwsZKFDVphRjO6cmwegTwIRSqmT2GjdBNSWiKMA9EqhllesxOTqDsmxFKAi3eCuNncfI4Vnd89vNBNx0iqBqPZcSEBkcmn/vTsKH1JHSWzvXaNwNu6624LhX7xzsUcW5/sxey0ANJex37NtXCcoUJUmRetdkYDk9R3H/SAaMr6dx/c8Kp43qOa3vjXNuCgX8dLbHsVd90yLQrx5hwOwWYGgj+aH/6e0h2cndxd4VeWdB0ICesxpEQ0V5V5O8eqTB0P7UFQaJ3KC8hdaMR3cZaqC2Mgr777BKtuRZJ/cC6Q2y5Uo7osKKkp50/RnPuFY4L5Lc+3eReXUlApg==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 854a4876-11d6-4e81-79a1-08db5582b7ff
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 20:26:52.5539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0W10c3CBkWT00R1fbQddB+UgvoqA4Gfu/ZNmjkQkLZCQxWE1ig9Gsx8taDibIYSC8RVYcueqkGxCbTg1X9lVcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6750
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-15_18,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2304280000 definitions=main-2305150169
X-Proofpoint-ORIG-GUID: Pn2wekHvDkCrufhQdk9Iv46qSGw-OE_P
X-Proofpoint-GUID: Pn2wekHvDkCrufhQdk9Iv46qSGw-OE_P
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Andrew Morton <akpm@linux-foundation.org> [230512 19:09]:
> On Fri, 12 May 2023 14:20:29 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> 
> > Some users of the maple tree may want to move to the next range in the
> > tree, even if it stores a NULL.  This family of function provides that
> > functionality by advancing one slot at a time and returning the result,
> > while mas_contiguous() will iterate over the range and stop on
> > encountering the first NULL.
> > 
> > ...
> >  
> > +/**
> > + * mas_contiguous() - Iterate over a contiguous range of the maple tree.
> > + * @__mas: Maple Tree operation state (maple_state)
> > + * @__entry: Entry retrieved from the tree
> > + * @__max: maximum index to retrieve from the tree
> > + *
> > + * When returned, mas->index and mas->last will hold the entire range of the
> > + * entry.  The loop will terminate on the first NULL encountered.
> > + *
> > + * Note: may return the zero entry.
> > + */
> > +#define mas_contiguous(__mas, __entry, __max) \
> > +	while (((__entry) = mas_find_range((__mas), (__max))) != NULL)
> >  
> 
> I can's say I'm a fan of this.  The name doesn't imply that this is a
> looping construct.  I can't say much more because mas_contiguous() has
> no users..

I got a little ahead of myself with that.  I will drop it.

My hope is to introduce it to simplify the cases where users are
iterating over VMAs and want them contiguous.

I'll come up with a better name when I re-introduce it.