Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 22:19:31 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     wuych <yunchuan@nfschina.com>, dchickles@marvell.com,
        sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: liquidio: lio_core: Remove unnecessary
 (void*) conversions
Message-ID: <ZGKT01kLOQNRqx9I@corigine.com>
References: <20230515084906.61491-1-yunchuan@nfschina.com>
 <61522ef5-7c7a-4bee-bcf6-6905a3290e76@kili.mountain>
 <2c8a5e3f-965e-422a-b347-741bcc7d33ce@kili.mountain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2c8a5e3f-965e-422a-b347-741bcc7d33ce@kili.mountain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?trnmBTMe3s63hkIw/dvktBVQUbUi1iOpvleXCPZTJeuSLJb0cMwBu7Be/E0i?=
 =?us-ascii?Q?zJ3UY5gXLQomZkTsC3xx39xQvP7I/2yu7IhUwQZPUPrP8iizGOsgDhin8hBC?=
 =?us-ascii?Q?fP//z1kIfhG5t5kJZ5yjvrOY6tDxFz2egVH9FnmTGZh59gTs+7pQ/+kCR3Va?=
 =?us-ascii?Q?iJD7DxT+et30t2CsGJlRYXxBq3cul1llYBi2/fxGurXlghS6EAoblSvz+6vr?=
 =?us-ascii?Q?2m2L2z2iyiujM0cg3afzzxIxzZYxHICBwNbG6/ZjaP3bKC/NamzMDchXpxeK?=
 =?us-ascii?Q?Frp8sMRKystcdW5j376XXDtHVA6WObkTY5BZpobi8xmcJYIKexM8TjPcpVpH?=
 =?us-ascii?Q?wdLuQ2P8ZabBeHI/+i0QeUJ+6iAbyHivqBKWLkofpcMUY/J18xO42wGMAxlJ?=
 =?us-ascii?Q?+lSxNiGOzIZi7fgTbLZ8YguCzS8T9WQwI8798ktqzvRWcTkoLJwlue0dZJcL?=
 =?us-ascii?Q?XFD8GjYSLOS7JdQ81vFgVWszimTessnFYEXpa6xpN0PhkFPfzP6GxpwzEhlc?=
 =?us-ascii?Q?VayIqbvvjZLDxRA01OQjEMEB4Fcpam2yb7QbzmjZ6D5Mw0eEgLqhMMHB8dUr?=
 =?us-ascii?Q?D7Yzc6h75IwjsL3yqi8LsfbWnxJ3JQlO+60xGfLNKOrgZUOfpyyPFZWU7HZG?=
 =?us-ascii?Q?RAUT49zKC2QZ/QgFGrMr+JK0BMktgVjRgpVAfmfYAaOj4lCrLFI6aBceapee?=
 =?us-ascii?Q?I9pNg2PzQngziw7QOy0y98wnk2zDdWD5X1ZVziLSHwGuxp4DfPMMbyS1dR/A?=
 =?us-ascii?Q?wNfxUZ8ZEUemNFLjZofGr2e0RUZql6VxkLMTuQp+XMgXIKty2iPihHLd+c4g?=
 =?us-ascii?Q?0hbTAkhyoMzmcYv+sjcsQC90dr4p6OnHTEn/qBcexG2u5uUJaafUCSXEmply?=
 =?us-ascii?Q?DVPDrgoJua9bXT+nc+QMeSbH6W68EcYKoda29SB2YlI7p1PyfOxhrpI+ccz7?=
 =?us-ascii?Q?y5Yq6pD7li1UwodQYJfQoMs5tjv+FkjjI7pRNPyMPBhBSnM8xUQsUlUmzLKk?=
 =?us-ascii?Q?uug0n/7J+mCd08KWwRCunAHTNntg0MAu4Vu/pDcADuuXEyXL6hzAXlCLoeOT?=
 =?us-ascii?Q?86yZLli424VP536a173GMELji1uTmX7TxquAXGjBvXw9uns7HJoV48glEg0v?=
 =?us-ascii?Q?POJt3iLo3EEbgLwTOCHFO4ck1HO8JOfD9VpqDUnvFIvPAtc1gjB8DM8AbGFA?=
 =?us-ascii?Q?tAne+g17Wa+UxP3jgsFyORmvPAxCBQzAtgJ/EkYln0Bl51mJUCTkGL7IMXwG?=
 =?us-ascii?Q?HyicuqdSYahTZoXDrExeYiwnxzktetaPaG/09fDIAuYH2Yw3tFSm7h7P13fa?=
 =?us-ascii?Q?JYbkPOgkPXRS/nt5hglQxVY0lqANIhkdQwFw9W8AFJnx05DimfP4ywkaf0I9?=
 =?us-ascii?Q?WntQPUB+7R7Ah1ZU0fDGer4tAAFUGY1WLP328Yr7TADG2cFcH4fSeXsUqECR?=
 =?us-ascii?Q?GtTVC52AvF3Gani/n1D2xAImMrQ+K8ndbY5pUYR7uvdhA5gfegQY/0DnRK/J?=
 =?us-ascii?Q?wwxCKZx0OEjLqJWGFQOrhfRjzQatVvwEUT+2zB5lMp1vLy7WU3lCP78LLxfT?=
 =?us-ascii?Q?Li0p3M4OSJdnXiQLAkdFXJ/dPuXduzh3tTG1tgym2rQ7wIundOOQua2Vx5pC?=
 =?us-ascii?Q?hDy4Cf/aV8EDMJywoHI8rEaHQffnXe1+DqNYoEk4Zd1++ya1riQnVm252m3m?=
 =?us-ascii?Q?j7KLEw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a89ec0a1-0185-43d0-838c-08db5581b51f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 20:19:38.2504
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 24GMND91BpEAKaDX8scXQG8ji35LbQhJEBLmX9bixkf88/Z5hgqeTb5bMTGymxx8Ielyh3NOiimvubZRmw0OzjlLfP4C7cGO778YIbsJRD4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR13MB6432
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 15, 2023 at 05:56:21PM +0300, Dan Carpenter wrote:
> On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote:
> > On Mon, May 15, 2023 at 04:49:06PM +0800, wuych wrote:
> > > Pointer variables of void * type do not require type cast.
> > > 
> > > Signed-off-by: wuych <yunchuan@nfschina.com>
> > > ---
> > >  drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > > index 882b2be06ea0..10d9dab26c92 100644
> > > --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > > +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
> > > @@ -904,8 +904,7 @@ static
> > >  int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret)
> > >  {
> > >  	struct octeon_device *oct = droq->oct_dev;
> > > -	struct octeon_device_priv *oct_priv =
> > > -	    (struct octeon_device_priv *)oct->priv;
> > > +	struct octeon_device_priv *oct_priv = oct->priv;
> > >  
> > 
> > Networking code needs to be in Reverse Christmas Tree order.  Longest
> > lines first.  This code wasn't really in Reverse Christmas Tree order
> > to begine with but now it's more obvious.
> 
> Oh, duh.  This obviously can't be reversed because it depends on the
> first declaration.  Sorry for the noise.

FWIIW, I think the preferred approach for such cases is to
separate the declaration and initialisation. Something like:

	struct octeon_device *oct = droq->oct_dev;
	struct octeon_device_priv *oct_priv;

	oct_priv = oct->priv;