Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 22:51:58 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Pavel Pisa <pisa@cmp.felk.cvut.cz>,
        Ondrej Ille <ondrej.ille@gmail.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Martin Jerabek <martin.jerabek01@gmail.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] can: ctucanfd: Fix an error handling path in
 ctucan_probe_common()
Message-ID: <20230515-finisher-plating-8ab57747fea5-mkl@pengutronix.de>
References: <4b78c848826fde1b8a3ccd53f32b80674812cb12.1684182962.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="e2jyg7v42mrpg4qu"
Content-Disposition: inline
In-Reply-To: <4b78c848826fde1b8a3ccd53f32b80674812cb12.1684182962.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk


--e2jyg7v42mrpg4qu
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 15.05.2023 22:36:28, Christophe JAILLET wrote:
> If register_candev() fails, a previous netif_napi_add() needs to be undon=
e.
> Add the missing netif_napi_del() in the error handling path.

What about this path:
free_candev(ndev) -> free_netdev() -> netif_napi_del()

| https://elixir.bootlin.com/linux/v6.3.2/source/net/core/dev.c#L10714

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--e2jyg7v42mrpg4qu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmRim2sACgkQvlAcSiqK
BOjuAwf6A4GauV2RYDb0DKtBocZA6JCTFpxr+DJK7LK19G344FjrZMVvb9Tch5iO
Z280B9XDtr4dERafr3H5Eu7GxJVOvuI15TM09c1W4Rx5lpo4a7pUYnKrsmu8JAdX
2Jl8DCIF61Pzv+5HnFuefw8e+twXjmD3Htie4zFUVUeZ52Bm60+H5reYeMPxUOcV
P27GtPBrEx7N5tJjedlb+E2EqpqLRl3RCNgdpizUBGCoUZqlr7Hv2YXTcyet0SV/
wovJpqmyFDKT3k6r8rXFJuZMp4xBQZibGQJX3f6hYqF7C1QsXcriRUL5h6cRsFCh
jnY6LSzFQSrj7ca6rvFv67dmymX+Dw==
=WizN
-----END PGP SIGNATURE-----

--e2jyg7v42mrpg4qu--