Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d10da0ce-a22e-24e9-e895-fae4c3a35222@quicinc.com>
Date:   Mon, 15 May 2023 13:58:35 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets
 in catalog
Content-Language: en-US
To:     Marijn Suijten <marijn.suijten@somainline.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
CC:     Kuogee Hsieh <quic_khsieh@quicinc.com>,
        <dri-devel@lists.freedesktop.org>, <robdclark@gmail.com>,
        <sean@poorly.run>, <swboyd@chromium.org>, <dianders@chromium.org>,
        <vkoul@kernel.org>, <daniel@ffwll.ch>, <airlied@gmail.com>,
        <agross@kernel.org>, <dmitry.baryshkov@linaro.org>,
        <andersson@kernel.org>, <quic_jesszhan@quicinc.com>,
        <quic_sbillaka@quicinc.com>, <freedreno@lists.freedesktop.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1683914423-17612-1-git-send-email-quic_khsieh@quicinc.com>
 <1683914423-17612-2-git-send-email-quic_khsieh@quicinc.com>
 <4tmuqrz3du7pwwih3gzp6zveyfvwxj3meeksgxkbg2v5mdtyu3@e5xxuoe64rvv>
 <69538f77-ff08-c3ce-3d4a-9f7250ee2505@quicinc.com>
 <u47xthqfjxpbbzjbvnrz4qa2f2m3aip4iose7cwuhzg4raf7db@qxbos7u55wko>
From:   Abhinav Kumar <quic_abhinavk@quicinc.com>
In-Reply-To: <u47xthqfjxpbbzjbvnrz4qa2f2m3aip4iose7cwuhzg4raf7db@qxbos7u55wko>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/15/2023 1:07 PM, Marijn Suijten wrote:
> On 2023-05-15 11:20:02, Abhinav Kumar wrote:
>>
>>
>>
>> On 5/14/2023 2:39 PM, Marijn Suijten wrote:
>>> DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while
>>> the series is clearly aimed at 1.1...).  This was done for the DSC 1.2
>>> HW block patch after all.
>>>
>>> in catalog -> to catalog
>>>
>>> But it's just two platforms, you can fit MSM8998 and SC8180X in the
>>> title.
>>>
>>> On 2023-05-12 11:00:16, Kuogee Hsieh wrote:
>>>>
>>>> From: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>>>
>>>> There are some platforms has DSC blocks but it is not declared at catalog.
>>>
>>> Some platforms have DSC blocks which have not yet been declared in the
>>> catalog.*
>>>
>>>> For completeness, this patch adds DSC blocks for platforms which missed
>>>> them.
>>>
>>> Drop "this patch":
>>>
>>>       Complete DSC 1.1 support for all platforms by adding the missing
>>>       blocks to MSM8998 and SC8180X.
>>>
>>>>
>>>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>> ---
>>>>    drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |  7 +++++++
>>>>    drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 11 +++++++++++
>>>
>>> How about SC7180, and any other DPU 6.x revision?
>>>
>>
>> Will let kuogee respond to the other nits. There is no DSC in sc7180 /
>> sm6115 / qcm2290. So this patch is complete.
> 
> Thank you for checking as I didn't have the DTS close (and it seems
> SC7180 would have supported this, but no).  I did check other SoCs in
> the DPU 6.x range that are currently floating in my tree and on the
> list, which do need their DSC 1.1 block added (both a single block at
> 0x81000 downstream, 0x80000 upstream), if you can in a resend Konrad:
> 
> DPU 6.4 in SM6350: https://lore.kernel.org/linux-arm-msm/20230411-topic-straitlagoon_mdss-v3-6-9837d6b3516d@linaro.org/
> DPU 6.9 in SM6375: https://lore.kernel.org/linux-arm-msm/20230411-topic-straitlagoon_mdss-v3-8-9837d6b3516d@linaro.org/
> 

If these are still on the list, can Konrad add them to his change as 
that way his catalog change will be complete? Otherwise I would prefer 
to add them in a follow up change because marking this change as 
dependent on a catalog change which adds a new chipset is not right.

> Thanks!
> 
> - Marijn