Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230515174224.494631-1-afd@ti.com>
In-Reply-To: <20230515174224.494631-1-afd@ti.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 16 May 2023 00:08:32 +0300
Message-ID: <CAHp75Veu-HbANATV2trD=wAkNx4zia2L8Y+roLQ9k9VA_Vxu3Q@mail.gmail.com>
Subject: Re: [PATCH v3] gpio: sch311x: Use devm_gpiochip_add_data() to
 simplify remove path
To:     Andrew Davis <afd@ti.com>
Cc:     Peter Tyser <ptyser@xes-inc.com>,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 15, 2023 at 8:42=E2=80=AFPM Andrew Davis <afd@ti.com> wrote:
>
> Use devm version of gpiochip add function to handle removal for us.

...version of gpiochip_add() function...

...

> +               err =3D devm_gpiochip_add_data(&pdev->dev, &block->chip, =
block);
>                 if (err < 0) {
>                         dev_err(&pdev->dev,
>                                 "Could not register gpiochip, %d\n", err)=
;
> -                       goto exit_err;
> +                       return err;

With this applied you can consider a followup to have this be converted to =
use

    return dev_err_probe(...);

here and in other ->probe() related pieces.

>                 }

--=20
With Best Regards,
Andy Shevchenko