Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62d1ca89-7fe2-5435-c5c6-9158c58cb97e@starfivetech.com>
Date:   Tue, 16 May 2023 08:47:46 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v1 3/5] media: cadence: Add operation on reset
Content-Language: en-US
To:     Philipp Zabel <p.zabel@pengutronix.de>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <changhuang.liang@starfivetech.com>
References: <20230512102637.50917-1-jack.zhu@starfivetech.com>
 <20230512102637.50917-4-jack.zhu@starfivetech.com>
 <20230515144245.GA29284@pengutronix.de>
From:   Jack Zhu <jack.zhu@starfivetech.com>
In-Reply-To: <20230515144245.GA29284@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Philipp,

Thank you for your review!

On 2023/5/15 22:42, Philipp Zabel wrote:
> Hi Jack,
> 
> On Fri, May 12, 2023 at 06:26:35PM +0800, Jack Zhu wrote:
> [...]
>> @@ -299,6 +312,16 @@ static int csi2rx_get_resources(struct csi2rx_priv *csi2rx,
>>  		return PTR_ERR(csi2rx->p_clk);
>>  	}
>>  
>> +	csi2rx->sys_rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
>> +								    "sys_rst");
> 
> This doesn't match the bindings documented in patch 2.
> Should this be "sys"?

Yes, will fix it.

> 
>> +	if (IS_ERR(csi2rx->sys_rst))
>> +		return PTR_ERR(csi2rx->sys_rst);
>> +
>> +	csi2rx->p_rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
>> +								  "p_rst");
> 
> This doesn't match the bindings documented in patch 2.
> Should this be "reg_bank"?
> 

Yes, will fix it.

>> +	if (IS_ERR(csi2rx->p_rst))
>> +		return PTR_ERR(csi2rx->p_rst);
>> +
>>  	csi2rx->dphy = devm_phy_optional_get(&pdev->dev, "dphy");
>>  	if (IS_ERR(csi2rx->dphy)) {
>>  		dev_err(&pdev->dev, "Couldn't get external D-PHY\n");
>> @@ -349,14 +372,21 @@ static int csi2rx_get_resources(struct csi2rx_priv *csi2rx,
>>  	}
>>  
>>  	for (i = 0; i < csi2rx->max_streams; i++) {
>> -		char clk_name[16];
>> +		char name[16];
>>  
>> -		snprintf(clk_name, sizeof(clk_name), "pixel_if%u_clk", i);
>> -		csi2rx->pixel_clk[i] = devm_clk_get(&pdev->dev, clk_name);
>> +		snprintf(name, sizeof(name), "pixel_if%u_clk", i);
>> +		csi2rx->pixel_clk[i] = devm_clk_get(&pdev->dev, name);
>>  		if (IS_ERR(csi2rx->pixel_clk[i])) {
>> -			dev_err(&pdev->dev, "Couldn't get clock %s\n", clk_name);
>> +			dev_err(&pdev->dev, "Couldn't get clock %s\n", name);
>>  			return PTR_ERR(csi2rx->pixel_clk[i]);
>>  		}
>> +
>> +		snprintf(name, sizeof(name), "pixel_if%u_rst", i);
> 
> This doesn't match the bindings documented in patch 2.
> Should this be "pixel_if%u"?
> 

Yes, will fix it.

regards
Jack

> regards
> Philipp