Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bd4f84ff-640d-02bf-1abd-58bc8362edb8@amd.com>
Date:   Tue, 16 May 2023 08:15:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 0/9] perf/mem: AMD IBS and generic tools improvements
To:     peterz@infradead.org
Cc:     mingo@kernel.org, eranian@google.com, kan.liang@linux.intel.com,
        jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        leo.yan@linaro.org, kjain@linux.ibm.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com, Namhyung Kim <namhyung@kernel.org>,
        acme@kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230407112459.548-1-ravi.bangoria@amd.com>
 <CAM9d7cijvZBsaXTMm8d=sxUWy6s+umCCnWhunD3KVhKbpVp_-A@mail.gmail.com>
 <631876a2-5946-82d5-6f70-bf7734db3992@amd.com>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <631876a2-5946-82d5-6f70-bf7734db3992@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3I0VnNXeGhrNFNHeklnRnQ5bUtKbHZ1Z2VoaFI5Ym94ZFFZbjRqSnhwWGNY?=
 =?utf-8?B?enNXOGl1a0VJM2ZJc29laDlIZ09URTBLUmlSRk5jQ3RlYWFlbEJZaHFGVWFH?=
 =?utf-8?B?QXpwYm5XSFpjYTJHTUprY0FZVWVlYVFQZmNyZUdCbXAvT0ZUU1ovVDFZNWty?=
 =?utf-8?B?QjJWZ2pHYzh6TVhjK0xnTnowU2NFeC82Y05FRHptUzNBWDJmSmVFU2g2b2ov?=
 =?utf-8?B?WW5kNW9YckJZYkhTUktrRkJmb1daNkZSK3NHTld0OHZqbG9oVklvdnkydENw?=
 =?utf-8?B?RDBGN0tGdEE5NjRXdmxPRldSWTRtdFFBUnI3WWdUTDlXSzdid1R1TlZRMENP?=
 =?utf-8?B?WDNaNE1QdllwWEtLZjF4M0xSK1ZHSTBBMWIyNFN2MVhsWEpEL3hoYjVuaUF2?=
 =?utf-8?B?YVhtTDcrNkhoeDBBWjNRYWxSWDRTMjA1OG5lSlZPZjZJVG5rTkVPaEpEQkxL?=
 =?utf-8?B?bHFaYzQ0bHdQclh5emJQMjBNWjFqRFNVQ3I0Mzhkby91ZDlINUl2U0VRNDAr?=
 =?utf-8?B?SzJSZWZScTkrL1YxaHdNS1o0dTRBbUV4VzdWaytpM1VlVG1PYm5STnFMeFM0?=
 =?utf-8?B?dXduVjFCWWh4SXp1MDhzZFFPUFBkVU1vL1BYRmErRFM0UkFYYXE4V3drenlY?=
 =?utf-8?B?R09uTW1mNXFqOTU5TUlUaXFMZitlaXFYRXB2SEU3UG1odEFrMFkyelFVcWkx?=
 =?utf-8?B?YmFGeWJiNy9aeU9MUkxXR3VTSWNEUGh0QXpLZ0pVenpnVHlSQWs0amtjVm1M?=
 =?utf-8?B?NHpIM1ZWSXRCSjFjdkZCOSs5R0Y2ME1jcmlEOHNxUWVtbW5oaE11bzIwTm5J?=
 =?utf-8?B?TzVUcjRrcFl3d3hjOURkb1dJQjYvb1NsMzlGYjlLS2ZjVTUzdStiRGlWMTA1?=
 =?utf-8?B?czFJKzlMWjVSZWJaSXNqK2pZMWM5T1RKbWtqckVpMFgrSmk2ZSs4ektiU215?=
 =?utf-8?B?QlZhYXhYNGdsNHR4eUx2TDE3YVltWGhiaTYyWnVmMW9yMDNYVnNRSHdPbG5v?=
 =?utf-8?B?cFY2eUN4M01EQy9QdzlKTVIyRUtzY3preDlOWXU2aDdPZzJGQ1NHY2pMek1n?=
 =?utf-8?B?bG41VngwSFVSUEY4MGdTKzBrT1kwZHdzR2p4dDhjUlFTdmsvMytJRFI2VmVw?=
 =?utf-8?B?blJCT2EzWU9PSWFZdk51eW5nSmxUMy8zQlhhajR1bVVTeFR0Z3lIV0RUT2g2?=
 =?utf-8?B?NEN1NURBMytxQk5Dbk1kcmJwUGFiUjg3UVFWbGhQR0JXd3M1Q21RQnNLKy9l?=
 =?utf-8?B?eFlKZFNSR29uSm9lOC9yek9tQW1FY0RXOUVONndaQk02WUxGMjNRUlB3bVNw?=
 =?utf-8?B?T3RVWGR5OTdQT29OczFtTGxJajFmRjQ0L0cyOWYyNnhXUVowaG43UnJyV3cy?=
 =?utf-8?B?KysrMFlVbmJNZk9zYkRJNHlDb2FRTEVuWW82YVdySGtjMnFXd3R1MGZjdk1J?=
 =?utf-8?B?T1lTby9QYVZyZmN4VXlERzlUbStMbTNLMWhQUDhyTk5oUmdsUVFZaUpFUFVt?=
 =?utf-8?B?TnFNNElpcWloUFY1Tm5oNzNPSVkybm1vWDdkYllsM1BwT1lHbWRzMnZQM2pw?=
 =?utf-8?B?eG5KZjdEVC9uK0RJZHp5UlNva2FzS29IUVF1bUh6RkR3cE0rWmpXUk5PcjZx?=
 =?utf-8?B?dXp0UXJmc3c1WmFrTXNGNzhISkJPUXExclFRTGF5WHdyTzY1czZuUUNXN29D?=
 =?utf-8?B?TXZ3TVJNd2x6Y3hpKzc3c0RVdlJ0aE1JTHdEcy83RzMxWnFsSTM1WmhzVnhL?=
 =?utf-8?B?Um1LQ1hBcm1RejlBTkY1MkZ4L0hpU2oxNWsrMUx1UzAxYi9obzZIZEhOUW8x?=
 =?utf-8?B?ZS9WOWFpUnVSUXNJRUcxLzZpZ2NubkFQQTMzdjl2bmxzUmgwMmVncW1FcXZs?=
 =?utf-8?B?QnJ2TS9LdFoyNUUvQkZEcXpoVlVxZjVHRGpsSndWeDdzeWhadEJHODRhRUVC?=
 =?utf-8?B?eFFWWDIwTmN6eERsQmxwaFlGWWtNdVdlQ2RTblhZUHRPNkhrdmZ0WkNnSldL?=
 =?utf-8?B?ZGo2ejhTTHNndGlybytCbzF0K2FKUG9rZGdKNnRZZnJ4K0FucmQwbTNPaTVm?=
 =?utf-8?B?SjUwSGVpUUlHNGlsUGY5RjJTdi9zRGxIK3NhQ0gzcFBWUWlzUUpGaXlvdHdK?=
 =?utf-8?Q?jUuCXvtN0lywh4+KMHzlea9Xw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a85f68ca-7ec6-4702-7a65-08db55b7cbcf
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 02:46:49.4295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kahN1tfeRZ1XkfwdW7PMOKKPcZzxeEh+dJBz2okUW8HgP6lZdM7+d+AvSJj3oIl1fEwZZ/CjHzgwYizG4acRHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4237
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10-Apr-23 7:53 AM, Ravi Bangoria wrote:
> On 08-Apr-23 3:14 AM, Namhyung Kim wrote:
>> Hi Ravi,
>>
>> On Fri, Apr 7, 2023 at 4:25 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>>>
>>> Kernel IBS driver wasn't using new PERF_MEM_* APIs due to some of its
>>> limitations. Mainly:
>>>
>>> 1. mem_lvl_num doesn't allow setting multiple sources whereas old API
>>>    allows it. Setting multiple data sources is useful because IBS on
>>>    pre-zen4 uarch doesn't provide fine granular DataSrc details (there
>>>    is only one such DataSrc(2h) though).
>>> 2. perf mem sorting logic (sort__lvl_cmp()) ignores mem_lvl_num. perf
>>>    c2c (c2c_decode_stats()) does not use mem_lvl_num at all. perf mem
>>>    prints mem_lvl and mem_lvl_num both if both are set, which is ugly.
>>>
>>> Set mem_lvl_num, mem_remote and mem_hops for data_src via IBS. Handle
>>> first issue using mem_lvl_num = ANY_CACHE | HOPS_0. In addition to
>>> setting new API fields, convert all individual field assignments to
>>> compile time wrapper macros built using PERF_MEM_S(). Also convert
>>> DataSrc conditional code to array lookups.
>>>
>>> Interpretation of perf_mem_data_src by perf_mem__lvl_scnprintf() was
>>> non-intuitive. Make it sane.
>>
>> Looks good, but I think you need to split kernel and user patches.
> 
> Patch #1 to #3 are kernel changes. Patch #4 to #9 are userspace changes.
> Arnaldo, Peter, please let me know if you wants to split the series and
> resend.

Hi Peter, tools/ patches are already upstream. Can you please pick up
kernel changes.

Thanks,
Ravi