Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 11:01:38 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>
CC:     <kvm@vger.kernel.org>, Jiaan Lu <jiaan.lu@intel.com>,
        Zhang Chen <chen.zhang@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        "Paolo Bonzini" <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 02/11] KVM: x86: Advertise CPUID.7.2.EDX and
 RRSBA_CTRL support
Message-ID: <ZGLyEhKH+MoCY/R4@chao-email>
References: <20230414062545.270178-1-chao.gao@intel.com>
 <20230414062545.270178-3-chao.gao@intel.com>
 <a88b2504-b79b-83d6-383e-a948f9da662b@intel.com>
 <ZGLkvlx5W0JStTjD@chao-email>
 <9c75663c-6363-34e7-8341-d8f719365768@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <9c75663c-6363-34e7-8341-d8f719365768@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?61i98dhUVBMx3z8zWZbX3R9s8tCdMNEdoKhii0hgJrh/US/ydAuCm+sBdJwF?=
 =?us-ascii?Q?wp+zZ2Rp+sH1yzLIGdFVPcsDSM0I9KsUoambCejaiJaUwEFeMfDswICXtSIQ?=
 =?us-ascii?Q?kj2gTxOQpKW+f+xvmBJvJJXSJ8pwXNciFm1qvygBY6dCQQN4eMxxjTBarUpQ?=
 =?us-ascii?Q?Ob/XSeZJ7Ha6obVMldSCAYR94EknHNXQtyimwbMEMOGv277ORPIt/1CKxRl1?=
 =?us-ascii?Q?5hw7lkIxg8duO5FOeDPAcd+k+zz7TMC3So9nmoi1zA/xZOTF/hnRGn2z543i?=
 =?us-ascii?Q?OkgrHGD7dVA7eKr1ph63HpP43Tmn8OAQKmXK/HtC4weVQHq6zI2MROYQsd6j?=
 =?us-ascii?Q?VUddTGUIb+jaD5IJ0UL3r9qS04G8NrGX6D3Tk6taG+nXFw1M60v7uVpwtzAp?=
 =?us-ascii?Q?IscivYgeADqGEXTHMoBgrnkATUGd1vZTzF6KLKCJOBWRFlShofQLGssO9tBL?=
 =?us-ascii?Q?L52ri90/4eApXixk7xAsNedtOZNZnptRadNapKVpitVZ40cr+eOIhvxO7+fU?=
 =?us-ascii?Q?JEkPkAhpe4iner/F15EKvmKJb2AMjIczfNX2F990sOVLyq7C861rfUDNax5Y?=
 =?us-ascii?Q?MnfLiwsq3GH10SGEJ7PQJhwzQik0+uBomjBIYxLN5RMtM2PwEjfwVmMOc2hg?=
 =?us-ascii?Q?mrRBSmCdV2Iz/fPzjC4vLyt9LQtd5fBb8Fs/RYH2sEIZ0iJxQYiSgX2CiT4e?=
 =?us-ascii?Q?xO6QuSgXcOJ9ju6M4IELtFP1ACHQbExJ6/lKh2nvwdKA7i3fRTZZ8UMFns14?=
 =?us-ascii?Q?HPpEg5agzti/K3xLbUm5IUW+yvCPFNkDwPZUx4rrY1JrmjXqsC5xACvSDa8f?=
 =?us-ascii?Q?IRPP12VTysyvLdnBtbhiympXCYLOwKoEx7q7jAnPpboBruFXecJt1+DKGghL?=
 =?us-ascii?Q?8izjJNYtDHTP0CUP/F5Yy/vdu1oFNMmQZ+bzaZ+3M5bMF1Df6oLmLFdv7yff?=
 =?us-ascii?Q?04BOw6rdIKJWf+S5qQ0GLOZuCK63qp0aFh5Q9BXPu6+CBG/ZFOoY54zluT8y?=
 =?us-ascii?Q?QKCmAjWOBuOckCgS/StdMN5byrDdmumvwTKbvIJKSe2Bh5Dje5J6szot75ZD?=
 =?us-ascii?Q?NHFlkZuzVghiyz8a15NW10VbVV0YeIUp3t73/llS1GCpWxvTLMuvZ7DqVH8w?=
 =?us-ascii?Q?N4wSwjuuDPU2+NWRcqMOdRxqJjZt0XNJgBcHWXk7kIi8VMMpfmp6FQcVTHBz?=
 =?us-ascii?Q?2t7AjLMGuhM9c+YYU1yLvKrNjmsb+OLFpe9mMuec6yR6xLDNxJaP59/AoJdy?=
 =?us-ascii?Q?7e7oMYRvUzCdTUveDs6kVrU5PnCa8s1JaQK2fCHrDbYjcgK3v1AWlZZrjDOj?=
 =?us-ascii?Q?xfCX0hIF79Mrnau3FoG8sK6f7o6z9LKL2Uz4+RNtKivlOe0zqIvvpqBwAU9N?=
 =?us-ascii?Q?n/UOxrWbDMkz0+oTp6fAAqjFvVPItG3UvdFYtudWUmFVivVegW/iD1zsqbYd?=
 =?us-ascii?Q?3ekJ/Z10rUtgfCgkNmJ/OUjMLhv6sTbs978xZVjUGrLTlY6KEpiHlJSzwfx3?=
 =?us-ascii?Q?tdbmIfKFAFZ9UvkZ9ZrOGkW79dGsyKivrWZsOLxfUbCLPo0AJJcG9LFRh5O7?=
 =?us-ascii?Q?S5FNdaemiVW2EC6cKtvOTmvWZCrQHb0matjO+Su2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e4ea99e1-0993-436b-cb35-08db55b9e4ea
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 03:01:50.2830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2WQwXcLhVxrrhfKcgLPBkhwi+CtfrBc9swVN+kWHwBUS7woRxqrG7Ad7/wN16Dbd2+RJSn3dAL9N2XmSyB2xZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5812
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 16, 2023 at 10:22:22AM +0800, Xiaoyao Li wrote:
>> > I think we need to fix this bug at first.
>> 
>> I have no idea how to fix the "bug" without intercepting the MSR. The
>> performance penalty makes me think intercepting the MSR is not a viable
>> solution.
>
>I thought correctness always takes higher priority over performance.

It is generally true. however, there are situations where we should make
trade-offs between correctness and other factors (like performance):

E.g., instructions without control bits, to be 100% compliant with CPU
spec, in theory, VMMs can trap/decode every instruction and inject #UD
if a guest tries to use some instructions it shouldn't.