Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 12:40:50 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>,
        kernel test robot <yujie.liu@intel.com>,
        Olivier Dion <odion@efficios.com>,
        <michael.christie@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Feng Tang <feng.tang@intel.com>,
        John Hubbard <jhubbard@nvidia.com>,
        "Jason Gunthorpe" <jgg@nvidia.com>, Peter Xu <peterx@redhat.com>,
        <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: Move mm_count into its own cache line
Message-ID: <20230516044050.GA315678@ziqianlu-desk2>
References: <20230515143536.114960-1-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230515143536.114960-1-mathieu.desnoyers@efficios.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VtJZrh/D9+hKyKJq3XzEhJyJf4joz4tj/VXQ55vvR6s06Yt80aWY7t3/RZOV?=
 =?us-ascii?Q?QQXL1k47nG/Vn8wvpLz3AWvjKG5uypMyMNcrKh79PYgJ5rRCgCk18GVJJMz9?=
 =?us-ascii?Q?3EoEWJjN+ZhtKFmP7WUlIWm1PQunvQPeHktZpeG1wj+rKQ7R0fBxRNeUNKHX?=
 =?us-ascii?Q?IfNYhnuqVHEGtvxjcrqOut+9panFUJOOQ+P7CPwvBjpuWNq8GJHeZZAFnnKX?=
 =?us-ascii?Q?GOKJR+ZcIRJIvZR01Q2I3muxO24TDm9Ph0Uvn4W772pD58t/5OvlJPXRNPwR?=
 =?us-ascii?Q?NNK4UbIlTRqdHFOXGqX/Hrj5VlFaEcK02+NCx3XZqu0vNFxeBNqfEKE3ZyXO?=
 =?us-ascii?Q?PZdJdfp/WMrZzu4odXPetXRFQciGza7Du3p5CpHai8vmi8nSN6cI5pYdPxew?=
 =?us-ascii?Q?JFkrGEfJ4DVEGJYQPXyXR3GAdVpCTIV2VObSSUB/9XKWnzhuLvlNqQtsLF5D?=
 =?us-ascii?Q?goii9rdL4SJmzXGCbvI1o7BHdo1eGBYdJBcnft5lRunDWYXZK9VPp82KiUYm?=
 =?us-ascii?Q?d3/o/Rxv7PtxqwGATidRIdEXXazXkoxy8KISO5ZpOH5ZzuP8dTs5ouP4ypcP?=
 =?us-ascii?Q?JsOFy4bYk527w6P+tY0IC5JEM19f8dcmbszlR3Vqfgihs5XbC4t4m9YPk0Oj?=
 =?us-ascii?Q?VEW4AqXvmstUM+y7OLQCl+zuvnRga129kWo0qVFF84iIM/SPFeI7L/QOcHC3?=
 =?us-ascii?Q?mw8WL6WID1TzlzRuO4+NNGI4cD/HK52R/4Dm6WfykZcCrqocvbyQMDt9tDYt?=
 =?us-ascii?Q?M3Hu4amgofMF5ZzHTFKKCXopMpWSi0NHwz3iorCT4QNwSrsGhsNxIh63HkiF?=
 =?us-ascii?Q?dME24IEdlPfVoS/3sDyWRK3tPw9gytJPxps+jOLXSPM1AARalKlIpg3mnwCH?=
 =?us-ascii?Q?Bp6LpLJ0c3AGbMzp3r9dneaNPQWl9BQmpMnnH961wtoqf1yYSjrwTJWmj/G3?=
 =?us-ascii?Q?q5sOYbIVhrZjcnU0pRAPeAlsvSD7hH5KWd74elSonitymKKGdynyC01JPYDM?=
 =?us-ascii?Q?VkTKIaSV8bNTg6YomUDenADhqOTwiGI5uCsXdusKDEtJtJqGNGgACHsW7JbZ?=
 =?us-ascii?Q?MzClymawXMgpcWhO5QMZa5CSfDFTTzgskpKOvDd0UEgo3bVXzKk1kImlxHai?=
 =?us-ascii?Q?I2nje2n9IJY2Lq++6/MlC/Qizyhts9SJNCspc2aE+0ygzSrW7coYfhlYsv5w?=
 =?us-ascii?Q?nBWZZweeCA8eg4Q3ssofNRDccf787SldoDMzbS44IFDZTDtFLz87inXFvNLS?=
 =?us-ascii?Q?aXC63GV+YpFNPbMa/Yd2hZ36xclGOBAHUlwlIOlmyi+2y3J70+bfcl750bcK?=
 =?us-ascii?Q?Du1jBK/c7U9hnQhAUfgLC8vkOrzYX2YXgNv9SI2HOnUl2iLk2TZitd/JGMeZ?=
 =?us-ascii?Q?p62kXua3uhvGSK2iErPENjjY+tHfhIvJC9NBO4FQrTBxI866/ZjfN1Q39Pwo?=
 =?us-ascii?Q?i/NgaqPKAjzwDkUQZ8H5nTL9o3egWczsakXzoc3+k4MNhiuNA5RWdCkXYD01?=
 =?us-ascii?Q?azHkaOASDIMxDtFdWGbcwMeXjrUHPgK0FLTxfpXH5A8lriMM94MxKxUunUyg?=
 =?us-ascii?Q?fqFkmZW9gR0pRonqnCVFDIf5knDJ1EtXD7ztk6Yz?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 273ed542-c9da-4e5e-3500-08db55c7c126
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3062.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 04:41:03.3121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rSkxW9q9GlJuM059XaEbIW6oXzNzitDT1u7P4c3fdtSntVU0Vcqgtx/yPFqbs8OSwW/MRvuPl5AFAGxQCgFWSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6283
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 15, 2023 at 10:35:36AM -0400, Mathieu Desnoyers wrote:
> The mm_struct mm_count field is frequently updated by mmgrab/mmdrop
> performed by context switch. This causes false-sharing for surrounding
> mm_struct fields which are read-mostly.
> 
> This has been observed on a 2sockets/112core/224cpu Intel Sapphire
> Rapids server running hackbench, and by the kernel test robot
> will-it-scale testcase.
> 
> Move the mm_count field into its own cache line to prevent false-sharing
> with other mm_struct fields.
> 
> Move mm_count to the first field of mm_struct to minimize the amount of
> padding required: rather than adding padding before and after the
> mm_count field, padding is only added after mm_count.
> 
> Note that I noticed this odd comment in mm_struct:
> 
> commit 2e3025434a6b ("mm: relocate 'write_protect_seq' in struct mm_struct")
> 
>                 /*
>                  * With some kernel config, the current mmap_lock's offset
>                  * inside 'mm_struct' is at 0x120, which is very optimal, as
>                  * its two hot fields 'count' and 'owner' sit in 2 different
>                  * cachelines,  and when mmap_lock is highly contended, both
>                  * of the 2 fields will be accessed frequently, current layout
>                  * will help to reduce cache bouncing.
>                  *
>                  * So please be careful with adding new fields before
>                  * mmap_lock, which can easily push the 2 fields into one
>                  * cacheline.
>                  */
>                 struct rw_semaphore mmap_lock;
> 
> This comment is rather odd for a few reasons:
> 
> - It requires addition/removal of mm_struct fields to carefully consider
>   field alignment of _other_ fields,
> - It expresses the wish to keep an "optimal" alignment for a specific
>   kernel config.
> 
> I suspect that the author of this comment may want to revisit this topic
> and perhaps introduce a split-struct approach for struct rw_semaphore,
> if the need is to place various fields of this structure in different
> cache lines.
> 
> Fixes: 223baf9d17f2 ("sched: Fix performance regression introduced by mm_cid")
> Fixes: af7f588d8f73 ("sched: Introduce per-memory-map concurrency ID")
> Link: https://lore.kernel.org/lkml/7a0c1db1-103d-d518-ed96-1584a28fbf32@efficios.com
> Reported-by: kernel test robot <yujie.liu@intel.com>
> Link: https://lore.kernel.org/oe-lkp/202305151017.27581d75-yujie.liu@intel.com
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Reviewed-by: Aaron Lu <aaron.lu@intel.com>