Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230512064655.82246-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20230512064655.82246-1-yang.lee@linux.alibaba.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Tue, 16 May 2023 09:50:28 +0300
Message-ID: <CAFCwf139EwbAnhf4RJXxLmxPA4gZGjrMNCJv55muncBMMp8BAA@mail.gmail.com>
Subject: Re: [PATCH -next] habanalabs: Fix some kernel-doc comments
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 12, 2023 at 9:47=E2=80=AFAM Yang Li <yang.lee@linux.alibaba.com=
> wrote:
>
> Make the description of @regs_range_array and @regs_range_array_size
> to @user_regs_range_array and @user_regs_range_array_size  to silence
> the warnings:
>
> drivers/accel/habanalabs/common/security.c:506: warning: Function paramet=
er or member 'user_regs_range_array' not described in 'hl_init_pb_ranges_si=
ngle_dcore'
> drivers/accel/habanalabs/common/security.c:506: warning: Function paramet=
er or member 'user_regs_range_array_size' not described in 'hl_init_pb_rang=
es_single_dcore'
> drivers/accel/habanalabs/common/security.c:506: warning: Excess function =
parameter 'regs_range_array' description in 'hl_init_pb_ranges_single_dcore=
'
> drivers/accel/habanalabs/common/security.c:506: warning: Excess function =
parameter 'regs_range_array_size' description in 'hl_init_pb_ranges_single_=
dcore'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D4940
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/accel/habanalabs/common/security.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/common/security.c b/drivers/accel/h=
abanalabs/common/security.c
> index 297e6e44fd0c..dc23ff57c91a 100644
> --- a/drivers/accel/habanalabs/common/security.c
> +++ b/drivers/accel/habanalabs/common/security.c
> @@ -495,8 +495,8 @@ int hl_init_pb_single_dcore(struct hl_device *hdev, u=
32 dcore_offset,
>   * @instance_offset: offset between instances
>   * @pb_blocks: blocks array
>   * @blocks_array_size: blocks array size
> - * @regs_range_array: register range array
> - * @regs_range_array_size: register range array size
> + * @user_regs_range_array: register range array
> + * @user_regs_range_array_size: register range array size
>   *
>   */
>  int hl_init_pb_ranges_single_dcore(struct hl_device *hdev, u32 dcore_off=
set,
> --
> 2.20.1.7.g153144c
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Thanks,
Oded