Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 09:09:06 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 2/3] leds: simatic-ipc-leds-gpio: split up into
 multiple drivers
Message-ID: <20230516090906.0d7c6058@md1za8fc.ad001.siemens.net>
In-Reply-To: <ZGKnCmPbAw17R+sn@smile.fi.intel.com>
References: <20230515150352.30925-1-henning.schild@siemens.com>
        <20230515150352.30925-3-henning.schild@siemens.com>
        <ZGKnCmPbAw17R+sn@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uIQ4RIv2DWB9Cr1ue03mbK5pALnOMu18ZA5J+pI0uX7TwOs62xWSXYXmFNH2?=
 =?us-ascii?Q?yuE5AN/2ckZp5xMzMDrW04LTo4D3xrn35mXBcS3/u8m9I32qGGxzT8gYE7N5?=
 =?us-ascii?Q?dschChvh3Bh6kh25OyVVToJvH6F4PtKsMl8PvpRQUV1N6Vj8E016CFQAJH+l?=
 =?us-ascii?Q?TI875MGCfROYJbwpkhi7jE9Cg7JJtiSlYkNkmRBBugckyWXC9e/jOH2xLm6J?=
 =?us-ascii?Q?csbvkTTh94yeL4R0PrUIIwAX4PQFQ0ZHTeYDtAZzr50L3opQo7k+GcIE6Vq9?=
 =?us-ascii?Q?/nFGBg/33ysfkcbQm5qzubEnA+KzSgl1v9PY7PPLKwNWSCnG3idxGrRLVb33?=
 =?us-ascii?Q?VqnVxm1pi6J0tSMsO2ay95CVASHiP7Ya5jgvGqiBD3iFV9h6clrNEqRNQc3U?=
 =?us-ascii?Q?5Vc/28zSvV+Yq30o/r6Yd9hKMMpt6fPBC9GFvUdTMsu7/mLe4duXvm9nBsYq?=
 =?us-ascii?Q?3hFVT5pLQTXTkEfcwJQdp7Up+WEX1csddi+fwYNtTgSJab8yYUK9ANZzOp6k?=
 =?us-ascii?Q?AhtPpeulbcmhm5uG0jKKleogQyw5gqRnoZxuNaWuWK9W8eJAeeqRYppM7ay7?=
 =?us-ascii?Q?te6/vkIZV/z3JsHggeZzbkJGlHWevK1qvqdJ6CHbRydJIr8RCOZn6Oyr6xug?=
 =?us-ascii?Q?ykQhzoFp9lUOtVNEE49rMuC/qlp5lglH3yvMjJ7WoUbjrDQvC0SoURKFhIEI?=
 =?us-ascii?Q?JG4h+4dJczFOaFhKEpll1ZYcr3hp3megwmSxTZtP+2kz0Kv2+MdT6lfjO2SZ?=
 =?us-ascii?Q?+Vx8iUp8Pq/XxiavbpmpZ86GY5yUg5ilj8WhORl7H+XGntbhZLegnNVUHDsN?=
 =?us-ascii?Q?d5t0EZw8wfEgCXvtTNz/tk5zutJaKnczHdji9YkuROnSkP5FbyLybDTQ4DrC?=
 =?us-ascii?Q?gz3e2OC1DeZa5qDNvrw1wzIH6JHat8DiQoXCtFCl3U0q2euQLSex/DlI5VM1?=
 =?us-ascii?Q?FwFtd2xGx6tNiLBR7jZp24w95jKF9N9UIP2LxUoaI5/1Zq/oYld626Vu6pRS?=
 =?us-ascii?Q?wsu3LSUIDHV9/LG9ld8F8s6vXPcEsUVBS11MkuXifmz3r0+nJ+5mbipAZml9?=
 =?us-ascii?Q?s24eG+8ZTL48RrlAJwGOMeai7nVQyGtciMj0yWFGQy3TDoHrSK9dOPAuqouK?=
 =?us-ascii?Q?XKYZU4+Um+5NgFZXyLz0zkvOb6XHoi5uywXLy6yNC6oQlO/j+8OuQQWGoIsg?=
 =?us-ascii?Q?8H5cBjY5G2mjnfTWDpqsrXVUXHdoU2iFSXGwy7+yFrEwLDPMXWOogW9LnPgI?=
 =?us-ascii?Q?mQYnGgqqTJGGeWvsmviThe7YeqdcDUe6uoTE1PKYXBWJ7+X5dLsE/QCykJy9?=
 =?us-ascii?Q?+j4rDvp5a37RwYyUDEwp6rgTHXf0JSnu1j+ScTPQXMLQM9h8vdggLLjrEsyB?=
 =?us-ascii?Q?xsbJxXF2b+0F37ZjS6MpYSJLeBUQud6ViDoPKTH66jpo7j4TPCN5EoEx+S+U?=
 =?us-ascii?Q?K/GKocF9TKrgi6HKLmuNcUGPsjD0JqZ/YrdA6DlkU38bKAnt++DD0Fv2AEdx?=
 =?us-ascii?Q?SfUvpq4oy1sf2K5PrrXrnxrYxoXIMl3Qkg7YBvlgM+hEho/Q/SK2t5Hd+bGX?=
 =?us-ascii?Q?eNOK6fS27oSWEQ1nAnU0BN0rL8MdvJqXhQ6DWFSfMK9RxCfjMDAPyATSFut+?=
 =?us-ascii?Q?tz9YNFOp/TMpPR/63vQe34v0wXDGsRKy5SvX96lyfkAAjg4RKZVqQMrlVguL?=
 =?us-ascii?Q?6B7Abw=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23e48f4d-bfed-4094-5f6d-08db55dc72a9
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 07:09:11.0706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qihEVTTZDGf2Dv9sIRapX0ws84TBtcY4nzB8+QZ9istcyxif2w9hZxuyrMi/HmER6L6u560ywrcFY2jeXw7pLoclu+29spkMM1X/6KOSgv8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7501
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Tue, 16 May 2023 00:41:30 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Mon, May 15, 2023 at 05:03:51PM +0200, Henning Schild wrote:
> > In order to clearly describe the dependencies between the GPIO
> > controller drivers and the users the driver is split up into a core,
> > two drivers and a common header.  
> 
> AFAIU the GPIO lookup tables need a terminator entry.

They never had one in the first place and that worked, i did not add
terminators here and that also works. My guess is that .num_leds =
ARRAY_SIZE(simatic_ipc_gpio_leds) tells "leds-gpio" how many entries
there are. (another array without a terminator)

But i will add them in a v4 so things are explicit and aligned with
other similar drivers.

Henning