Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 08:12:10 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Alexandre Ghiti <alex@ghiti.fr>
CC:     Randy Dunlap <rdunlap@infradead.org>,
        Robin Murphy <robin.murphy@arm.com>,
        <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>, <iommu@lists.linux.dev>,
        Conor Dooley <conor@kernel.org>,
        <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] iommu: PGTABLE_LPAE is also for RISCV
Message-ID: <20230516-gristle-spill-e27c58770a47@wendy>
References: <20230330060105.29460-1-rdunlap@infradead.org>
 <2529dd93-2cb2-6ed8-20c0-c424e6613717@arm.com>
 <833203b0-aee5-eb23-afb4-ff71a3024258@infradead.org>
 <280c0994-f7cd-bb0e-8c68-62f72a4a38ca@ghiti.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="kEpcCnhkORFemaUM"
Content-Disposition: inline
In-Reply-To: <280c0994-f7cd-bb0e-8c68-62f72a4a38ca@ghiti.fr>
Precedence: bulk

--kEpcCnhkORFemaUM
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 16, 2023 at 09:02:50AM +0200, Alexandre Ghiti wrote:
> Hi Randy,
>=20
>=20
> On 3/30/23 18:49, Randy Dunlap wrote:
> >=20
> > On 3/30/23 09:34, Robin Murphy wrote:
> > > On 2023-03-30 07:01, Randy Dunlap wrote:
> > > > On riscv64, linux-next-20233030 (and for several days earlier),
> > > > there is a kconfig warning:
> > > >=20
> > > > WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LP=
AE
> > > >  =A0=A0 Depends on [n]: IOMMU_SUPPORT [=3Dy] && (ARM || ARM64 || CO=
MPILE_TEST [=3Dn]) && !GENERIC_ATOMIC64 [=3Dn]
> > > >  =A0=A0 Selected by [y]:
> > > >  =A0=A0 - IPMMU_VMSA [=3Dy] && IOMMU_SUPPORT [=3Dy] && (ARCH_RENESA=
S [=3Dy] || COMPILE_TEST [=3Dn]) && !GENERIC_ATOMIC64 [=3Dn]
> > > >=20
> > > > and build errors:
> > > >=20
> > > > riscv64-linux-ld: drivers/iommu/io-pgtable-arm.o: in function `.L14=
0':
> > > > io-pgtable-arm.c:(.init.text+0x1e8): undefined reference to `alloc_=
io_pgtable_ops'
> > > > riscv64-linux-ld: drivers/iommu/io-pgtable-arm.o: in function `.L16=
8':
> > > > io-pgtable-arm.c:(.init.text+0xab0): undefined reference to `free_i=
o_pgtable_ops'
> > > > riscv64-linux-ld: drivers/iommu/ipmmu-vmsa.o: in function `.L140':
> > > > ipmmu-vmsa.c:(.text+0xbc4): undefined reference to `free_io_pgtable=
_ops'
> > > > riscv64-linux-ld: drivers/iommu/ipmmu-vmsa.o: in function `.L0 ':
> > > > ipmmu-vmsa.c:(.text+0x145e): undefined reference to `alloc_io_pgtab=
le_ops'
> > > >=20
> > > > Add RISCV as an allowed ARCH dependency to fix these problems.
> > > >=20
> > > > Fixes: d286a58bc8f4 ("iommu: Tidy up io-pgtable dependencies")
> > > BTW that doesn't look like the right fix target - this presumably dat=
es back as far as when ARCH_RENESAS was added to RISCV, such that it was po=
ssible to start selecting IPMMU_VMSA without COMPILE_TEST?
> > OK, I can go with that. Thanks for your help.
> >=20
>=20
> Any updates on this fix?

Superseeded by
https://lore.kernel.org/linux-iommu/20230330165817.21920-1-rdunlap@infradea=
d.org/

I guess that never went anywhere?


--kEpcCnhkORFemaUM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGMsygAKCRB4tDGHoIJi
0vOKAQCLR9m9tYztuGYjhMQ0trXZPKE2Y8xVwNtfr5jJy14lRgD/WEmttGELpMve
zitK847mqPuq6YE2XnjnZvsdGcD6cAc=
=WJ81
-----END PGP SIGNATURE-----

--kEpcCnhkORFemaUM--