Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ff3c537ada67e27823d7605686ef0b5c05c13ab5.camel@redhat.com>
Subject: Re: [PATCH net-next 2/7] net: lan966x: Add support for offloading
 pcp table
From:   Paolo Abeni <pabeni@redhat.com>
To:     Piotr Raczynski <piotr.raczynski@intel.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        UNGLinuxDriver@microchip.com
Date:   Tue, 16 May 2023 09:07:35 +0200
In-Reply-To: <ZGIGkZDW84tHr04f@nimitz>
References: <20230514201029.1867738-1-horatiu.vultur@microchip.com>
         <20230514201029.1867738-3-horatiu.vultur@microchip.com>
         <ZGIGkZDW84tHr04f@nimitz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-05-15 at 12:16 +0200, Piotr Raczynski wrote:
> On Sun, May 14, 2023 at 10:10:24PM +0200, Horatiu Vultur wrote:

[...]

> > +static int lan966x_dcb_ieee_setapp(struct net_device *dev, struct dcb_=
app *app)
> > +{
> > +	struct dcb_app app_itr;
> > +	int err;
> > +	u8 prio;
> > +
> > +	err =3D lan966x_dcb_app_validate(dev, app);
> > +	if (err)
> > +		goto out;
> > +
> > +	/* Delete current mapping, if it exists */
> > +	prio =3D dcb_getapp(dev, app);
> > +	if (prio) {
> > +		app_itr =3D *app;
> > +		app_itr .priority =3D prio;
> Compiles OK, still looks little weird :).

Since it looks like a v2 is required to update later patches, please
additionally remove the unneeded whitespace above:

		app_itr.priority =3D prio;

Thanks!

Paolo