Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp283496rwd; Tue, 16 May 2023 00:38:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ68TVdLj9iGitWmPvoLlxSuvchxazTsBcjl4g9ftnyM+BnS7vSZN1ws+VKvABgvwx/be1cy X-Received: by 2002:a17:902:d2c2:b0:1ac:5dfa:3545 with SMTP id n2-20020a170902d2c200b001ac5dfa3545mr39852978plc.68.1684222704849; Tue, 16 May 2023 00:38:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684222704; cv=none; d=google.com; s=arc-20160816; b=W99eS7Juk/jNw0Vmg0F5DcpQMxOnMLVWpgeq5xWY08Q4z1rj+lWAvS08C6qr+0Koct T3y2tVFIlU5rafnp23NmEjjwdd5rAhoOIKt2HZe+VjzImdDGE+rfUt8HX7R9sHmcVk4s OCsU08LBW1pNcqf6aKDNXQDbcqYJ/RFYGX3HV46GjfgPPDh9QALD/DknA5SSkoqeizy7 Wl5bOB75ejoY/fdqe2sz7K7jdFKeeJrl6Ptb0VUPuANGvoyoy/+BhbGF/3N6JrRWGPcc Ji/HBWqPKRiD/ViZJCVt0GmwEoVxMjiSWwgH/rSKGgK3cf5PoXqEYl/jUPNwUkG7wDib tTAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:references:cc:to:content-language:subject:reply-to :from:user-agent:mime-version:date:message-id:dkim-signature; bh=YDM/0KI2jSc6jBFtRefPfdCkyTGKEYZyqTibHMCF2h8=; b=z1skqWK4Yw9+rZwpTlq8UxCE37oYcJURBx1HpZIG3ddR2PDrxQUqg2dS47JxvJZQuy Or0Sp0MOOqZ+IjjlfESDMltJLwbIQDiQ3O0jOPpjIazpE5WJ83SF+M8dEu1132OdCWn5 o4P3II5y9rq/QqyTMeyy1Gas7GMrL+NV6zKGYsNNmGi0xNTMpv5PeTGIwF1ItlFKFJxw nV2MDfKORAkhdG9QTaCi5vqzUnVltYXT0tOcJIJR9iZfoN1i+JXZJEZiQwwxVgWxbeTB Byul9UGmKG1Tfi3dx5Pxmi6FHX5Dzd2NIX34QzupZbQM9KCcck66mE/EfeAsOBkseMS/ Uuuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vpwnD6FR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a170902ea0c00b001adbf6684f8si14485120plg.408.2023.05.16.00.38.10; Tue, 16 May 2023 00:38:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vpwnD6FR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbjEPHY7 (ORCPT + 99 others); Tue, 16 May 2023 03:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbjEPHYp (ORCPT ); Tue, 16 May 2023 03:24:45 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D34A744AB for ; Tue, 16 May 2023 00:24:39 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f450815d0bso71211265e9.0 for ; Tue, 16 May 2023 00:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684221878; x=1686813878; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=YDM/0KI2jSc6jBFtRefPfdCkyTGKEYZyqTibHMCF2h8=; b=vpwnD6FRg4uTYZCT1VlLgshN/K2Dc49iQQpokmPlFPbT/hBx47tfXOn8p4WTCc/xl/ 91VSV4Ojwo1xmBhpmNRJU+GNYiDXE77XEXVlQqJvGPYpZIwuG2iO7sT8gc/ss8UWeUDC bQ3y/x10oZUUhjvSOhLucr7ySSC0sk9svL9frBBBKf29V/vXi8Mmt1P3EJg1ekiayXL8 8Ia9q57uMDvCyV4hPEkU8by9Szh2XCLlMCZB1S5yWKztmgth9ZRUvB+cX7/CskjtBF6o BrmHczDCMNIGwY6Op8mi5qjTshQnIPEg7amiI9RkHAPQXZEFmrhJXh4gPhPLRoZRlRmC kzcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684221878; x=1686813878; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YDM/0KI2jSc6jBFtRefPfdCkyTGKEYZyqTibHMCF2h8=; b=Yw6DSVbHNWV8hqLuMcJeP4WtC+sO24J9S9mVDW/zZftwPYV7o4KIl38OcaEAJr2UVv uncnyIce74bEZXzVymFX2OVK1hDdEmtHe2hV+dU5lUY/+rYxryVa4PbfoIwjnk2wBXxn KYrlUy83ulCNQ1DnbYuWctVaYCcgIcIgwsh+r5S5+MxFNWsghzfJG4O/z4Srjw9KaamG QHJNcCKgDJiJ4geyHEV32XOnbPUCJo9+WM5CbQM3PHSmP8Vhu9qxzfkl2/GyULcd7LGM tvleUZIzAJZWC10utOt5Owv/BAeoaSRPU07wWJHkM7JvPahlJr1qwBxmbh1SHKgbMTzs //Ew== X-Gm-Message-State: AC+VfDxy5LznWjZr17kKqAkBsLX8DGugS7CPttwVvXUmN9ck5MlJcyw1 iUafdsTxXN6ZhiPvhCzA3N632w== X-Received: by 2002:a1c:ed01:0:b0:3f5:3de:19c0 with SMTP id l1-20020a1ced01000000b003f503de19c0mr5260088wmh.21.1684221878273; Tue, 16 May 2023 00:24:38 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:86be:97a:a043:77a8? ([2a01:e0a:982:cbb0:86be:97a:a043:77a8]) by smtp.gmail.com with ESMTPSA id j16-20020a5d4490000000b0030795b2be15sm1508866wrq.103.2023.05.16.00.24.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 00:24:37 -0700 (PDT) Message-ID: <8a060ecc-4289-15b1-2f31-fe83af77b5ca@linaro.org> Date: Tue, 16 May 2023 09:24:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v6 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check Content-Language: en-US To: Aradhya Bhatia , Tomi Valkeinen , Jyri Sarha , David Airlie , Daniel Vetter , Laurent Pinchart , Andrzej Hajda , Robert Foss , Jonas Karlman , Jernej Skrabec , Rahul T R , Swapnil Jakhade , Boris Brezillon , Francesco Dolcini Cc: DRI Development List , Linux Kernel List , Nishanth Menon , Vignesh Raghavendra , Devarsh Thakkar , Jayesh Choudhary References: <20230509093036.3303-1-a-bhatia1@ti.com> <20230509093036.3303-7-a-bhatia1@ti.com> Organization: Linaro Developer Services In-Reply-To: <20230509093036.3303-7-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2023 11:30, Aradhya Bhatia wrote: > input_bus_flags are specified in drm_bridge_timings (legacy) as well > as drm_bridge_state->input_bus_cfg.flags > > The flags from the timings will be deprecated. Bridges are supposed > to validate and set the bridge state flags from atomic_check. > > Implement atomic_check hook for the same. > > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/bridge/sii902x.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index 662b6cb4aa62..4d1f10532fa6 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -495,6 +495,20 @@ static u32 *sii902x_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, > return input_fmts; > } > > +static int sii902x_bridge_atomic_check(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > +{ > + /* > + * There might be flags negotiation supported in future but > + * set the bus flags in atomic_check statically for now. > + */ > + bridge_state->input_bus_cfg.flags = bridge->timings->input_bus_flags; > + > + return 0; > +} > + > static const struct drm_bridge_funcs sii902x_bridge_funcs = { > .attach = sii902x_bridge_attach, > .mode_set = sii902x_bridge_mode_set, > @@ -506,6 +520,7 @@ static const struct drm_bridge_funcs sii902x_bridge_funcs = { > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > .atomic_get_input_bus_fmts = sii902x_bridge_atomic_get_input_bus_fmts, > + .atomic_check = sii902x_bridge_atomic_check, > }; > > static int sii902x_mute(struct sii902x *sii902x, bool mute) Reviewed-by: Neil Armstrong