Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d84a75724637a58d25ecbc35316b6b11a979e923.camel@redhat.com>
Subject: Re: [PATCH net-next 4/7] net: lan966x: Add support for offloading
 dscp table
From:   Paolo Abeni <pabeni@redhat.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        UNGLinuxDriver@microchip.com
Date:   Tue, 16 May 2023 09:17:08 +0200
In-Reply-To: <20230514201029.1867738-5-horatiu.vultur@microchip.com>
References: <20230514201029.1867738-1-horatiu.vultur@microchip.com>
         <20230514201029.1867738-5-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2023-05-14 at 22:10 +0200, Horatiu Vultur wrote:
> @@ -117,12 +164,16 @@ static int lan966x_dcb_ieee_setapp(struct net_devic=
e *dev, struct dcb_app *app)
>  	if (prio) {
>  		app_itr =3D *app;
>  		app_itr .priority =3D prio;
> -		dcb_ieee_delapp(dev, &app_itr);
> +		lan966x_dcb_ieee_delapp(dev, &app_itr);
>  	}
> =20
> -	err =3D dcb_ieee_setapp(dev, app);
> +	if (app->selector =3D=3D IEEE_8021QAZ_APP_SEL_DSCP)
> +		err =3D lan966x_dcb_ieee_dscp_setdel(dev, app, dcb_ieee_setapp);
> +	else
> +		err =3D dcb_ieee_setapp(dev, app);
> +
>  	if (err)
> -		goto out;
> +		return err;

As Piotr suggested, please drop the out: label altogether, replacing
even the other 'goto out;' statement with a plain return. Additionally
you can replace the final:

	return err;

in this function with:

	return 0;

Thanks,

Paolo