Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f43addc54fd6bafca831d2f2802cc09c4e5baef9.camel@maquefel.me>
Subject: Re: [PATCH 36/43] pwm: ep93xx: drop legacy pinctrl
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Arnd Bergmann <arnd@kernel.org>, Linus Walleij <linusw@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 16 May 2023 13:43:27 +0300
In-Reply-To: <20230515143222.dlhxcze5254773r4@pengutronix.de>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
         <20230424123522.18302-37-nikita.shubin@maquefel.me>
         <20230515143222.dlhxcze5254773r4@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

Hello Uwe!

On Mon, 2023-05-15 at 16:32 +0200, Uwe Kleine-K=C3=B6nig wrote:
> On Mon, Apr 24, 2023 at 03:34:52PM +0300, Nikita Shubin wrote:
> > Drop legacy gpio request/free since we are using
> > pinctrl for this now.
> >=20
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > ---
> > =C2=A0drivers/pwm/pwm-ep93xx.c | 16 ----------------
> > =C2=A01 file changed, 16 deletions(-)
> >=20
> > diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
> > index 8bfe6cfbb3db..657adb011aeb 100644
> > --- a/drivers/pwm/pwm-ep93xx.c
> > +++ b/drivers/pwm/pwm-ep93xx.c
> > @@ -45,20 +45,6 @@ static inline struct ep93xx_pwm
> > *to_ep93xx_pwm(struct pwm_chip *chip)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return container_of(chi=
p, struct ep93xx_pwm, chip);
> > =C2=A0}
> > =C2=A0
> > -static int ep93xx_pwm_request(struct pwm_chip *chip, struct
> > pwm_device *pwm)
> > -{
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct platform_device *pdev=
 =3D to_platform_device(chip-
> > >dev);
> > -
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return ep93xx_pwm_acquire_gp=
io(pdev);
>=20
> I didn't get the whole series and didn't spot a relevant followup
> change

https://lore.kernel.org/all/20230424123522.18302-1-nikita.shubin@maquefel.m=
e/

> on lore.k.o, so: I assume ep93xx_pwm_acquire_gpio() and
> ep93xx_pwm_release_gpio() will be unused in the end? Do you drop
> them?
>=20
> I assume this series target to be taken via arm-soc (once the review
> feedback is positive)?
>=20
> I wonder if this change breaks non-dt machine support?

The aim for the whole series is fully converting to dt, this means
platform files will be dropped.

The v1 series tries not to break anything until platform removal
commit, before this commit non-dt version should be compilable and
fully functional.

>=20
> Best regards
> Uwe
>=20