Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bfcec885-9dc4-ff7f-f7ab-1481a8bae559@intel.com>
Date:   Tue, 16 May 2023 10:23:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@linaro.org>,
        =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
CC:     Luis Chamberlain <mcgrof@kernel.org>,
        Russ Weight <russell.h.weight@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
References: <36ef6042-ce74-4e8e-9e2c-5b5c28940610@kili.mountain>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <36ef6042-ce74-4e8e-9e2c-5b5c28940610@kili.mountain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2ZFalh1eUZwclRnUG96YnZUdUExUWM4OWtiUkt4Uy9CQmdKMVZDWUdRbjZj?=
 =?utf-8?B?Z2tXU05vTUt5Ukk4STNUNzZyekJJd1V4N212dklWUHJVbGU2dVQyay9BalRL?=
 =?utf-8?B?bTNCMjBHVElVblRUNFUzNlZGazBWZXdRcUU1VXlQREswZTd6aW5HVWJFNmk1?=
 =?utf-8?B?MkRtaTlVdiszb2ZBVHBXRzZGYnhYSEVuNDNmWnhLaHg1YVJCSHE0V3hPT0JG?=
 =?utf-8?B?WTEvelJFVVdYV2hwcGhEYU15VHJWamFlZ1Bjb252R0ZGTXRrdWVsWE94eFNL?=
 =?utf-8?B?bDVvTjhwTGRNeWhCdDhHVnF3RmJxODM0dmdYai9KbXVkTkJPaEpLdmZVRlh6?=
 =?utf-8?B?MThtaG9ja0t6cVk4ZS9uNFFHTTZlNFJjUEN5S0Y5TG9GMTFzU1JJYWtNdHNH?=
 =?utf-8?B?VlRDd2xKbFc5akZHcGJGazFPSEVSbUpQOHRKbFpCRW1FcEZRcndJbERpUjNo?=
 =?utf-8?B?WGkwRnpkSnIwOFNTZjJpVFpHU080UjdUclVvemlpQnZHTUJnQmdjYnQxdTlr?=
 =?utf-8?B?Ti85bXROQVZGNjl5MEswVUIzTjl2T3dMU3FhQlVsVDdrS0pydit1eHhBSkFr?=
 =?utf-8?B?V1VjaFdVazlkMGRKR2ZscWJDVWlydTZCT2dlZDZBYkdiUFhrUk83M2taNFJJ?=
 =?utf-8?B?dXpxeG5XdVFldzhMNktKNFdFd0FieUFnQ1NFak1Kdm1sN0pBNGhma1VlVlVL?=
 =?utf-8?B?MW5SYXE3UDRiNEJNUmNseitwYWJmckozaU4rTlRaeXY5YUxQNXdrRHBjenB3?=
 =?utf-8?B?eFZjaEx1THdRWlZLa0lTYUprYnBBOVRoTXZpTlRHUVVJdVVySFpvMkRCbktR?=
 =?utf-8?B?UzA0UFRLc2tITE9pQzhGVWUxVGJnMEhrREN0WW0zSWVKSWFiQWRsMkNMWmNv?=
 =?utf-8?B?WFlwVWFXNC8zamtBNkpMOTFSRjNkZ3lOQS85S0xVRDlqR3dpYmd0WlBJZUtk?=
 =?utf-8?B?SVNTQ21reWQ2TFhnVnNXV3F3VDJUNkIrS2M1TVQ5ZzBWbHpSNVptS3lsR2Nl?=
 =?utf-8?B?dGYwZFE0RnlsSXJtMG1IVWtkMk9zRFh4dlJpOUFqM21SNHFNNElKYlVKOXJq?=
 =?utf-8?B?YVpRWlNSN3JXa2oxTjhvUzZNNHVCcUNNUnhiRGpwZzVWODBUV0hERWlidEVF?=
 =?utf-8?B?YXdLbkJ2bmswR1FTdkF0R1JUVEZDaWs5NUJiNG4vcExaRHZDdTNNUmUzSllL?=
 =?utf-8?B?ejcvTGVqM0lWZ2tRblJrMThscHJmSklZTHV2VlhXL2txTlkxeDkrVE1yNW5G?=
 =?utf-8?B?N2s0Q3NLZ01jYmZJa0hubWlnYzNCTzM5bUhQMTc0QWhMRDBnQ2tjcUppUDFW?=
 =?utf-8?B?V2VPdjJMdnVxVmpmUE9UTlNSVk9KckdPUWV1MzZ6NE5JbGs1T1hzNmR4dzAv?=
 =?utf-8?B?SStrRGpJdTUvQ05SR2I3VVVUdkFwc1IvSzFEQVh1eHZsbDZaemNEcjR4d1Zk?=
 =?utf-8?B?M24yTFV2ajEwZjc3WnpIVS96WERkQVZKV1B5QTVZTFhCV0trZHRNcDg4TkEy?=
 =?utf-8?B?K3hJVzNLM3NxU0pzRGo0bEpwRlpjNjN0MGo2M3N0RG4wRERwT1BUTS9WNkVr?=
 =?utf-8?B?TWRKVk03YlVDNk10dU5ZODRuUmtPeE5idEdWNkZEV2dIaUtqeXFyRlBWalRQ?=
 =?utf-8?B?YXdKQmZXQ2lSZnNRZDgvTVo5MGxxTFp2SndMamtUV3ZBZVZhRUlXZWNUYVBq?=
 =?utf-8?B?NWtkNjcwTER0aU5RN1A5czlyTVNPM3RUcXE5TGxrbDJ1K2NGVkJFNWtxcHVu?=
 =?utf-8?B?bnE5bUZYM1orRDJBR3dMYm1nMXFBS1VGSkcyNVFlUktObDRzRUtqUHFzeHpU?=
 =?utf-8?B?Yy8vV0VkQkFnb1VaaHNWK0N5WXJlMWlUL1JkNlBpNG41R0RKbUNNWlBLWUxj?=
 =?utf-8?B?NVhsdVFKN1BpR0tBYWZrcGRGUm9YMXB4SlpOR3ZkeVNiNEFMc0xlbkUyNk9u?=
 =?utf-8?B?ajg0RkoxbFE3SkM0NUR0cWZ1TEJwd3RYNFBlbFFsTlMzWmFmYjlsaVFJMUI0?=
 =?utf-8?B?Wm92UWlOYWZSYkxpVG5sVEhrc1BJQ0ZiU1ZOemsvSFI0Vk05akhHakRKZytK?=
 =?utf-8?B?Zm1pM2s2QUF1M0dQeEhUemhRZzA0QzgzYUx4eGRzQ1ZLVk9CNWg5VUROYzZx?=
 =?utf-8?B?ZFZYQ1ZuN0o2S3hCUHdCYTM0L05QeUVMaGNvZ2cyQ0dXaWhxajZLSzZubGVu?=
 =?utf-8?B?V3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 574fed80-b96d-4cf6-258c-08db55e6e669
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 08:24:00.3255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zHMSJmbijYeSBWnw+zBlcIkldkYZUXkNrOouKStpHDzZSBMSBPMN8Fg+bm0x5P5Gwk6HUCeAacG3STTprUugDHWTVDsTfR5hFPFV2xLf1QE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7333
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-05-16 10:12 AM, Dan Carpenter wrote:
> The crypto_alloc_shash() function doesn't return NULL, it returns
> error pointers.  Update the check accordingly.
> 
> Fixes: 02fe26f25325 ("firmware_loader: Add debug message with checksum for FW file")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/base/firmware_loader/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
> index 9d79d5ad9102..b58c42f1b1ce 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c
> @@ -812,7 +812,7 @@ static void fw_log_firmware_info(const struct firmware *fw, const char *name, st
>   	char *outbuf;
>   
>   	alg = crypto_alloc_shash("sha256", 0, 0);
> -	if (!alg)
> +	if (IS_ERR(alg))
>   		return;
>   
>   	sha256buf = kmalloc(SHA256_DIGEST_SIZE, GFP_KERNEL);

Thank you for the fix.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>