Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp337916rwd; Tue, 16 May 2023 01:34:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5mnJWEmj56t4IzPN3tBCRJ8rJQIBfTJKfvgbd6AebNnSn6Oe3sV7i4XJW1QuiJTd5xXTK8 X-Received: by 2002:a05:6a00:a8b:b0:643:b27f:6c43 with SMTP id b11-20020a056a000a8b00b00643b27f6c43mr45761283pfl.27.1684226082527; Tue, 16 May 2023 01:34:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684226082; cv=none; d=google.com; s=arc-20160816; b=QzpqK85jofX7PQZ2YiAuIYfb/sTGQj/dxTHcC6BEAvpipf6dkH5336OTLtCYvv16WM I0Qdt+NNkU4QVRcABBIbRPuOsyGFzRHFIr4xAm0rKynw/Yd7RFZaPBXCwTpVTbDxiazp 3L4EiYiBueizmjNGqhXX9EoGzzZIn0IIezM+X8cHqNVGoNQp7vtghe2WRyT+46Ua1eR1 jm/D1WHNiWynmm7S597wCvV8kJYabqZhxANM/AzPGlcxbbcfyHRhAC5CUoe4VhyBiRx0 YNm3hENWrLEBJtcBeyA6wc8aZOJ/fCFzaCLOYdRTnRLNAayWyEBfp23yJwnouOXF2Y8y MDuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:references:cc:to:content-language:subject:reply-to :from:user-agent:mime-version:date:message-id:dkim-signature; bh=tpLX8Svr1/hDnROP2r+zi8Bzotl7nD1x9jwIltUx3rY=; b=qqxBzNRWi03h/lgU53P8vMX1JHOlBuVwXZMbJOZSLR23WzqHtZPU73QWy/pjbi5oHA rOCdVGWBGSzQfRAxgppNTIq6rgj813wPz0WLx/La2JgKgpCsb34fgJOxygmd63e8EMJS bNbm7wqfZ0HlOrjyifNTPd06OEjAz2WpyqnDFY6iY9UlG43VgkO7QkxgW5AfQpDGNg5+ nUaCjEL3nGJF4Tk/39UuVd7Z21VUMZcwMkP9Bo9rrE7mnszZP4z5DivXzxIfQSny+bQI D1E1GHPb9vG9bnwfxvEC5nzIoyp8XVZBkGH1VdXehV5WT3brMerh0SLMExNBPmQxpl6X 6AFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="V4G/vHUs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b5-20020a621b05000000b0063b6ae02400si18633279pfb.293.2023.05.16.01.34.30; Tue, 16 May 2023 01:34:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="V4G/vHUs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231163AbjEPIWr (ORCPT + 99 others); Tue, 16 May 2023 04:22:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231654AbjEPIWl (ORCPT ); Tue, 16 May 2023 04:22:41 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DC0F132 for ; Tue, 16 May 2023 01:22:36 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f42ba32e24so53718465e9.3 for ; Tue, 16 May 2023 01:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684225355; x=1686817355; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tpLX8Svr1/hDnROP2r+zi8Bzotl7nD1x9jwIltUx3rY=; b=V4G/vHUswI8fobflebz4roVsEnsRIW3HmACHq8dZY3Gmmqczsk4xkVgUYCMX9WHi+l 2L6pSWm6gzDFXupXRvv2/E9bpsWlRPSsBT0FKdE9/jMhPFrIrdWCxd05IgBs1OH1o0Qn vHKM7rqYypTrTt0cDnKleQED5uFTCKiOpQL5KWjayyxv+NvF9q4XNQ8igNrUcVaGsTYK dBvkSYAeq/8dn8ibWayt3XYtxCxo7JscCWbh6sgJdeFPCG+x1SAUGN434LTNdB/T7DVE TUk7OFTMjSUGHyElneiGUcZPvz8EM6pfzuVxcMC+AivQz73rBV50idCqvx+xjTNfP7I3 ey9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684225355; x=1686817355; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tpLX8Svr1/hDnROP2r+zi8Bzotl7nD1x9jwIltUx3rY=; b=OZ7NMr7bn91xkYbBFo6eMA7wyfwCb22O9hJzdsULR/fqBEleorsDGsbEWjiAjeGeZR z0yRGSoNVZv2GetiFrrZD7I6AmuU3trIorZ3o8udpRJpjqhjYMgPoCTH7fcCX1k8F3ao ckuVkbtL2pP22UmhHTXHDX3E0z3TQrXVEodWTJk/YaCKjx1TSSsjY6nZuuvTBJWWQA+h vJjjcxj6Zp8xlcdALNDgWOs+/lDRRRF+1LNttS2YvaFxWWWNRL9Zw4aw7Z/KD0xboL2N efDCcIXx/YvE6xlruhv1sSrrEC7gwbsrMXsVQ6D5pYZZVhodIclbBB5DR6UZGSLtxkBr 75Vw== X-Gm-Message-State: AC+VfDxdRc/bTG3JqZLZFrNZ+RGZmLoCKAQfiZiTSy0zt55qYa6zKMsP geidrtgeBVNQPul8EDx6IKljqA== X-Received: by 2002:a1c:f418:0:b0:3f1:6f52:74d with SMTP id z24-20020a1cf418000000b003f16f52074dmr24392159wma.39.1684225354916; Tue, 16 May 2023 01:22:34 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:86be:97a:a043:77a8? ([2a01:e0a:982:cbb0:86be:97a:a043:77a8]) by smtp.gmail.com with ESMTPSA id q14-20020adfdfce000000b00304ae802f02sm1709723wrn.66.2023.05.16.01.22.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 01:22:34 -0700 (PDT) Message-ID: <23cb7112-ce2e-cee6-2213-60fd599c998d@linaro.org> Date: Tue, 16 May 2023 10:22:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v1] meson saradc: fix clock divider mask length Content-Language: en-US To: George Stark , jic23@kernel.org, lars@metafoo.de, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, andy.shevchenko@gmail.com, nuno.sa@analog.com Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru References: <20230515210545.2100161-1-gnstark@sberdevices.ru> Organization: Linaro Developer Services In-Reply-To: <20230515210545.2100161-1-gnstark@sberdevices.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/05/2023 23:05, George Stark wrote: > From: George Stark > > According to datasheets of supported meson SOCs > length of ADC_CLK_DIV field is 6 bits long > > Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs") > Signed-off-by: George Stark > --- > drivers/iio/adc/meson_saradc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index 85b6826cc10c..b93ff42b8c19 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -72,7 +72,7 @@ > #define MESON_SAR_ADC_REG3_PANEL_DETECT_COUNT_MASK GENMASK(20, 18) > #define MESON_SAR_ADC_REG3_PANEL_DETECT_FILTER_TB_MASK GENMASK(17, 16) > #define MESON_SAR_ADC_REG3_ADC_CLK_DIV_SHIFT 10 > - #define MESON_SAR_ADC_REG3_ADC_CLK_DIV_WIDTH 5 > + #define MESON_SAR_ADC_REG3_ADC_CLK_DIV_WIDTH 6 > #define MESON_SAR_ADC_REG3_BLOCK_DLY_SEL_MASK GENMASK(9, 8) > #define MESON_SAR_ADC_REG3_BLOCK_DLY_MASK GENMASK(7, 0) > Reviewed-by: Neil Armstrong