Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 17:20:30 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>
CC:     <kvm@vger.kernel.org>, Jiaan Lu <jiaan.lu@intel.com>,
        Zhang Chen <chen.zhang@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        "Paolo Bonzini" <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 04/11] KVM: VMX: Add IA32_SPEC_CTRL virtualization
 support
Message-ID: <ZGNK3hHhCHU6l7h+@chao-email>
References: <20230414062545.270178-1-chao.gao@intel.com>
 <20230414062545.270178-5-chao.gao@intel.com>
 <6b861c8d-9b93-74f2-6073-6f1284e72fd2@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6b861c8d-9b93-74f2-6073-6f1284e72fd2@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ExKNJLRQE/0V2T+yWOsbqEealvZz+ihZXY8kE04RyJyOTYbi/7eb1DGui/i0?=
 =?us-ascii?Q?MlLJkmdGXk0KToLh3rityWaq4BpYh8TIHuyAQpoEBcONqpU2Oi9yZ5xb1Cqz?=
 =?us-ascii?Q?VJtY5npXU876uIhGkURbaWJ1C9Co6JADmNwnNKZIdkW4crc8/d5MA+KYLS0v?=
 =?us-ascii?Q?6VYDpzOxrDaGQ3w80TPMY6Gmacw/dv35+hGVlJfiqz6Zz6Ew1/E5HLqjRgQ+?=
 =?us-ascii?Q?JbZNAGEg7UQUpZF+mZAkAf7jNDNhiNEcONoAu1tZeHv6UP8onzPqha/+CFoa?=
 =?us-ascii?Q?aLuxIWt5h09ssBPpNTMykHzPA0vSjmsMsVWMlhQjo0jxPQndGxzZ+hVdMz4B?=
 =?us-ascii?Q?mikMXYphO5MNvPXUN1Id5j75m++R5McWX+3WMFU3v9lqzF9fAbkrb71VyAFN?=
 =?us-ascii?Q?V87BbyesC/5ZGdmNzDTbIvhT2bwPzLEy7pz33A1dC4a3s8evf8kWsFFi/b9v?=
 =?us-ascii?Q?JNtC02JW8vhZf8EOQTb1bmWwgJ7Ky7KaAWlVAEw5scFkLp31LqMZ44l4RDry?=
 =?us-ascii?Q?2IEMD954SylsiU3oskqGdmptinboh7RgaEGLiK1s6iJmz1dGdnvOHPdRT11H?=
 =?us-ascii?Q?ywfw649aI7kqvUHggEpeeHZUSLQzaqSj5e2ymdUmBONH8MOIcl0VrmpA15uA?=
 =?us-ascii?Q?Zvga7biYpFkkJwvUiNRtX0iW1byAc7TMpU/Ot/8+JNPqVOL/T8Gf4AEKZ+0Z?=
 =?us-ascii?Q?0yqjYpz+LtVNZ/Xz6Rz+MirLDTGmGwW8xACKTzMbVDbR9sH0t+L20NcXeeJX?=
 =?us-ascii?Q?FCXRz1aGAupCy/DBBeCNip/29eCS97va5Dqv6cslfR8JwLNs5r9I0p4+otzY?=
 =?us-ascii?Q?1m1w8HxV2LIjyjw+D8G/YP2dFAjrThldZ++wCCpDaJNmPhNo+zEqKZVpO1Rc?=
 =?us-ascii?Q?1IK3A4RDk25XdZ8brZwzZkweuh/Od3XeOdfjVm59gBIUxOif1h+26H/EGqov?=
 =?us-ascii?Q?3mSs43j/g40zl7orkiGBPvq/m1C8XZjfmS4WH1Z++NhhhBetQCdqnjJ/sfwD?=
 =?us-ascii?Q?o4r72yBDNKg/diCjLZCkbfr4nGvtpRzC7C8RepHw/i0B7FiMctIm8InRCe8u?=
 =?us-ascii?Q?HR7HMa4oENV/1MN+20hQOSramfs91WCiJIpw7ucXdorLgWE/VpZoQRhmIiPn?=
 =?us-ascii?Q?ZZ0OI0cWRqJyHwYrmchKv+9pXp04xgqHx9lcNh1eo61Cw/UId1aSWDAdo+rW?=
 =?us-ascii?Q?H8R3ukvquYira8A0SbiYYnLOCPv1/SoLWMmVieHawhy4XCxuqb5GZraM5R2i?=
 =?us-ascii?Q?mkmWclJoIBq3HM/0vVPhQGBro2eTXweiiuSZa1Dvbo1J2UJYwXjVmFIBhU2n?=
 =?us-ascii?Q?dpzxUinjpgZ9pEs+DrdAJhVAwnB21vT5ysX3s6+r3xmsEYYiltWuZuDqDaGX?=
 =?us-ascii?Q?o8Kn+1eSsAPJ5NYiaenZzD+y97fh9WXfriex7fhC3kBJEYdDzppoo1H/dIxL?=
 =?us-ascii?Q?gbxgpun11/f5K/KtVxmarsRapVVdgmvLO1mvqEFddAHDRo98dX0DIHNRz+O6?=
 =?us-ascii?Q?2kLkA462iyhZr5DP641fVZIOq8TsclsYQa95WmePbEsOx7mYM5PMPC0tu9gJ?=
 =?us-ascii?Q?ovxRTBS5jDZy7I9At0SNUW18aWxkBSjSNKXG81BV?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b2ef9a02-ddf4-4e10-dec2-08db55eed1a5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 09:20:41.3717
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bB+Ld4E074X6ENqEcKo2SPNgqNPFX9nQ0G+rmhf8aU+A1XygLtipUmX2dvu1VhNZgShwBQ+H1h9dhJNqklcWKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5564
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 16, 2023 at 03:16:59PM +0800, Xiaoyao Li wrote:
>On 4/14/2023 2:25 PM, Chao Gao wrote:
>
>...
>
>> +static inline void vmx_set_guest_spec_ctrl(struct vcpu_vmx *vmx, u64 val)
>> +{
>> +	vmx->guest_spec_ctrl = val;
>> +
>> +	/*
>> +	 * For simplicity, always keep IA32_SPEC_CTRL_SHADOW up-to-date,
>> +	 * regardless of the MSR intercept state.
>> +	 */
>> +	if (cpu_has_spec_ctrl_virt())
>> +		vmcs_write64(IA32_SPEC_CTRL_SHADOW, val);
>> +
>> +	/*
>> +	 * Update the effective value of IA32_SPEC_CTRL to reflect changes to
>> +	 * guest's IA32_SPEC_CTRL. Bits in the mask should always be set.
>> +	 */
>
>Why bits in the mask should always be set?
>
>The bits set in the mask only means them cannot be modified by guest. KVM can
>use the mask to force the bits to 0 as well.

Yes.

Because there is no use case for VMMs to lock some bits to 0 behind guests, this
isn't used in series. There was a note in v1's changelog [1]:

	Note "virtual IA32_SPEC_CTRL" is now used by VMM to enforce some bits
	of IA32_SPEC_CTRL to 1 (i.e., enabled some HW mitigations transparently
	for guests). In theory, VMM can disable some HW mitigations behind guests.
	But to keep this series simple, we leave that for future work.


But somehow I dropped it (when I tried to slim down the changelog). Will add it
back and add a comment above the definition of spec_ctrl_mask.

[1]: https://lore.kernel.org/lkml/20221210160046.2608762-5-chen.zhang@intel.com/

>
>> +	vmx->spec_ctrl = val | vmx_get_spec_ctrl_mask(vmx);
>> +}
>>   #endif /* __KVM_X86_VMX_H */
>