Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexey Romanov <AVRomanov@sberdevices.ru>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
CC:     "minchan@kernel.org" <minchan@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage()
Thread-Topic: [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage()
Thread-Index: AQHZh9vrJATALyC8P0GomQA8blaPZ69cdoOAgAAFE4A=
Date:   Tue, 16 May 2023 10:11:44 +0000
Message-ID: <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881>
References: <20230516095029.49036-1-avromanov@sberdevices.ru>
 <20230516095327.GA15689@google.com>
In-Reply-To: <20230516095327.GA15689@google.com>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E07895E9119B50448C049C809AA8A778@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hello!

On Tue, May 16, 2023 at 06:53:27PM +0900, Sergey Senozhatsky wrote:
> On (23/05/16 12:50), Alexey Romanov wrote:
> >  mm/zsmalloc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > index 702bc3fd687a..f23c2da55368 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -1888,7 +1888,7 @@ static struct zspage *isolate_zspage(struct size_=
class *class, bool source)
> >  		fg[1] =3D ZS_ALMOST_EMPTY;
> >  	}
> > =20
> > -	for (i =3D 0; i < 2; i++) {
> > +	for (i =3D 0; i < ARRAY_SIZE(fg); i++) {
> >  		zspage =3D list_first_entry_or_null(&class->fullness_list[fg[i]],
> >  							struct zspage, list);
> >  		if (zspage) {
>=20
> This patch needs to be dropped. We don't have that function anymore.

Do I need to sumbit v2 without this patch, or will Andrew just take
only the 2/2 patch into the branch?

--=20
Thank you,
Alexey=